jpribyl
bd51cd332b
Cancel all open orders after receiving /stop or ctrl+c
2020-05-01 10:36:11 -06:00
Matthias
40d4949f06
Don't handle trades if they've just been closed.
2020-05-01 17:46:01 +02:00
Matthias
7558e4bffe
Split fee detection from trades from general logic
2020-05-01 16:13:07 +02:00
Matthias
371100a97c
Update fee handling
2020-05-01 16:01:33 +02:00
Matthias
db8fb39a38
don't use trade.update directly!
2020-05-01 15:50:02 +02:00
Matthias
a867d40eac
Move fee_methods to exchange
2020-04-30 19:33:27 +02:00
Matthias
d3b9f4d393
Add extract_cost_curr_rate
2020-04-30 19:28:36 +02:00
Matthias
6d7a3a0cc9
Extract more logic into order-has_fee
2020-04-30 07:12:08 +02:00
Matthias
b125dd3728
Extract order_has_fee method
2020-04-30 07:06:06 +02:00
Matthias
431b244f43
Merge branch 'develop' into interface_ordertimeoutcallback
2020-04-19 06:58:44 +02:00
Matthias
0273539f06
Remove exceptionhandler, this exception is handled in
...
cancel_with_response
2020-04-17 19:55:53 +02:00
Matthias
1069cb3616
Use cancel_order_with_result when cancelling orders after timeout
2020-04-17 17:53:56 +02:00
Matthias
fc684b0091
Ensure deleting filled is not raising an error if filled does not exist
2020-04-17 06:59:52 +02:00
hroff-1902
68be239a0e
Merge pull request #3146 from freqtrade/buy_order_timeout_logging
...
Improve handling for buy order cancels
2020-04-16 23:41:45 +03:00
Matthias
1f70fcfa2d
Update logmessage
2020-04-16 20:19:34 +02:00
Matthias
f39706cabd
Fix #3130 - when corder['remaining'] contains none-type
2020-04-09 19:35:27 +02:00
Matthias
5cff72a42e
Improve logging to ensure which branch is used for buy order cancels
2020-04-09 09:22:38 +02:00
Matthias
95011919d3
Remove questionable handling of orders
2020-03-25 11:18:33 +01:00
Matthias
3c1b155e9f
Remove filled if amount is modified to suit fee structure
2020-03-25 09:43:04 +01:00
Matthias
f3103be15c
Fix test
2020-03-25 09:43:04 +01:00
Matthias
700cedc573
Unify handling of open orders to update_trade_state
2020-03-25 09:43:04 +01:00
Matthias
7c47c6e3bd
check for timeouts before exiting positions
2020-03-25 09:43:04 +01:00
Matthias
9c351007f5
Provide reason for cancelled sell order
2020-03-25 09:43:04 +01:00
Matthias
1817e6fbdf
Combine real_amount updating into one method
2020-03-25 09:43:04 +01:00
Matthias
2c434e9b11
Add close_proit_abs column
2020-03-22 11:16:23 +01:00
hroff-1902
fb4e9b3938
Merge pull request #3025 from yazeed/minor_create_trade_optimization
...
minor create_trade() optimization
2020-03-21 10:36:39 +03:00
Yazeed Al Oyoun
942792f123
updated as suggested
2020-03-20 05:48:53 +01:00
Matthias
5e702f6891
Verify cancel_order returnvalue is a dictionary
2020-03-19 19:44:14 +01:00
Matthias
a1bbeaa668
Merge branch 'develop' into interface_ordertimeoutcallback
2020-03-15 14:56:14 +01:00
hroff-1902
3208faf7ed
Do not use ticker where it's not a ticker
2020-03-08 20:47:02 +03:00
Matthias
847df7b70c
Merge pull request #3026 from yazeed/add_default_to_ignore_roi_if_buy_signal
...
default for ignore_roi_if_buy_signal in freqtradebot.py
2020-03-06 19:35:41 +01:00
Yazeed Al Oyoun
b8d05d8751
found instance of config get without default
2020-03-05 22:14:05 +01:00
Yazeed Al Oyoun
0587256733
minor create_trade() optimization
2020-03-05 21:57:01 +01:00
Yazeed Al Oyoun
4474482307
unifying get_sell_rate with get_buy_rate
2020-03-05 20:44:29 +01:00
hroff-1902
34093d1208
Merge branch 'develop' into no-percent-1
2020-03-05 14:27:12 +03:00
Matthias
53dcb5d5ed
Fix logging expression
2020-03-03 19:36:03 +01:00
Matthias
6e2290c4f0
Allow last to be empty -
...
closes #3005
2020-03-02 20:05:54 +01:00
hroff-1902
e411717de9
No percent where ratio is to be used
2020-02-28 12:36:39 +03:00
Matthias
0fea3a7ea7
Some final polish to configurable_side
2020-02-26 19:50:17 +01:00
Matthias
8edc3eb5fb
Use generator to generate sell price scaffold testing
2020-02-26 19:39:12 +01:00
Matthias
e4b2949188
Change buy_rate calculation to use price_side
2020-02-26 19:39:12 +01:00
Matthias
5f71232038
Refactor get_buy_rate to use rate variable
2020-02-26 19:39:12 +01:00
Matthias
de48a697b0
Use price_side for get_sell_rate
2020-02-26 19:39:12 +01:00
hroff-1902
e6d003f8f2
Merge pull request #2973 from freqtrade/support_non_pairs
...
Support non pairs
2020-02-26 12:20:45 +03:00
Matthias
4e218be51d
Don't use markets[pair]['quote']
2020-02-26 07:08:09 +01:00
hroff-1902
5a900858d8
Merge branch 'develop' into rate_caching
2020-02-26 04:04:20 +03:00
Matthias
a030ce9348
Reformat if condition
2020-02-25 20:22:59 +01:00
Matthias
d44f6651c4
Fix small parenteses bug
2020-02-25 19:55:23 +01:00
Matthias
e8eaa8920e
Use get_base_currency instead of splitting by /
2020-02-25 07:01:31 +01:00
Matthias
61037ab7b8
Implement get_pair_base_curr and get_pair_quote_curr
2020-02-24 21:50:27 +01:00
Matthias
77ef3240cd
Implement log messages
2020-02-22 11:20:19 +01:00
Matthias
97e6e5e976
Implement caching in the correct place
2020-02-22 11:12:33 +01:00
Matthias
f5b4a6d3d7
Remove fetch_ticker caching
2020-02-22 11:10:05 +01:00
Matthias
bf556c8678
Merge branch 'develop' into interface_ordertimeoutcallback
2020-02-21 20:35:07 +01:00
Matthias
6c01542fed
Ad check_sell_timeout
2020-02-21 20:27:13 +01:00
hroff-1902
269a669af8
Move heartbeat to worker
2020-02-21 05:07:31 +03:00
Matthias
ab27d2c720
Merge pull request #2921 from hroff-1902/adjust-buy-notification
...
Move rpc send to be after db session add/flash
2020-02-14 20:02:56 +01:00
hroff-1902
20c21b42d5
Move rpc send to be after db session add/flash
2020-02-14 06:23:03 +03:00
hroff-1902
36ef5c6bdf
Get rid of delete_trades method in Freqtradebot
2020-02-14 04:05:17 +03:00
Yazeed Al Oyoun
f09af888b1
modified get_buy/sell_rate refresh to true on notify_sell_cancel and notify_buy_cancel
2020-02-12 21:55:38 +01:00
Yazeed Al Oyoun
f6db784a85
removed default to refresh argument in get_buy_rate and get_sell_rate
2020-02-12 21:50:33 +01:00
Yazeed Al Oyoun
cde1b2b56c
readded rpc status message for partial buys
2020-02-11 16:28:48 +01:00
Yazeed Al Oyoun
5f4c209fca
fixed one more occurence of executed buy, and test
2020-02-11 16:14:49 +01:00
Yazeed Al Oyoun
4fedf1e564
default refresh TRUE on get_buy_rate and get_sell_Rate
2020-02-11 16:05:44 +01:00
Yazeed Al Oyoun
867b736b84
Fixed to Executing Buys & Sells
2020-02-11 15:50:21 +01:00
Yazeed Al Oyoun
7f4b90c68f
fixed actual open_rate in notify_buy_cancel
2020-02-11 15:45:35 +01:00
Yazeed Al Oyoun
f99d1c3829
fixed open_rate instead of open_rate_requested
2020-02-11 15:44:47 +01:00
Yazeed Al Oyoun
879b513822
enhanced method description
2020-02-08 21:31:36 +01:00
Yazeed Al Oyoun
f3b1161640
wide notifications fixes
2020-02-08 21:02:52 +01:00
Matthias
49dcc561b7
POC for check_buy_timeout
2020-02-06 20:30:17 +01:00
Yazeed Al Oyoun
91b4c9668c
More consistency changes...
2020-02-04 01:57:24 +01:00
hroff-1902
d457d43999
Merge pull request #2833 from hroff-1902/type-hints
...
Add some type hints
2020-02-03 23:24:26 +03:00
Matthias
e3cb5d26c0
Merge pull request #2835 from yazeed/reduce_noise_if_use_order_book_true
...
reduced noise without verbose mode if use_order_book is true
2020-02-02 19:42:50 +01:00
hroff-1902
e8c1abc509
Merge pull request #2799 from freqtrade/fix_stoploss_recreated
...
Fix stoploss recreated
2020-02-02 16:59:45 +03:00
hroff-1902
6594679e52
Merge pull request #2779 from freqtrade/stoploss_market
...
Stoploss on exchange for Kraken
2020-02-02 14:48:45 +03:00
Yazeed Al Oyoun
aeabe1800b
modified two lines from logger.info to logger.debug cause they're too spammy
2020-02-02 10:49:00 +01:00
hroff-1902
f3d500085c
Add some type hints
2020-02-02 07:00:40 +03:00
hroff-1902
e1356fb80e
Merge pull request #2800 from yazeed/enhanced_check_depth_of_market_logging
...
better logging on check_depth_of_market_buy()
2020-01-29 10:56:14 +03:00
Yazeed Al Oyoun
a0b92fe0b1
removed typo
2020-01-28 19:29:47 +01:00
Yazeed Al Oyoun
328a9ffafd
fixed typo in false statement
2020-01-28 19:27:49 +01:00
hroff-1902
30e3e434ab
Add notify_status() to FreqtradeBot
2020-01-27 03:34:53 +03:00
Yazeed Al Oyoun
f8db7f1709
added ask price, bid price, immediate ask quantity, and immediate bid quantity to check_depth_of_market_buy. also added a line that mentions if delta condition was satisfied or not.
2020-01-25 04:17:41 +01:00
Matthias
70b9bd9c0e
Verify if trade is closed before acting on Stoploss_on_exchange
2020-01-23 20:36:48 +01:00
Matthias
ea5ac1efb5
Don't handle stoploss if there is an open regular order
2020-01-23 20:24:23 +01:00
Matthias
a83de241e4
Check for closed stoploss-orders first
2020-01-23 19:40:31 +01:00
Matthias
1d141cd406
Merge branch 'develop' into stoploss_market
2020-01-23 19:35:05 +01:00
Matthias
bc4c469797
Merge branch 'develop' into stoploss_market
2020-01-22 20:51:52 +01:00
Matthias
aad10ceee3
Add threading lock object for /forcesell
...
Protects against stoploss_on_exchange order recreation
in case of /forcesell (it's a timing issue, so may or may not happen).
2020-01-22 20:50:09 +01:00
Matthias
8a940eb0c1
Align price finding function name on buy side with get_sell_rate
2020-01-22 14:46:28 +01:00
Matthias
1bf475fa1a
Remove .get calls for dry_run - it's a mandatory property
2020-01-20 20:24:40 +01:00
Matthias
cf9331919f
move exchange-specific order-parsing to exchange class
...
Related to stoploss_on_exchange in combination with trailing stoploss.
Binance contains stopPrice in the info, while kraken returns the same
value as "price".
2020-01-19 19:54:30 +01:00
Matthias
256fc2e78c
Rename stoploss_limit to stoploss
2020-01-19 13:30:56 +01:00
Matthias
8d2e0bfd62
Move rate-calcuation for stoploss-limit order to exchange
2020-01-19 13:13:09 +01:00
Matthias
29a5e4fba1
Update wallets before getting amount
2020-01-15 21:52:54 +01:00
Matthias
8bcfe4a6aa
Up log level of safe_sell_amount message
2020-01-15 21:01:36 +01:00
Matthias
d1bf388b0e
Wallet amount must be compared with >=
2020-01-15 19:56:14 +01:00
Matthias
fab19ae3a7
Implement last_stake_amount_min_ratio
2020-01-10 06:36:28 +01:00
Matthias
9713dc8d94
Ensure wallets.update is called before buy
...
closes #2756
2020-01-09 20:09:21 +01:00
Matthias
b37f34ff5b
Implement amend_last_stake_amount
2020-01-05 13:25:11 +01:00
Matthias
a75420f75f
Merge branch 'develop' into relative_stake
2020-01-05 12:55:55 +01:00
Matthias
7daa5bc338
Don't return None from unlimited_stake - 0 handles this just as well
2020-01-05 12:50:44 +01:00
Matthias
455838648d
Apply get_available_balance logic to regular trades, too
2020-01-03 10:41:10 +01:00
Matthias
3c7981160c
Extract get_available_stake_amount
2020-01-03 10:14:23 +01:00
Matthias
560aea876e
Remove fiat_currency temporary variable
2020-01-02 20:20:29 +01:00
Matthias
cba156dfff
Add offset calculation for relative stake maximum limit
2020-01-02 13:20:57 +01:00
hroff-1902
a47a25ca88
Refine passing msg params
2020-01-02 14:38:25 +03:00
hroff-1902
88efa4065b
Align the name of a variable to be same for buy and sell parts
2020-01-02 13:56:16 +03:00
hroff-1902
f15e5e9d57
Add _notify_buy()
2020-01-02 13:51:25 +03:00
hroff-1902
e89fa44680
Arrange common section for update trade state methods
2020-01-02 11:50:54 +03:00
hroff-1902
21418e2988
Minor: fix comment
2020-01-02 03:16:18 +03:00
hroff-1902
4475110df8
Cosmetics in freqtradebot
2020-01-02 03:07:24 +03:00
Matthias
3327ebf2b1
Merge pull request #2720 from hroff-1902/refactor-create-trades
...
Refactor create trades
2019-12-31 15:34:12 +01:00
Matthias
26a2395aeb
Include Pair name in exception log message
2019-12-31 07:11:09 +01:00
hroff-1902
fd7af587da
Rename process_maybe_execute_buys() --> enter_positions()
2019-12-30 22:50:56 +03:00
hroff-1902
84918ad424
Rename process_maybe_execute_sells() --> exit_positions()
2019-12-30 22:08:36 +03:00
hroff-1902
b00406a7eb
Make process_maybe_execute_*() returning integers
2019-12-30 21:09:35 +03:00
hroff-1902
4d56e3b36e
Address some comments made in the review
2019-12-30 20:54:32 +03:00
Matthias
1ffda29fd2
Adjust improts to new exception location
2019-12-30 15:02:17 +01:00
Matthias
4c9295fe2d
Rename Bid-strategy helpervariable to something shorter
...
avoids unnecessary wrapping...
2019-12-30 14:00:34 +01:00
hroff-1902
04f28ed9bc
Refactor try/except: handle DependencyException for each pair separately
2019-12-29 05:03:10 +03:00
hroff-1902
762604300f
Refactor create_trades()
2019-12-29 04:37:44 +03:00
hroff-1902
433fd2a7c3
Merge pull request #2652 from freqtrade/safe_sell_amount
...
Safe sell amount
2019-12-29 00:09:21 +03:00
hroff-1902
5c39ebd0a0
Adjust logging
2019-12-28 13:59:40 +03:00
Matthias
443fd8f7dd
Merge branch 'develop' into safe_sell_amount
2019-12-28 09:42:52 +01:00
hroff-1902
d6ca562b03
Make mypy happy and handle hypothetical case when stake_amount == 0
2019-12-28 04:05:03 +03:00
hroff-1902
3dbd83e35a
Introduce get_free_open_trades() method
2019-12-28 03:46:42 +03:00
hroff-1902
8eeabd2372
Move warning to create_trades()
2019-12-28 03:22:50 +03:00
hroff-1902
ed9cb4219d
Make mypy happy
2019-12-28 02:58:23 +03:00
hroff-1902
ef92fd775c
Align behavior: check for available in all cases: edge, unlimited and fixed
2019-12-28 02:53:41 +03:00
hroff-1902
abaeab89aa
Make _calculate_unlimited_stake_amount() a separate method
2019-12-28 02:36:32 +03:00
hroff-1902
243bcb2368
Make _check_available_stake_amount() a separate method
2019-12-28 02:25:43 +03:00
hroff-1902
86f2693040
cosmetics
2019-12-28 01:54:12 +03:00
hroff-1902
b6d1c5b17a
_get_trade_stake_amount() is not private
2019-12-28 01:44:51 +03:00
hroff-1902
039dfc302c
No need to convert pair name
2019-12-28 01:34:31 +03:00
Matthias
6688a2c112
Merge branch 'develop' into doc/pricing_reasons
2019-12-24 06:33:51 +01:00
Matthias
c6d2233978
Convert StrategyLoader to static loader
2019-12-23 10:23:48 +01:00
Matthias
560acb7cea
Convert ExchangeResolver to static loader class
2019-12-23 10:03:18 +01:00
Matthias
6507a26cc1
Fix some tests after merge
2019-12-18 20:16:53 +01:00
Matthias
e72c6a0d94
use only first part of the currency to get wallet-amount (!!)
2019-12-18 20:02:15 +01:00
Matthias
834a0ed620
Merge branch 'develop' into safe_sell_amount
2019-12-18 19:45:31 +01:00
Matthias
21622ac313
Rename get_ticker to fetch_ticker
2019-12-18 16:34:30 +01:00
Matthias
a2964afd42
Rename profit_percent to profit_ratio to be consistent
2019-12-17 08:53:30 +01:00
Matthias
861a7834fc
Call calc_open_price() whenever necessary
2019-12-17 07:08:36 +01:00
Matthias
5a5741878c
Improve dry-run calculations
2019-12-15 10:26:56 +01:00
Matthias
f0bbc75038
Combine dry_run wallet into original Wallets class
2019-12-15 09:48:35 +01:00
Matthias
fda8f7e305
Introuce WalletDry - supporting dry-run wallets
2019-12-15 09:38:18 +01:00
Matthias
04257d8ecc
Add tests for safe_sell_amount
2019-12-13 07:06:54 +01:00
Matthias
5db883906a
Try to verify available amount on the exchange
2019-12-13 06:52:33 +01:00
Matthias
e4655c9b07
include trade-duration with sell-notification
2019-12-08 14:07:46 +01:00
hroff-1902
a373e48939
Comment added
2019-11-27 14:53:01 +03:00
hroff-1902
17269c88be
Fix _get_min_pair_stake_amount()
2019-11-26 11:57:58 +03:00
Matthias
a5bd4e329a
improve cancel_order handling
2019-11-20 20:36:38 +01:00
Matthias
9aac080414
Fix 'remaining' bug when handling buy timeout
2019-11-20 20:10:41 +01:00
Matthias
09b302abf7
Merge pull request #2442 from freqtrade/volumeList_enhanced_filter
...
Pairlists enhanced filter options
2019-11-19 20:19:10 +01:00
Matthias
68904296e7
Allow timeout of 0
2019-11-13 19:38:38 +01:00
Matthias
2eb6513251
Improve timedout handling
2019-11-12 15:45:14 +01:00
Matthias
748fe94603
Merge branch 'develop' into volumeList_enhanced_filter
2019-11-09 15:34:47 +01:00
Matthias
e632720c02
Allow chaining of pairlists
2019-11-09 06:55:16 +01:00
Matthias
c8638ce82f
Fix bug where bids_to_ask_delta causes doublebuys
...
The continue must happen irrespective of the outcome of this - otherwise
the below BUY will happen anyway.
2019-11-05 21:03:06 +01:00
hroff-1902
3149c12a14
Merge pull request #2444 from freqtrade/sql_cleanup
...
Fix scoped_session and add Documentation for strategy
2019-10-31 23:19:30 +03:00
Matthias
9e988783de
Allow configuration of stoploss on exchange limit
...
fixes #1717
2019-10-30 20:07:26 +01:00
Matthias
01efebc42f
Extract query to it's own function
2019-10-30 11:12:49 +01:00
Matthias
20dabd9c41
Merge branch 'develop' into whitelist_docs
2019-10-26 13:36:39 +02:00
Matthias
d0521d33ce
Refactor whitelist handling
...
fixes #2413
2019-10-26 11:36:02 +02:00
Matthias
3929ad4e1f
Fix typo
2019-10-26 09:21:51 +02:00
Matthias
2f1d9696cd
Change keepalive to heartbeat
2019-10-25 20:00:08 +02:00
Matthias
0773a65333
Add I Am Alive Message
2019-10-25 15:01:35 +02:00
Matthias
8201f70a80
Change loglevel of repeated message to debug
2019-10-25 14:19:02 +02:00
hroff-1902
2e1e080022
Fix potential race conditions between RPC and Freqtradebot during initialization
2019-10-24 22:33:44 +03:00
hroff-1902
30eb23e1aa
Minor freqtrade cleanup
2019-10-18 23:41:07 +03:00
hroff-1902
9e23ca14d1
Merge pull request #2384 from freqtrade/improve_buy_timeout_handling
...
Improve buy timeout handling
2019-10-18 22:30:41 +03:00
Matthias
c649f9844e
Compare >= instead of =
2019-10-18 19:36:04 +02:00
Matthias
9d739f98ac
use requested - remaining amount - not the requested amount!
2019-10-18 09:04:05 +02:00
Matthias
271846dfb6
Simplify cancel timedout
2019-10-18 07:01:05 +02:00
Matthias
c181fac6c7
fix #2383
2019-10-18 06:48:39 +02:00
Matthias
c735d35265
Extract open_trade generation from freqtradebot
2019-10-18 06:48:33 +02:00
Matthias
85c4546333
Merge pull request #2343 from hroff-1902/move-experimental
...
Move experimental settings to ask_strategy
2019-10-10 16:08:11 +02:00
hroff-1902
9b23376415
Move experimental settings to ask_strategy
2019-10-05 13:29:59 +03:00
hroff-1902
75252b6251
Docstrings improved
2019-10-04 02:32:48 +03:00
hroff-1902
89729aefe8
Fix and improve process_maybe_execute_sells()
2019-10-02 18:47:45 +03:00
hroff-1902
096c69dc4f
Refactor Freqtradebot
2019-10-02 13:51:32 +03:00
Matthias
43f2ef226c
Change rel_tol to abs_tol to avoid surprises with high priced pairs
2019-09-28 10:30:12 +02:00
Matthias
8d92f8b362
Compare floats via isclose instead of ==
2019-09-26 07:18:00 +02:00
hroff-1902
849d694c27
Don't inherit from object
2019-09-12 04:39:52 +03:00
hroff-1902
caec5ac941
Merge pull request #2206 from freqtrade/sloe_handling
...
Improve stoploss on exchange handling
2019-09-04 10:00:53 +03:00
Matthias
aae9c3194f
Reenable stoploss_on_exchange for dry-run
2019-09-01 17:48:06 +02:00
Matthias
20c9c93b3e
Improve docstring
2019-09-01 10:25:05 +02:00
Matthias
771519e311
Don't show stacktrace in case of invalidorder Error
...
This is handled gracefully by emergency-selling
2019-09-01 10:19:18 +02:00
Matthias
9d7ebc65e7
Move return statement to correct intend
2019-09-01 09:21:45 +02:00
Matthias
7c0a49a6f9
_notify_sell needs ordertype seperately
2019-09-01 09:17:58 +02:00
Matthias
292df115e8
Support selling via emergencysell
2019-09-01 09:09:07 +02:00
Matthias
9f53e9f5dd
Raise InvalidOrder error when stoploss-creation fails
2019-09-01 09:08:35 +02:00
Matthias
7fc156648a
simplify stoploss_oe code
2019-08-31 16:15:39 +02:00
Matthias
f0c0f5618b
Abstract creating stoploss-orders from stoploss-logic
2019-08-31 16:11:04 +02:00
Matthias
513e84880e
Don't escape ticks where it's not needed
2019-08-25 20:38:51 +02:00
Matthias
3f6eeda3f0
Reset stoploss_order_id when recreating fails
2019-08-24 18:06:14 +02:00
Matthias
b6462cd51f
Add explaining comment
2019-08-18 16:22:18 +02:00
Matthias
ddfadbb69e
Validate configuration consistency after loading strategy
2019-08-18 16:10:10 +02:00
Matthias
14c4854987
Merge branch 'develop' into lock_pairs
2019-08-15 06:56:39 +02:00
Matthias
9f26c4ebdc
Merge branch 'develop' into fix/sell_order_hanging
2019-08-15 06:46:12 +02:00
Matthias
a4ab42560f
improve docstring for create_trades
2019-08-14 06:16:59 +02:00
Matthias
a76136c010
Rename create_trade to create_trades
2019-08-14 06:16:43 +02:00
Matthias
6948e0ba84
Handle orderbook_depth check correctly
2019-08-13 10:12:02 +02:00
Matthias
997eb7574a
Support creating multiple trades in one iteration
2019-08-13 10:01:29 +02:00
Matthias
8873e0072c
process_maybe_execute_buy does not need to return bool
2019-08-13 09:42:22 +02:00
Matthias
4b8eaaf7aa
freqtradebot.process() does not need to return anything
2019-08-13 09:37:56 +02:00
Matthias
28e318b646
Lock pairs for stoploss_on_exchange fills too
2019-08-13 08:47:11 +02:00
Matthias
59acd5ec7c
Lock pair for the rest of the candle in case of sells
2019-08-12 20:39:34 +02:00
Matthias
241d510096
Handle and update sell-orders immediately if they are closed
2019-08-12 16:34:55 +02:00
Matthias
4b4fcc7034
Change stoploss_on_exchange in freqtradebot
2019-08-11 19:43:57 +02:00
Matthias
05b1854946
Gracefully handle InvalidOrderException.
2019-07-25 19:56:59 +02:00
hroff-1902
21bf01a24c
partial freqtradebot cleanup
2019-06-27 22:29:17 +03:00
Matthias
f8dd0b0cb3
Use parenteses instead of \ seperators
2019-06-27 06:32:26 +02:00
hroff-1902
05d93cda16
fix #1963
2019-06-27 01:03:38 +03:00
Matthias
9d2b6db97b
Merge pull request #1954 from freqtrade/fix/stoploss_cancel_error
...
Trailing stoploss cancel orders should be handled gracefully
2019-06-24 06:17:44 +02:00
Matthias
4cbcb5f36f
Move .title to ExchangeResolver (it does not make sense to do this over
...
and over again)
2019-06-22 16:52:14 +02:00
Matthias
63640518da
Gracefully handle errosr when cancelling stoploss orders
...
fixes #1933
2019-06-20 20:56:58 +02:00
Matthias
dd379c4192
Cancelling stoploss order should not kill the bot
2019-06-20 20:32:46 +02:00
Matthias
557122921a
Add order_type to sell-notification
2019-06-17 06:56:52 +02:00
hroff-1902
d217f32bbc
minor: fix typo in freqtradebot.py
2019-06-17 04:35:39 +03:00
Matthias
9ea887dbd0
Merge branch 'develop' into stoploss_restart
2019-06-08 20:23:13 +02:00
Matthias
b6e8fecbf5
Change persistence.init parameter
...
It should describe what it does
2019-05-30 06:33:16 +02:00
Matthias
d6cf314481
Don't default to false for init()
2019-05-30 06:30:06 +02:00
Matthias
d7bebc4385
persistence.init does not need the config dict
2019-05-29 19:54:59 +02:00
Matthias
51aa469f67
Cleanups
2019-05-20 20:29:23 +02:00
Matthias
a39cdd3b2b
Exclude Edge from startup-stoploss calc
...
Edge would recalculate / reevaluate stoploss values on startup, so these
values are not reliable
2019-05-20 20:11:50 +02:00
Matthias
6a5daab520
add logic for stoploss reinitialization after startup
2019-05-20 20:11:50 +02:00
Matthias
349c0619aa
Move startup to freqtradebot
2019-05-20 20:11:50 +02:00
Matthias
d16ccd7e37
Merge branch 'develop' into json-defaults
2019-04-24 09:51:04 +02:00
NatanNMB15
706b30f4d2
Fix "if" condition with "if not" for check if trade is open.
2019-04-21 14:54:24 -03:00
NatanNMB15
3bcc60333d
Added command for Wallets Sync after a trade is closed in "update_trade" method in "freqtradebot" class, this will help the Wallets get updated after a trade is sold and closed, specifically LIMIT_SELL trades, then bot can work properly with new trades.
2019-04-21 13:49:07 -03:00
hroff-1902
9fbe573cca
limit usage of ccxt to freqtrade/exchange only
2019-04-09 12:27:35 +03:00
hroff-1902
4559a38172
PoC: use defaults in json schema for some exchange options
2019-04-08 04:42:28 +03:00
Matthias
4a6c8f3cb2
Merge pull request #1735 from hroff-1902/ccxt-parse_timeframe
...
Resolution for #1137
2019-04-07 12:52:13 +02:00
Misagh
41ff2a9276
TemporaryError removed
2019-04-05 20:40:44 +02:00
Misagh
4b2eb22989
conflict with develop resolved
2019-04-05 20:23:15 +02:00
Misagh
54d068de44
missing test added
2019-04-05 20:20:16 +02:00
Misagh
25d8e93a90
remove unnecessary comment
2019-04-05 19:53:15 +02:00
Misagh
9712fb2d57
removing unnecessary comment
2019-04-05 19:49:02 +02:00
hroff-1902
2aa1b43f01
get rid of TICKER_INTERVAL_MINUTES dict, use ccxt's parse_timeframe() instead
2019-04-04 20:56:40 +03:00
Misagh
647534a4f8
flake8
2019-04-04 17:17:21 +02:00
Misagh
31fa857319
typo
2019-04-04 17:15:51 +02:00
Misagh
a363d443bf
stoploss on exchange canceled handled
2019-04-04 17:13:54 +02:00
Misagh
9d6d60dcf0
Merge pull request #1689 from hroff-1902/main_refactoring
...
Main.py and freqtradebot refactoring
2019-04-04 11:19:15 +02:00
Misagh
ef48193fad
Merge pull request #1721 from hroff-1902/fix_1704
...
Fix #1704
2019-04-03 20:32:38 +02:00
Matthias
3c399fbe3f
Improve whitelist wordings
2019-04-03 19:51:46 +02:00
hroff-1902
2959156070
Merge branch 'develop' into main_refactoring
2019-04-03 00:50:33 +03:00
Misagh
54f11ad603
enriching TSL log
2019-04-02 18:57:06 +02:00
Matthias
0cfdce0d5e
Update function name from update_open_order to update_trade_state
2019-04-02 07:12:48 +02:00
hroff-1902
ab0e657d77
Check for empty whitelist moved to _process()
2019-04-01 21:36:53 +03:00
hroff-1902
34b40500c3
Check whitelist fetched from config for emptiness
2019-04-01 20:45:59 +03:00
hroff-1902
8546db9dfd
wording in the log message
2019-04-01 20:23:13 +03:00
hroff-1902
f0b2798c37
fix #1704
2019-04-01 14:08:03 +03:00
hroff-1902
7251e5bd62
bot state moved back to freqtradebot from worker
2019-03-31 23:39:55 +03:00
Matthias
19d3a0cbac
Update comment
2019-03-31 19:41:17 +02:00
Matthias
5c8fbe2c6f
Handle exception for stoploss independently of sell order
2019-03-31 15:41:10 +02:00
Matthias
f11a1b0122
Call update_open_order inline with buy
...
captures FOK / market orders
2019-03-31 15:40:43 +02:00
Matthias
8f4cca47e9
Refactor update_open_order into it's own function
2019-03-31 15:39:41 +02:00
Matthias
4fa736114c
Don't set order_id to none here - it's used in "update_open_order".
...
should fix bugs observed in #1371 connected to stoploss
2019-03-31 15:38:25 +02:00
hroff-1902
5161e1abb3
Allow to pass config into worker, as it's used in the tests
2019-03-26 11:07:02 +03:00
hroff-1902
c8b0c9af0a
Worker moved to new worker.py
2019-03-25 17:45:03 +03:00
hroff-1902
158cb307f6
further refactoring of FreqtradeBot.process()
2019-03-23 00:20:20 +03:00
hroff-1902
60afba5592
move worker stuff to main.py
2019-03-22 20:16:54 +03:00
hroff-1902
aa15312670
wallets cleanup
2019-03-19 20:51:27 +03:00
Matthias
c8617e70a8
Merge pull request #1668 from freqtrade/fix/1658_no_telegram_updates
...
No telegram rate updates when orderbook is enabled
2019-03-18 19:40:32 +01:00
Matthias
a0e6cd93b6
Use bids, not asks for sell-rate detection
2019-03-17 11:27:01 +01:00
Matthias
6666d31ee9
Merge pull request #1648 from hroff-1902/sd-watchdog
...
Support for systemd watchdog
2019-03-16 13:46:04 +01:00
Matthias
6bfc37309e
refactor getting sell/current rate for telegram and selling
...
fix #1658
2019-03-16 13:24:10 +01:00
Matthias
6b8f5963a8
Merge pull request #1623 from iuvbio/markets_refactor
...
Markets refactor
2019-03-14 06:22:18 +01:00
Matthias
2bf5a3843d
Use close_rate for notification if available
2019-03-13 19:41:58 +01:00
Matthias
6b948cfc7e
Don't move notify_sell to rpc_manager - it needs exchange stuff
2019-03-12 22:01:19 +01:00
Matthias
11cc33a982
Refactor notify_sell to rpc_manager
...
* Call sell_notify also when stoploss_on_exchange is hit
fix #1653
2019-03-12 21:55:00 +01:00
iuvbio
0d980134e7
add markets reload func
2019-03-12 16:31:22 +01:00
iuvbio
b24a22b0b6
use self.markets instead of get_markets
2019-03-12 16:31:22 +01:00
hroff-1902
41add9f8ca
code cleanup; added message to systemd for reconfiguration
2019-03-11 15:38:00 +03:00
hroff-1902
8730852d6e
Support for systemd watchdog via sd_notify
2019-03-10 21:04:38 +03:00
iuvbio
786244c0d3
Merge branch 'develop' into feature/volume-precision-pairlist
2019-03-02 18:55:40 +01:00
iuvbio
e1ae0d7e90
remove markets changes
2019-03-02 18:53:42 +01:00
iuvbio
c36fa0c7e2
add ticker argumet to get_target_bid
2019-03-02 17:24:48 +01:00
hroff-1902
4df44d8b32
wallets cleanup
2019-03-01 01:26:29 +03:00
Matthias
6c75b8a36a
Remove pair market url
2019-02-26 19:27:28 +01:00
Misagh
cee4116b80
Merge pull request #1576 from hroff-1902/patch-10
...
Minor: code cleanup in _process()
2019-02-26 10:17:21 +01:00
Matthias
0c53bd6dd4
Complete refactor, moving query_trades to persistance as get_open_trades
2019-02-25 20:00:17 +01:00
Matthias
4315c157c7
Move exception handling to resolver, add test
2019-02-20 20:13:23 +01:00
hroff-1902
7bc874c7fd
comments adjusted
2019-02-20 16:12:17 +03:00
hroff-1902
fac0e4e603
more code cleanup in _process()
2019-02-20 16:01:56 +03:00
hroff-1902
199e3d2234
typo in a comment
2019-02-20 15:13:21 +03:00
hroff-1902
5906d37818
code cleanup in _process()
2019-02-20 15:12:04 +03:00
iuvbio
686949b258
Merge branch 'develop' into kraken_support
2019-02-20 00:52:10 +01:00
iuvbio
481cf02db9
add test and fix exchange_resolver
2019-02-19 19:15:22 +01:00
hroff-1902
f9d68d919c
move default amount_reserve_percent value into constants
2019-02-19 11:49:49 +03:00
iuvbio
eed1c2344d
delete unnecessary arguments
2019-02-18 01:03:09 +01:00
iuvbio
da4faacd6b
flake8
2019-02-17 15:34:44 +01:00
iuvbio
dd2522d8d0
Merge branch 'develop' into kraken_support
2019-02-17 15:21:14 +01:00
iuvbio
fe792882b5
load generic class if no subclass exists
2019-02-17 14:42:55 +01:00
iuvbio
d3ead2cd09
exchange import is not needed anymore
2019-02-17 04:25:39 +01:00
iuvbio
c315f63e4b
use exchange_resolver in freqbot
2019-02-17 04:18:56 +01:00
hroff-1902
ea6d4a9d36
fetch amount_reserve_percent from config
2019-02-16 19:50:55 +03:00
Matthias
e0c420b93f
Merge pull request #1550 from hroff-1902/patch-2
...
execute_buy, handle_trade: do not use ticker if use_order_book:true is set in config
2019-02-16 13:55:33 +01:00
hroff-1902
8fc8c985d8
logs: cosmetic changes
...
"30 seconds" was errorneously hardcoded in the text of the log message, while actually it's RETRY_TIMEOUT which may differ
2019-02-13 12:38:44 +03:00
hroff-1902
69a24c1272
no need for test_ticker parameter just for making current tests happy, tests should be reimplemented
2019-02-13 12:23:22 +03:00
hroff-1902
e8daadfb7e
same approach for the sell side (at handle_trade)
2019-02-13 03:54:57 +03:00
hroff-1902
91629807f7
shame on me
2019-02-13 03:17:54 +03:00
hroff-1902
f551fb5ff7
adjusted for passing tests
...
Don't like this test_ticker parameter, but it's needed for tests to pass prepared ticker.
Any ideas?
2019-02-13 03:14:24 +03:00
hroff-1902
e8ef36fb6e
execute_buy: do not use ticker if use_order_book:true is set in config
...
This PR corresponds to:
https://github.com/freqtrade/freqtrade/issues/1377#issue-386200394
in understanfing that pair Ticker is mostly statistics, but on the other side, create_trade/execute_buy.
It resolves problem with some exchanges (BitMex) where ticker structure returned by ccxt does not contain bid and ask values.
1. On exchanges like Bitmex, set use_order_book: true for buys. FT won't request ticker and will use data from order book only.
2. On exchanges where order book is not available, set use_order_book: false, ticker data (including ask/last balance logic) will be used.
3. On other exchanges, either approach may be used in the config.
Performance: current implementation fetches ticker every time even if order book data will be later used. With this change it's eliminated.
Comparison of order book rate and ticker rate is removed (in order to split fetching order book and ticker completely in execute_buy), so some tests that touch this code may require adjustments.
2019-02-13 02:55:55 +03:00
hroff-1902
5e741a0f73
fixed flake
2019-02-10 22:28:40 +03:00
hroff-1902
08d35f3e15
fix checks
...
Should not make cosmetic changes right in the github editor without local smoketests...
2019-02-10 22:09:11 +03:00
hroff-1902
b91981f0aa
Cosmetic: fix logging
...
Output stake_amount as it is defined in the config (it may by int) instead of float. In order to avoid unnecessary questions where and why it was converted to float and changed in the last digit while it should be integer for the exchange...
Other small cosmetic improvements to logging in freqtradebot.py
2019-02-10 21:31:13 +03:00
Matthias
0a71ebce68
Remove unneeded pair conversation, add docstring
2019-02-04 06:13:22 +01:00
Matthias
02c3552954
Adjust comment
2019-02-03 13:52:05 +01:00
Matthias
e8ed8a2ea7
Handle orders cancelled on exchange
...
fix #1527
2019-02-03 13:51:52 +01:00
Samuel Husso
e3ae8d3f69
flake8 3.7.1 fixes
2019-01-31 07:51:03 +02:00
Matthias
ba07348b82
Rename additional_pairs to informative_pairs
2019-01-26 19:22:45 +01:00
Matthias
d136cac181
Merge branch 'develop' into feat/dataprovider
2019-01-23 21:01:19 +01:00
Matthias
13e2f71d30
Add flake8 plugins and implement small improvements
2019-01-22 20:01:12 +01:00
Matthias
e66808bb02
Add additional pairs to refresh call
2019-01-22 07:07:15 +01:00
Matthias
1e749a0f9b
Rename variable to be clearer
2019-01-22 07:07:15 +01:00
Matthias
0aa0b1d4fe
Store tickers by pair / ticker_interval
2019-01-22 07:07:15 +01:00
Matthias
b981cfcaa0
remove comment which proves untrue now
2019-01-22 07:05:09 +01:00
Matthias
a206777fe5
Rename refresh_tickers to refresh_latest_ohlcv
2019-01-22 07:05:09 +01:00
Matthias
5ecdecd1eb
remove unused local variable persistance
2019-01-22 07:04:19 +01:00
Matthias
58f1abf287
Add dp / wallets to strategy interface
2019-01-22 07:04:19 +01:00
Matthias
4ab7edd3d6
small adaptations
2019-01-22 07:04:19 +01:00
Matthias
7206287b00
Use Dataprovider
2019-01-22 07:04:19 +01:00
Matthias
c2578c7321
Merge pull request #1474 from mishaker/tsl_on_exchange
...
Making trailing stoploss compatible with stoploss on exchange
2019-01-18 19:29:39 +01:00
misagh
70780bb01e
using dict.get to fetch interval
2019-01-18 12:02:29 +01:00
misagh
75cedfafb8
unreachable code removed
2019-01-16 20:03:34 +01:00
misagh
611b48dbb9
fix return value from info hash: value is in string
2019-01-16 16:15:36 +01:00
misagh
baa5cc5b9e
logs enriched
2019-01-16 15:10:31 +01:00
misagh
aa03a864f7
comments added for TSL on exchange function
2019-01-16 15:00:35 +01:00
misagh
6d588b3b0b
trailing stop loss on exchange extracted to a separate function
2019-01-16 14:28:52 +01:00
misagh
bfb7121583
refactoring handle_stoploss_on_exchange
2019-01-16 12:16:32 +01:00
misagh
29439c05d6
adding update beat test
2019-01-16 11:51:54 +01:00
misagh
1cd5abde37
removing unnecessary guard
2019-01-16 11:22:25 +01:00
misagh
12e8108015
checking params of cancel order and stop loss order
2019-01-15 15:36:41 +01:00
misagh
cfe00c2f0c
initial test added for TSL on exchange
2019-01-15 11:04:32 +01:00
misagh
e025ad3918
temp test commit
2019-01-09 16:23:13 +01:00
misagh
1a27258469
condition fixed
2019-01-08 16:34:23 +01:00
misagh
9e133eb32e
adding guard not to cancel the previous stop loss on exchange if market
...
is falling quickly
2019-01-08 16:31:02 +01:00
misagh
aed855284c
comparing with stopPrice instead of price
2019-01-08 13:44:51 +01:00
misagh
821e299afb
adjusting trailing stoploss on exchange
2019-01-06 14:45:29 +01:00
misagh
a5137e4fa4
comparing float instead of int
2018-12-24 11:39:11 +01:00
Misagh
1dbcab0b09
Merge pull request #1413 from freqtrade/feat/data_helpers
...
Feat/data helpers
2018-12-17 09:14:10 +01:00
Matthias
b3bb98777b
Merge branch 'develop' into time_in_force
2018-12-17 06:37:46 +01:00
Matthias
b38195e9b3
Rename to converter
2018-12-14 06:32:49 +01:00
Matthias
453f62cdfa
Adjust imports
2018-12-14 06:32:49 +01:00
Matthias
627ab9f583
pass around dataframe instead of list
2018-12-12 19:17:09 +01:00
misagh
aa1262bea6
typo corrected
2018-12-12 13:33:03 +01:00
misagh
8d8b53f4d1
added tests for IOC and FOK
2018-12-12 13:05:55 +01:00
misagh
6018f2d252
order status handled in case of IOC and FOK
2018-12-10 18:52:24 +01:00
misagh
866b7aee8e
tests fixed
2018-12-09 16:22:21 +01:00
misagh
b35199a772
intermediary commit before extracting the logic
2018-12-09 15:59:05 +01:00
misagh
510f78079b
conflict with develop resolved
2018-12-09 15:16:38 +01:00
Matthias
2c27736dfe
Merge pull request #1390 from freqtrade/feat/dynamic_provider
...
Dynamic Pairlist provider
2018-12-09 08:39:53 +01:00
Matthias
aa579bafa4
Merge pull request #1365 from mishaker/edge_position
...
Fix edge position sizing.
2018-12-06 20:02:31 +01:00
Matthias
3e2fa58029
load pairlists via resolver
2018-12-05 20:44:56 +01:00
misagh
ee26b6bcff
Merge branch 'develop' into time_in_force
2018-12-05 10:57:23 +01:00
misagh
d12cc39a5e
some visual happyness
2018-12-04 20:59:55 +01:00
misagh
910601ba1d
in case exchange doesn’t return order info …
2018-12-04 20:50:35 +01:00
misagh
b7aa77acdd
conflict resolved
2018-12-04 20:28:07 +01:00
Matthias
6ab907bef1
Rename config whitelist to pairlist
2018-12-04 20:24:45 +01:00
Matthias
33e9ed5a5e
Print sellreason in sell-message
2018-12-04 19:58:26 +01:00
misagh
e7684b446b
capital in trade extracted to a separated argument
2018-12-04 17:05:35 +01:00
Matthias
ef1208b366
Fix rpc messages
2018-12-03 20:31:25 +01:00
Matthias
1b3ecb8343
Deprecate --dynamic-whitelist
2018-12-03 20:00:18 +01:00
misagh
108d9a1117
function name refactored
2018-12-03 19:55:37 +01:00
misagh
b5192193fd
total amount passed to edge should consider open trades too
2018-12-03 19:45:00 +01:00
Matthias
3360e777a1
Fix flake adn mypy
2018-12-03 19:29:35 +01:00
Matthias
d09dbfe2e6
Add volumePairList - refactor tests to correct file
2018-12-02 22:07:09 +01:00
Matthias
e8fbe77ebc
Refactor static whitelist to module
2018-12-02 22:07:09 +01:00
misagh
237dc8290f
conflict resolved0
2018-12-01 12:00:03 +01:00
misagh
86d9457ea1
removing unnecessary variable before returning the result
2018-12-01 10:58:05 +01:00
misagh
bf990ec599
test fixed and flake
2018-12-01 10:50:41 +01:00
misagh
f100432fe8
conflict resolved0
2018-12-01 10:43:26 +01:00
Misagh
24f573f3b0
log "Found no sell signal for whitelisted ..." changed ( #1378 )
...
* sell log enriched and put modify on debug
2018-12-01 10:01:11 +01:00
Matthias
e31963f6e1
Merge pull request #1341 from mishaker/stoploss_on_exchange
...
Stoploss on exchange
2018-12-01 09:46:37 +01:00
Matthias
8effcc2de5
Merge pull request #1374 from freqtrade/refactor_startupmessges
...
refactor startup_messages to rpc_manger
2018-11-30 19:15:00 +01:00
misagh
abd88767f8
Merge branch 'develop' into edge_position
2018-11-30 17:50:06 +01:00
misagh
9d005678c3
Merge branch 'develop' into stoploss_on_exchange
2018-11-30 15:13:43 +01:00
misagh
f554647efd
“checking sell” message removed to debug
2018-11-30 14:14:31 +01:00
Matthias
efcec736b5
refactor startup_messages to rpc_manger
...
this cleans up freqtradebot slightly
2018-11-29 20:02:12 +01:00
misagh
6bedcc5d79
log enriched for time in force
2018-11-29 13:22:41 +01:00
misagh
e9305b6592
position size fixed
2018-11-28 15:36:32 +01:00
misagh
da94e97c60
in case trade is not open, then handle_stoploss_on_exchange should not
...
be called
2018-11-28 13:58:53 +01:00
misagh
4ffc74d5fa
if buy order is rejected or expired the bot should exit the buy loop
2018-11-27 19:05:59 +01:00
misagh
159ac6e657
edge tests fixed for position sizing
2018-11-27 14:02:34 +01:00
misagh
f5a70750f0
edge real position sizing drafted
2018-11-26 21:06:32 +01:00
misagh
86354ed258
conflict resolved
2018-11-26 19:08:58 +01:00
misagh
b2634e8e08
typo corrected
2018-11-26 18:28:13 +01:00
misagh
962b02b079
one last step before tests
2018-11-25 22:02:59 +01:00
misagh
890cef88ab
oops, lost in git :/
2018-11-25 21:02:58 +01:00
misagh
59fc67f85b
Merge branch 'develop' of https://github.com/freqtrade/freqtrade into develop
2018-11-25 19:48:51 +01:00
misagh
1ad5ccdfb0
dry run condition when sell occurs
2018-11-25 19:48:46 +01:00
misagh
3e29fbb17a
stoploss on exchange added as a parameter to order_types
2018-11-25 17:22:56 +01:00
Matthias
200484ab8b
Merge pull request #1352 from freqtrade/combine_resolvers
...
Combine resolvers
2018-11-25 13:52:48 +01:00
misagh
dcae3a2644
test of check_consistency added
2018-11-25 11:29:04 +01:00
misagh
266bd7b9b6
error message improved
2018-11-24 21:42:15 +01:00
misagh
519b1f00e2
adding strategy config consistency function
2018-11-24 20:12:50 +01:00
Matthias
21a093bcdb
extract resolvers to IResolvers and it's own package
2018-11-24 20:00:02 +01:00
misagh
fe8927136c
typo
2018-11-24 18:36:07 +01:00
