Commit Graph

2225 Commits

Author SHA1 Message Date
misagh 9c0be99ff7 rounding float at the end 2018-12-01 11:00:33 +01:00
misagh 86d9457ea1 removing unnecessary variable before returning the result 2018-12-01 10:58:05 +01:00
misagh 9c987fdedd variable name changed (_final_pairs) 2018-12-01 10:56:33 +01:00
misagh b1c81acfcb another futile one 2018-12-01 10:53:21 +01:00
misagh 042e631f87 rollback on futile change 2018-12-01 10:52:36 +01:00
misagh bf990ec599 test fixed and flake 2018-12-01 10:50:41 +01:00
misagh f100432fe8 conflict resolved0 2018-12-01 10:43:26 +01:00
Misagh 24f573f3b0 log "Found no sell signal for whitelisted ..." changed (#1378)
* sell log enriched and put modify on debug
2018-12-01 10:01:11 +01:00
Matthias e31963f6e1
Merge pull request #1341 from mishaker/stoploss_on_exchange
Stoploss on exchange
2018-12-01 09:46:37 +01:00
Matthias d4f83a7516 Fix missing mock in test_add_stoploss_on_exchange 2018-11-30 20:15:56 +01:00
Matthias f04655c012 Test exceptions in sell-stoploss 2018-11-30 20:13:50 +01:00
Matthias 3ac2106a16
Merge pull request #1290 from freqtrade/fix/backtest_toomanyopen
fix backtesting not respecting max_open_trades
2018-11-30 19:17:09 +01:00
Matthias 8effcc2de5
Merge pull request #1374 from freqtrade/refactor_startupmessges
refactor startup_messages to rpc_manger
2018-11-30 19:15:00 +01:00
misagh 7e86ec31be tests added for wallet additional functions 2018-11-30 18:23:16 +01:00
misagh aadc9f052a conf schema 2018-11-30 18:10:22 +01:00
misagh 12471e012e added tests for position sizing 2018-11-30 17:59:51 +01:00
misagh abd88767f8 Merge branch 'develop' into edge_position 2018-11-30 17:50:06 +01:00
misagh 7767470af8 return stake amount of strategy if edge doesn’t have any 2018-11-30 17:50:03 +01:00
misagh 9d005678c3 Merge branch 'develop' into stoploss_on_exchange 2018-11-30 15:13:43 +01:00
misagh f554647efd “checking sell” message removed to debug 2018-11-30 14:14:31 +01:00
misagh 8ff82e3dac Merge branch 'develop' into fix_dry_run_stop_price 2018-11-30 10:37:58 +01:00
Matthias efcec736b5 refactor startup_messages to rpc_manger
this cleans up freqtradebot slightly
2018-11-29 20:02:12 +01:00
Matthias 49e44d5481
Merge pull request #1373 from mishaker/fix_edge_stoploss
Should fallback to strategy stoploss if Edge cannot provide.
2018-11-29 19:09:25 +01:00
misagh 74ca34f2de flaking8 2018-11-29 18:45:37 +01:00
misagh 3d37c5d767 edge non existing stoploss fixed. solves #1370 2018-11-29 18:31:08 +01:00
misagh 6bedcc5d79 log enriched for time in force 2018-11-29 13:22:41 +01:00
misagh a61daed8e9 logs enriched 2018-11-29 12:24:04 +01:00
Matthias 38592c6fa6 Add binance config sample, improve invalid pair message 2018-11-29 07:07:47 +01:00
misagh e698590bb2 avoid generating logs on each iteration 2018-11-28 20:04:56 +01:00
misagh 1a5465fb50 logs enriched in case of stop loss on exchange, test fixed 2018-11-28 19:35:10 +01:00
misagh c913fef80c stop loss limit when hit, the close price is “average” 2018-11-28 15:45:11 +01:00
misagh e9305b6592 position size fixed 2018-11-28 15:36:32 +01:00
misagh fb755880fa logs added in case stop loss on exchange is hit 2018-11-28 14:16:50 +01:00
misagh da94e97c60 in case trade is not open, then handle_stoploss_on_exchange should not
be called
2018-11-28 13:58:53 +01:00
misagh 4ffc74d5fa if buy order is rejected or expired the bot should exit the buy loop 2018-11-27 19:05:59 +01:00
misagh 29f680ec5d fix order type test 2018-11-27 17:26:06 +01:00
misagh 7dbf0fed68 stop loss limit order type corrected 2018-11-27 17:09:51 +01:00
misagh 159ac6e657 edge tests fixed for position sizing 2018-11-27 14:02:34 +01:00
misagh f5a70750f0 edge real position sizing drafted 2018-11-26 21:06:32 +01:00
misagh 6351fe7a7f test added: stoploss_order_id should be null after migration 2018-11-26 20:24:13 +01:00
misagh 3131788639 Merge branch 'develop' into time_in_force 2018-11-26 19:20:01 +01:00
misagh 7f6fc7e90f Lost in git ! 2018-11-26 19:13:36 +01:00
misagh 86354ed258 conflict resolved 2018-11-26 19:08:58 +01:00
misagh 2135976cb8 Merge branch 'develop' of https://github.com/freqtrade/freqtrade into develop 2018-11-26 19:01:29 +01:00
misagh b63535083e flake8 2018-11-26 18:47:32 +01:00
misagh 1f1770ad5a migration script and and error handling on stop loss order 2018-11-26 18:46:59 +01:00
misagh b2634e8e08 typo corrected 2018-11-26 18:28:13 +01:00
Samuel Husso 823bc3abb6
Merge pull request #1361 from freqtrade/wallets/add_live_test
Test live mode of get_free
2018-11-26 15:15:42 +02:00
Matthias 854af9c124
Merge pull request #1355 from freqtrade/fix/async_followup
async followup PR
2018-11-26 06:55:10 +01:00
Matthias ad8592f316 Test live mode of get_free 2018-11-26 06:40:20 +01:00
Matthias 797a0e8fd0
Merge pull request #1354 from freqtrade/fix/lambda_test
replace  lambda with Magicmock in test
2018-11-26 06:28:01 +01:00
Pan Long 16eec078d7
Use dot to access attribute in NamedTuple
This should fix the crash in #1359
2018-11-26 09:18:29 +08:00
misagh 962b02b079 one last step before tests 2018-11-25 22:02:59 +01:00
misagh 29c23e3136 added time in force in buy and sell functions 2018-11-25 21:38:11 +01:00
misagh 181424e8ea time in force validator added 2018-11-25 21:09:35 +01:00
misagh ba20b1b5c7 TIF added to constants and json full 2018-11-25 21:05:25 +01:00
misagh 890cef88ab oops, lost in git :/ 2018-11-25 21:02:58 +01:00
misagh fb7b65c909 time in force drafted
time in force drafted
2018-11-25 20:44:40 +01:00
misagh 6c38bde24a some formatting fixed 2018-11-25 20:21:50 +01:00
misagh b579768618 dry run set explicitly to False for live stop loss 2018-11-25 20:20:11 +01:00
misagh 5c257730a8 test added for dry run stop loss sell 2018-11-25 20:16:53 +01:00
misagh 59fc67f85b Merge branch 'develop' of https://github.com/freqtrade/freqtrade into develop 2018-11-25 19:48:51 +01:00
misagh 1ad5ccdfb0 dry run condition when sell occurs 2018-11-25 19:48:46 +01:00
misagh a80c984323 flake8 2018-11-25 19:09:11 +01:00
misagh 92930b2343 test fixed 2018-11-25 19:03:28 +01:00
misagh 5e1fb11124 documentation added for stop loss on exchange 2018-11-25 17:30:06 +01:00
misagh 3e29fbb17a stoploss on exchange added as a parameter to order_types 2018-11-25 17:22:56 +01:00
Matthias ebaf58b0fe Only sort data if necessary 2018-11-25 15:00:50 +01:00
Matthias 8a43611992 Remove get_candle_history (it's now async)
convert sort-test to async
2018-11-25 14:48:15 +01:00
Matthias 745a517795 Fix comment pointing to wrong column 2018-11-25 14:40:21 +01:00
Matthias 317eba2139 Remove dual instanciation of pairinfo named tuple 2018-11-25 14:38:06 +01:00
Matthias fd7184718b replace lambda with Magicmock in test 2018-11-25 14:31:46 +01:00
Matthias 200484ab8b
Merge pull request #1352 from freqtrade/combine_resolvers
Combine resolvers
2018-11-25 13:52:48 +01:00
misagh dcae3a2644 test of check_consistency added 2018-11-25 11:29:04 +01:00
misagh 664b96173e removing NotImplementedError from stoploss_limit 2018-11-25 10:54:36 +01:00
Matthias 1d35428c8d Rename get_valid_objects to get_valid object
it only ever returns one object ...
2018-11-25 10:08:27 +01:00
Matthias a3477e07eb Remove constructor, it's not needed in the baseclass 2018-11-25 09:55:36 +01:00
misagh 266bd7b9b6 error message improved 2018-11-24 21:42:15 +01:00
Matthias 20de8c82e4 Convert to Pathlib 2018-11-24 20:39:16 +01:00
Matthias cc7b820978 Move hyperoptresolver to resolvers package 2018-11-24 20:14:08 +01:00
misagh 519b1f00e2 adding strategy config consistency function 2018-11-24 20:12:50 +01:00
Matthias 2c0d0946e6 Small stylistic improvements to strategyresolver 2018-11-24 20:02:29 +01:00
Matthias 21a093bcdb extract resolvers to IResolvers and it's own package 2018-11-24 20:00:02 +01:00
misagh c8a0956e1b fixed test handle_stoploss_on_exchange 2018-11-24 19:12:00 +01:00
misagh b5192880df [WIP] adding tests for handle_stoploss_on_exchange. 2018-11-24 19:00:59 +01:00
misagh fe8927136c typo 2018-11-24 18:36:07 +01:00
misagh b2c0b20a58 added real tests for stop on exchange in dry-run 2018-11-24 18:26:04 +01:00
misagh 000711b025 added stoploss_limit_order for dry-run 2018-11-24 18:08:11 +01:00
misagh 870631f324 1) comments added to handle_sl 2) dry-run force price removed 2018-11-24 17:32:25 +01:00
misagh 531d9ecd0c docstring added 2018-11-24 17:10:51 +01:00
misagh afd0a054b2 typo corrected 2018-11-24 17:08:12 +01:00
misagh a9ec5c6699 simplifying if conditions 2018-11-24 17:07:35 +01:00
misagh 1a8e9ebc0f stoploss_order_id added to migration script 2018-11-24 16:53:10 +01:00
misagh 63c2ea110a Not sure why those arguments were there ! 2018-11-24 16:41:17 +01:00
misagh 29347a6931 adding get_free to wallet 2018-11-24 16:37:28 +01:00
Matthias 805f509498 Merge branch 'develop' into fix/backtest_toomanyopen 2018-11-24 10:39:16 +01:00
misagh dedf1ff703 refactoring 2018-11-23 20:51:23 +01:00
misagh 89eb3d9f36 blank line removed 2018-11-23 20:49:00 +01:00
misagh 1c2c19b12c the complex in the life of flake8 resolved 2018-11-23 20:47:17 +01:00
misagh 9144a8f79d tests fixed 2018-11-23 20:28:01 +01:00
misagh 5ee2faa182 adding stop loss on exchange after the buy order is fulfilled not
before.
2018-11-23 19:17:36 +01:00
misagh fea77824d0 handle stop loss on exchange added 2018-11-23 15:17:36 +01:00
misagh a9f04609d3 tests fixed 2018-11-23 10:17:10 +01:00
misagh 27a6dcf3fc getting available balance from wallet instead of API call. 2018-11-22 21:23:35 +01:00
misagh 1dde56790c final broken test fixed 2018-11-22 21:12:49 +01:00
misagh 7faafea8a2 added test for cancelling stop loss before sell 2018-11-22 21:01:39 +01:00
misagh 07ac902451 test exchange added 2018-11-22 20:30:31 +01:00
misagh ecb2c4dca3 bloody flake8 2018-11-22 19:38:20 +01:00
misagh cc1422d448 flake8 2018-11-22 19:27:32 +01:00
misagh 3418592908 freqtradebot test added for orders on exchange 2018-11-22 19:25:26 +01:00
misagh 24df093a85 test: only implemented for binance 2018-11-22 17:41:01 +01:00
misagh 2461d86c8d dry run should consider stop loss is hit on limit price 2018-11-22 17:24:45 +01:00
misagh 3a1c378325 typing bugs 2018-11-22 17:14:22 +01:00
misagh bbe8e4e494 flake8 2018-11-22 17:07:37 +01:00
misagh da5617624c cancelling stop loss order before selling 2018-11-22 17:02:02 +01:00
misagh fad7593935 doesn’t have to create another Trade for SL. can be cumulated into the
same.
2018-11-22 16:53:50 +01:00
misagh bb37b56dea adding stop loss order id to Trade 2018-11-22 16:47:52 +01:00
misagh 3b7e05e07b stop loss order added right after a buy order is executued 2018-11-22 16:26:24 +01:00
misagh bfbdddff26 stoploss limit order added to exchange 2018-11-22 16:24:40 +01:00
misagh 238dd6413c Merge branch 'develop' into stoploss_on_exchange 2018-11-22 09:39:01 +01:00
Matthias 1810fc9efa
Merge pull request #1346 from mishaker/fix_python_beginner_mistake
Refactoring a bit ...
2018-11-22 06:02:15 +01:00
Matthias 8e62fc1c03
Merge pull request #1337 from mishaker/wallet
Wallet data structure added. it is initialized on boot then updated right after any trade happens on the exchange.
2018-11-22 06:00:49 +01:00
misagh eb53281434 python beginner problem resolved 2018-11-22 00:04:20 +01:00
misagh 4b86b2b7e3 Happy flake8 ! 2018-11-21 23:36:48 +01:00
misagh 3a2134db24 removed Optional 2018-11-21 23:35:44 +01:00
misagh 4d75e9059c None ripped off for optional as wallet must have exchange and currency 2018-11-21 21:05:20 +01:00
misagh b129750f4d adding “optional” in str 2018-11-21 19:58:28 +01:00
misagh 88f61581d9 1) NamedTuple refactored 2) Missing data handled 2018-11-21 19:47:51 +01:00
misagh cb3cf960d7 tests added in case of missing data 2018-11-21 19:47:28 +01:00
Matthias 64028647a0
Merge pull request #571 from stephendade/userhyper
Separated out custom hyperopts
2018-11-21 19:14:30 +01:00
misagh aeb372c2f0 test wallet when api return changes 2018-11-21 17:54:14 +01:00
misagh 5b68940213 update wallet in casse order remaining is zero 2018-11-21 17:48:53 +01:00
misagh 68f81aa2af test wallets moved to tests folder 2018-11-21 17:27:45 +01:00
misagh c1673aaba3 Merge branch 'develop' into fix_twice_refresh_ticker_call 2018-11-21 14:01:08 +01:00
misagh 64129897f9 refresh_ticker should be called just once per iteration. 2018-11-21 14:00:15 +01:00
Matthias a3b6004115 IHyperopt: all methods static, somef ixes for mypy 2018-11-20 19:41:07 +01:00
Matthias 7757c53b06 Small fixes 2018-11-20 17:43:49 +01:00
Matthias 5dd013c3b1 Rename hyperopt interface and resolver 2018-11-20 17:40:45 +01:00
misagh b50250139e Drafting stoploss on exchange 2018-11-19 20:02:26 +01:00
Matthias d72e605cb7
Merge pull request #1330 from freqtrade/feat/diff_order_types
Add support for different order types
2018-11-19 19:55:30 +01:00
misagh 003480ad90 flake indentation 2018-11-19 13:01:17 +01:00
misagh b680681b34 updating wallet at handle timeout functions too 2018-11-19 11:16:07 +01:00
misagh c033378048 change dict type to Any 2018-11-18 14:57:03 +01:00
misagh 9c549f4513 removing unnecessary private function 2018-11-18 14:39:31 +01:00
misagh 608ce98e1a moving wallets to root 2018-11-18 14:38:31 +01:00
misagh a92619f18c Added empty lines related to last commit removed 2018-11-18 14:34:31 +01:00
misagh 7cb8b28f58 wallet sync added 2018-11-17 23:03:07 +01:00
misagh 606e41d574 wallet tests added 2018-11-17 22:58:27 +01:00
misagh f4bb203782 removing persistence update 2018-11-17 21:59:21 +01:00
misagh d5b47abe98 Wallet table removed 2018-11-17 21:31:06 +01:00
misagh a0658bb504 comments added 2018-11-17 21:27:42 +01:00
misagh 12f07ee126 space removed 2018-11-17 21:26:41 +01:00
misagh b815c8fe2d updating wallets whenever a trade happens 2018-11-17 21:22:54 +01:00
misagh afe52efc8a removing wallet from freq 2018-11-17 21:17:39 +01:00
misagh 82cb0e4d95 putting wallets into a class (doesn’t need to be in persistence) 2018-11-17 21:16:32 +01:00
Matthias b3e08831f7 Remove rate for market orders 2018-11-17 20:14:50 +01:00
Matthias c11984d943 Check if exchange supports all configured market types 2018-11-17 19:54:55 +01:00
Matthias 968184ef0d Swap default mode to all limit (defaults to how it was before) 2018-11-17 19:40:53 +01:00
misagh 69dd56b237 wallet sync drafted 2018-11-17 18:47:13 +01:00
Matthias 492868a966 Seperate different tests within one test clearer 2018-11-17 13:34:23 +01:00
Matthias a9a157af0f Align tests and test if ordertype is passed to ccxt correctly 2018-11-17 13:29:42 +01:00
Matthias ef1e20bfe8 Don't add default value for ordertype
sort parameters to align with ccxt
2018-11-17 13:29:24 +01:00
Matthias 543873263a remove need for escaping quote 2018-11-17 13:13:16 +01:00
Matthias e485aff597 Test failed load on invalid ordertypes 2018-11-17 13:12:11 +01:00
Matthias 9ba281c141 add supported limit values 2018-11-17 13:05:35 +01:00
Matthias 54a86d72f2 Raise error if one of the required ordertypes is not present 2018-11-17 12:59:16 +01:00
Matthias 3ab0cf49af Add order_types to sample strategy 2018-11-17 10:26:15 +01:00
Matthias 24ed9a8b7d Add loading order_types from config file 2018-11-17 10:14:18 +01:00
Matthias de57da3249
Merge pull request #1328 from mishaker/edge_cli
Edge cli
2018-11-15 20:14:03 +01:00
Matthias 98df3c8103 Fix missing mock in backtesting 2018-11-15 20:02:48 +01:00
misagh db8c8ea4a4 added a space in help 2018-11-15 20:02:07 +01:00
Matthias 44c682724d
Merge pull request #1327 from mishaker/max_open_trades
Ignoring max_open_trades if it is -1 in config.
2018-11-15 19:40:05 +01:00
Matthias e6baa9ccf2 Switch tests to kwarguments 2018-11-15 19:31:24 +01:00
misagh 69619030f3 removing unnecessary args from config 2018-11-15 10:50:40 +01:00
misagh 1cfd19aee3 removing unnecessary args for edge 2018-11-15 10:44:33 +01:00
misagh f666d1596b renaming edge to edge_cli for command line version 2018-11-15 10:31:56 +01:00
Matthias 6a71f80a9e Add support for different order types 2018-11-15 06:58:24 +01:00
Matthias 4f800bfbc8 Fix pickling-error 2018-11-14 20:25:43 +01:00
misagh bb9a1e5f9f edge cli tests added 2018-11-14 19:14:34 +01:00
Matthias 23958ba96a
Merge pull request #1322 from freqtrade/feat/add_whitelist_rpc
Feat/add whitelist rpc
2018-11-14 19:13:00 +01:00
misagh ca22a116ad timerange added to args 2018-11-14 17:14:37 +01:00
misagh 5d73b303fe unnecessary libraries removed + arg help enriched 2018-11-14 16:49:16 +01:00
misagh 0767718a17 clear help added to stop losses arg 2018-11-14 16:38:55 +01:00
misagh dd47d7adb4 cli blank line added to readability 2018-11-14 16:37:26 +01:00
misagh b0e4aa8eff stop loss range added to args 2018-11-14 16:31:23 +01:00
misagh 36030176bb nb_trades and avg_trade_duration added to cli 2018-11-14 13:38:23 +01:00
misagh ac0c931492 adding number of trades + average trade duration to edge info 2018-11-14 13:38:04 +01:00
misagh 5de3f1d9dd showing result in tabular 2018-11-14 13:25:44 +01:00
misagh 95cbbf1cb5 adding edge configuration to cli 2018-11-14 12:53:20 +01:00
misagh cf974168e9 Edge cli drafted 2018-11-14 12:37:15 +01:00
misagh 51dfd2bf47 If max_open_trade=-1 means it should be ignored. 2018-11-14 11:37:53 +01:00
Matthias 060a1b3fbc Add /whitelist to help message 2018-11-10 20:16:20 +01:00
Matthias 08ef2730a9 Add /whitelist call to telegram 2018-11-10 20:15:06 +01:00
Matthias 62402351b3 Clarify volume selection for dynamic whitelist 2018-11-10 20:14:46 +01:00
Matthias 02527eeea4 Add rpc_whitelist call 2018-11-10 20:07:09 +01:00
misagh 9bbaeb4e6f mypy expression 2018-11-10 18:39:49 +01:00
misagh aacc1d5004 removing total capital in favour of stake amount 2018-11-10 18:28:05 +01:00
misagh d613553306 base position on stake amount instead of total capital 2018-11-10 18:22:34 +01:00
misagh 7dd74c374a flake happiness provided 2018-11-10 18:09:32 +01:00
misagh 97fd33d752 adding test for process 2018-11-10 18:03:46 +01:00