Adolfo Delorenzo
dfed6ddba8
Some checks failed
ARM64 Build / Build generic ARM64 disk image (push) Failing after 3s
CI / Go Tests (push) Successful in 1m23s
CI / Shellcheck (push) Successful in 46s
CI / Build Go Binaries (amd64, linux, linux-amd64) (push) Successful in 1m32s
CI / Build Go Binaries (arm64, linux, linux-arm64) (push) Successful in 1m15s
Phase 6 of v0.3. The update agent now refuses to apply artifacts whose
channel doesn't match local policy, whose architecture differs from the
running host, or whose min_compatible_version is above the current
version. It also refuses to apply outside a configured maintenance window
unless --force is given.
New package update/pkg/config:
- config.Load parses /etc/kubesolo/update.conf (key=value, # comments,
unknown keys ignored). Missing file is fine — fresh systems before
cloud-init has run.
- ParseWindow handles "HH:MM-HH:MM" plus the wrapping midnight case
(e.g. "23:00-01:00"). Empty input -> AlwaysOpen (no constraint).
Degenerate zero-length windows never match.
- CompareVersions does a simple 3-component semver compare with the 'v'
prefix optional and pre-release suffix ignored.
- 14 unit tests total.
update/pkg/image/image.UpdateMetadata gains three optional fields:
- channel ("stable", "beta", ...)
- min_compatible_version (refuse upgrade if current < this)
- architecture ("amd64", "arm64", ...)
update/cmd/opts.go reads update.conf and merges it into opts; explicit
--server / --channel / --pubkey / --maintenance-window CLI flags override
the file. New --force, --conf, --channel, --maintenance-window flags.
Precedence: CLI > config file > package defaults.
update/cmd/apply.go gains four gates in order:
1. Maintenance window — checked locally before any HTTP work; skipped
with --force.
2. Channel — refused if metadata.channel doesn't match opts.Channel.
3. Architecture — refused if metadata.architecture != runtime.GOARCH.
4. Min compatible version — refused if FromVersion < min_compatible.
All gate failures transition state to Failed with a clear LastError.
cloud-init gains a top-level updates: block (Server, Channel,
MaintenanceWindow, PubKey). cloud-init.ApplyUpdates writes
/etc/kubesolo/update.conf from those fields on first boot. Empty block
leaves any existing file alone (so hand-edited update.conf survives a
reboot without cloud-init re-applying). 4 new tests cover empty / all /
partial / parent-dir-creation cases. full-config.yaml example updated.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
61 lines
1.5 KiB
Go
61 lines
1.5 KiB
Go
package config
|
|
|
|
import (
|
|
"fmt"
|
|
"strconv"
|
|
"strings"
|
|
)
|
|
|
|
// CompareVersions compares two semver-ish version strings.
|
|
//
|
|
// Accepts "v1.2.3", "1.2.3", "v1.2.3-rc1" (suffix ignored), with missing
|
|
// components defaulting to 0 ("v1" == "1.0.0"). Returns -1 if a < b, 0 if
|
|
// equal, +1 if a > b. Returns an error if either argument can't be parsed
|
|
// at all.
|
|
//
|
|
// Used by apply.go to enforce MinCompatibleVersion. Pre-release suffix
|
|
// handling is deliberately simple — we ignore it, treating "v1.2.3-rc1"
|
|
// equal to "v1.2.3". Edge case: production releases should never carry
|
|
// a pre-release suffix, and dev releases are the consumer's responsibility.
|
|
func CompareVersions(a, b string) (int, error) {
|
|
pa, err := parseVersion(a)
|
|
if err != nil {
|
|
return 0, fmt.Errorf("parse %q: %w", a, err)
|
|
}
|
|
pb, err := parseVersion(b)
|
|
if err != nil {
|
|
return 0, fmt.Errorf("parse %q: %w", b, err)
|
|
}
|
|
for i := 0; i < 3; i++ {
|
|
if pa[i] < pb[i] {
|
|
return -1, nil
|
|
}
|
|
if pa[i] > pb[i] {
|
|
return 1, nil
|
|
}
|
|
}
|
|
return 0, nil
|
|
}
|
|
|
|
func parseVersion(s string) ([3]int, error) {
|
|
var out [3]int
|
|
s = strings.TrimSpace(s)
|
|
s = strings.TrimPrefix(s, "v")
|
|
// Drop pre-release suffix: "1.2.3-rc1" -> "1.2.3"
|
|
if i := strings.IndexAny(s, "-+"); i >= 0 {
|
|
s = s[:i]
|
|
}
|
|
parts := strings.SplitN(s, ".", 3)
|
|
for i, p := range parts {
|
|
n, err := strconv.Atoi(p)
|
|
if err != nil {
|
|
return out, fmt.Errorf("component %q not numeric", p)
|
|
}
|
|
if n < 0 {
|
|
return out, fmt.Errorf("component %d negative", n)
|
|
}
|
|
out[i] = n
|
|
}
|
|
return out, nil
|
|
}
|