9.3 KiB
9.3 KiB
phase, plan, type, wave, depends_on, files_modified, autonomous, requirements, gap_closure, must_haves
| phase | plan | type | wave | depends_on | files_modified | autonomous | requirements | gap_closure | must_haves | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 03-operator-experience | 05 | execute | 1 |
|
true |
|
true |
|
Purpose: Phase 3 code is complete but has wiring bugs — routers not mounted (all API calls 404), Slack OAuth field mismatches (OAuth always fails), and budget alert field mismatch (shows $undefined). These are all naming/registration fixes, not missing features.
Output: All Phase 3 API endpoints reachable, Slack OAuth functional, budget alerts display correctly.
<execution_context> @/home/adelorenzo/.claude/get-shit-done/workflows/execute-plan.md @/home/adelorenzo/.claude/get-shit-done/templates/summary.md </execution_context>
@.planning/PROJECT.md @.planning/ROADMAP.md @.planning/STATE.md @.planning/phases/03-operator-experience/03-VERIFICATION.mdfrom shared.api.billing import billing_router, webhook_router
from shared.api.channels import channels_router
from shared.api.llm_keys import llm_keys_router
from shared.api.portal import portal_router
from shared.api.usage import usage_router
Router prefixes (already set on the routers):
- portal_router: /api/portal
- billing_router: /api/portal/billing
- channels_router: /api/portal/channels
- llm_keys_router: /api/portal/tenants/{tenant_id}/llm-keys
- usage_router: /api/portal/usage
- webhook_router: /api/webhooks
class SlackInstallResponse(BaseModel):
url: str # NOT authorize_url
state: str
Backend callback returns: {"ok": True, "workspace_id": ..., "team_name": ..., "tenant_id": ...}
NOT: {"success": true, ...}
class BudgetAlert(BaseModel):
agent_id: str
agent_name: str
budget_limit_usd: float
current_usd: float # NOT current_cost_usd
status: str
After the existing `app.include_router(whatsapp_router)` line (line 89), add:
```python
from shared.api import (
portal_router,
billing_router,
channels_router,
llm_keys_router,
usage_router,
webhook_router,
)
```
And the corresponding include_router calls:
```python
app.include_router(portal_router)
app.include_router(billing_router)
app.include_router(channels_router)
app.include_router(llm_keys_router)
app.include_router(usage_router)
app.include_router(webhook_router)
```
Place the import at the top with other imports. Place the include_router calls in the existing "Register channel routers" section after the whatsapp_router line.
Update the module docstring to reflect that this service now also serves portal API routes.
IMPORTANT: The portal_router from shared.api.portal was created in Phase 1 and is already being served — check if it is already mounted. If not, include it. If it is already mounted elsewhere (e.g., a separate service), skip it to avoid duplicate registration. Based on verification, it is NOT mounted, so include it.
**Fix 1 — Slack OAuth callback (route.ts line 42-44):**
Change the type assertion and field check:
- Line 42: `as { success?: boolean; workspace_name?: string }` --> `as { ok?: boolean; workspace_name?: string }`
- Line 44: `if (!data.success)` --> `if (!data.ok)`
**Fix 2 — SlackInstallResponse (api.ts line 161-163):**
Change the interface to match backend:
```typescript
export interface SlackInstallResponse {
url: string;
state: string;
}
```
Then update ALL references to `authorize_url` in connect-channel.tsx:
- Line 79: `slackInstallData?.authorize_url` --> `slackInstallData?.url`
- Line 81: `slackInstallData.authorize_url` --> `slackInstallData.url`
- Line 135: `!slackInstallData?.authorize_url` --> `!slackInstallData?.url`
- Line 139: `!slackInstallData?.authorize_url` --> `!slackInstallData?.url`
**Fix 3 — BudgetAlert (queries.ts line 228):**
Change the interface field:
- `current_cost_usd: number` --> `current_usd: number`
Then update the usage page reference:
- page.tsx line 268: `alert.current_cost_usd` --> `alert.current_usd`
<success_criteria>
- All 6 Phase 3 API routers are mounted on the gateway FastAPI app
- Zero instances of
authorize_urlin portal frontend code - Zero instances of
current_cost_usdin portal frontend code - Slack callback route checks
data.oknotdata.success - Gateway app imports compile without errors </success_criteria>