Commit Graph

27 Commits

Author SHA1 Message Date
Ben.Destpaer-gotch
2ef123150d
Adding in VSCode alternate branch
Adding in VSCode UI elements instead of Desktop UI elements
2020-07-08 18:25:26 +02:00
Stefan Scherer
3641a64e81
Merge pull request #65 from mattlevan/patch-1
Fix slightly snide comment about SQLite
2020-07-08 18:13:24 +02:00
Stefan Scherer
7cca5d6984
Merge pull request #66 from ffe4/patch-1
Fix typo in tutorial
2020-07-08 18:12:26 +02:00
Stefan Scherer
12a64fad04
Merge pull request #54 from klintzz/patch-1
Dockerfile CMD path fix
2020-07-08 18:11:35 +02:00
Kevin Lin
631465eee2
Removed leading slash
Minor fix
2020-07-08 08:52:39 -07:00
Daniel
3cf57a72b8
Fix typo in tutorial 2020-07-01 10:57:14 +02:00
Matthew Levan
f21aca690b
Fix slightly snide comment about SQLite
The original language implies that SQLite is not an "actual" database engine, which is of course not the case! SQLite is a very capable and ubiquitous database engine. It's not appropriate for many applications, though, so perhaps the document here can simply read "different" rather than "actual". I recognize this is a bit particular, but hey-- that's how I perceived the language on my first read, and I don't even particularly like (or use) SQLite anyways! I do respect the technology, though, and thought it'd be kind to change the language so as to remove all possibility of misinterpretation.
2020-06-30 09:50:26 -07:00
Kevin Lin
67a914066f
CMD update 2020-06-29 09:37:25 -07:00
Kevin Lin
28b0c3ccad
Additional CMD updates for dockerfiles 2020-06-29 09:30:32 -07:00
Stefan Scherer
c9ac9f27df
Merge pull request #50 from erichays/best-practices-fix
Match output to input and clarify build command
2020-06-29 10:54:46 +02:00
Kevin Lin
ab74008076
Dockerfile CMD path fix
CMD runs relative to the WORKDIR.
2020-06-04 13:21:09 -07:00
Eric Hays
1c571de3d5 Match output to input and clarify build command
The Dockerfile listed above specifically uses package.json, but the
output listed for the build lists package*, which is inconsistent. The
React example later in the doc uses package*, which would be consistent
with the output, but this should fix the mismatch for the beginner going
through the tutorial for the first time.

Additionally, the sentence "Build the Docker image now using 'docker
build' again" might be confusing to a beginner. I specifically tested
running this exact command and it gives an error message. Specifically
using the exact command needed to build this target shouldn't take up
too much space.
2020-06-03 02:10:30 +00:00
Dominik Mahnkopf
fc9025459a Add .dockerignore for node_modules & explanation 2020-06-02 22:07:07 +02:00
Eric Hays
55a83f8292 Fix typo in -v description 2020-05-28 09:33:05 +00:00
Bianca Power
fe81ff7e29
add a word for clarity 2020-05-26 19:43:05 +10:00
Stefan Scherer
9bb08eeadd
Explain change for multi-line PowerShell commands
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
2020-05-21 15:03:15 +02:00
Stefan Scherer
89230c73dc
Explain -v
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
2020-05-21 15:02:30 +02:00
Michael Irwin
6652785552
Merge pull request #34 from StefanScherer/add-instructions
Clarify how to create Dockerfile and how to build
2020-05-18 10:54:48 -04:00
Stefan Scherer
ba1cc7351e
Stop container before using volume 2020-05-17 18:06:16 +02:00
Stefan Scherer
9864607e6b
Improve step to show content of the data.txt
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
2020-05-17 17:51:12 +02:00
Stefan Scherer
ed772263e4
Clarify how to create Dockerfile and how to build
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
2020-05-17 17:29:02 +02:00
NotUnlikeTheWaves
38c2276109
Minor text tweaks in docker compose chapter 2020-05-05 22:35:03 +02:00
Rahul Kumaresan
98a838c3c5 correct intent in 'Layer Caching' description 2020-04-19 13:52:03 +05:30
Gerd Jungbluth
ad07012963
Update index.md
Using the official name `Node.js` should make it more accessible for beginners
2020-04-16 19:30:33 +02:00
Michael Irwin
c60bb74386
Add curly brackets around $PWD usage to fix powershell issues
Signed-off-by: Michael Irwin <mikesir87@gmail.com>

Resolves #7
2020-04-15 10:35:22 -04:00
John Robinson
ed5957c253 Typo fix in docker compose tutorial 2020-03-19 19:08:19 -04:00
Michael Irwin
5bb26cc53a
Initial commit
Signed-off-by: mikesir87 <mikesir87@gmail.com>

Imported from dockersamples/101-tutorial, removed other languages
for now, and replaced PWD references with Docker Desktop.
2020-02-05 22:04:43 -05:00