Merge pull request #50 from erichays/best-practices-fix

Match output to input and clarify build command
This commit is contained in:
Stefan Scherer 2020-06-29 10:54:46 +02:00 committed by GitHub
commit c9ac9f27df
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -109,7 +109,7 @@ a change to the `package.json`. Make sense?
Step 2/6 : WORKDIR /app Step 2/6 : WORKDIR /app
---> Using cache ---> Using cache
---> 9577ae713121 ---> 9577ae713121
Step 3/6 : COPY package* yarn.lock ./ Step 3/6 : COPY package.json yarn.lock ./
---> bd5306f49fc8 ---> bd5306f49fc8
Step 4/6 : RUN yarn install --production Step 4/6 : RUN yarn install --production
---> Running in d53a06c9e4c2 ---> Running in d53a06c9e4c2
@ -137,7 +137,7 @@ a change to the `package.json`. Make sense?
1. Now, make a change to the `src/static/index.html` file (like change the `<title>` to say "The Awesome Todo App"). 1. Now, make a change to the `src/static/index.html` file (like change the `<title>` to say "The Awesome Todo App").
1. Build the Docker image now using `docker build` again. This time, your output should look a little different. 1. Build the Docker image now using `docker build -t getting-started .` again. This time, your output should look a little different.
```plaintext hl_lines="5 8 11" ```plaintext hl_lines="5 8 11"
Sending build context to Docker daemon 219.1kB Sending build context to Docker daemon 219.1kB
@ -146,7 +146,7 @@ a change to the `package.json`. Make sense?
Step 2/6 : WORKDIR /app Step 2/6 : WORKDIR /app
---> Using cache ---> Using cache
---> 9577ae713121 ---> 9577ae713121
Step 3/6 : COPY package* yarn.lock ./ Step 3/6 : COPY package.json yarn.lock ./
---> Using cache ---> Using cache
---> bd5306f49fc8 ---> bd5306f49fc8
Step 4/6 : RUN yarn install --production Step 4/6 : RUN yarn install --production