adelorenzo/getting-started
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #54 from klintzz/patch-1

Browse Source 
Dockerfile CMD path fix
This commit is contained in:
Stefan Scherer 2020-07-08 18:11:35 +02:00 committed by GitHub
commit 12a64fad04
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
docs/tutorial/image-building-best-practices/index.md
View File

@ -15,7 +15,7 @@ command, you can see the command that was used to create each layer within an im
```plaintext ```plaintext
IMAGE CREATED CREATED BY SIZE COMMENT IMAGE CREATED CREATED BY SIZE COMMENT
a78a40cbf866 18 seconds ago /bin/sh -c #(nop) CMD ["node" "/app/src/ind… 0B a78a40cbf866 18 seconds ago /bin/sh -c #(nop) CMD ["node" "src/index.j… 0B
f1d1808565d6 19 seconds ago /bin/sh -c yarn install --production 85.4MB f1d1808565d6 19 seconds ago /bin/sh -c yarn install --production 85.4MB
a2c054d14948 36 seconds ago /bin/sh -c #(nop) COPY dir:5dc710ad87c789593… 198kB a2c054d14948 36 seconds ago /bin/sh -c #(nop) COPY dir:5dc710ad87c789593… 198kB
9577ae713121 37 seconds ago /bin/sh -c #(nop) WORKDIR /app 0B 9577ae713121 37 seconds ago /bin/sh -c #(nop) WORKDIR /app 0B
@ -56,7 +56,7 @@ FROM node:12-alpine
WORKDIR /app WORKDIR /app
COPY . . COPY . .
RUN yarn install --production RUN yarn install --production
CMD ["node", "/app/src/index.js"] CMD ["node", "src/index.js"]
``` ```
Going back to the image history output, we see that each command in the Dockerfile becomes a new layer in the image. Going back to the image history output, we see that each command in the Dockerfile becomes a new layer in the image.
@ -76,7 +76,7 @@ a change to the `package.json`. Make sense?
COPY package.json yarn.lock ./ COPY package.json yarn.lock ./
RUN yarn install --production RUN yarn install --production
COPY . . COPY . .
CMD ["node", "/app/src/index.js"] CMD ["node", "src/index.js"]
``` ```
1. Create a file named `.dockerignore` in the same folder as the Dockerfile with the following contents. 1. Create a file named `.dockerignore` in the same folder as the Dockerfile with the following contents.
@ -125,7 +125,7 @@ a change to the `package.json`. Make sense?
---> 4e68fbc2d704 ---> 4e68fbc2d704
Step 5/6 : COPY . . Step 5/6 : COPY . .
---> a239a11f68d8 ---> a239a11f68d8
Step 6/6 : CMD ["node", "/app/src/index.js"] Step 6/6 : CMD ["node", "src/index.js"]
---> Running in 49999f68df8f ---> Running in 49999f68df8f
Removing intermediate container 49999f68df8f Removing intermediate container 49999f68df8f
---> e709c03bc597 ---> e709c03bc597
@ -154,7 +154,7 @@ a change to the `package.json`. Make sense?
---> 4e68fbc2d704 ---> 4e68fbc2d704
Step 5/6 : COPY . . Step 5/6 : COPY . .
---> cccde25a3d9a ---> cccde25a3d9a
Step 6/6 : CMD ["node", "/app/src/index.js"] Step 6/6 : CMD ["node", "src/index.js"]
---> Running in 2be75662c150 ---> Running in 2be75662c150
Removing intermediate container 2be75662c150 Removing intermediate container 2be75662c150
---> 458e5c6f080c ---> 458e5c6f080c

2
docs/tutorial/our-application/index.md
View File

@ -41,7 +41,7 @@ see a few flaws in the Dockerfile below. But, don't worry! We'll go over them.
WORKDIR /app WORKDIR /app
COPY . . COPY . .
RUN yarn install --production RUN yarn install --production
CMD ["node", "/app/src/index.js"] CMD ["node", "src/index.js"]
``` ```
Please check that the file `Dockerfile` has no file extension like `.txt`. Some editors may append this file extension automatically and this would result in an error in the next step. Please check that the file `Dockerfile` has no file extension like `.txt`. Some editors may append this file extension automatically and this would result in an error in the next step.