Commit Graph

2546 Commits

Author SHA1 Message Date
hroff-1902 4df44d8b32 wallets cleanup 2019-03-01 01:26:29 +03:00
Misagh 7e62a4a79c
Merge pull request #1602 from hroff-1902/no-recursion-edge
[Minor] comments: removed mentioning recursion, typos, etc.
2019-02-27 11:50:29 +01:00
hroff-1902 761861f0b7 comments: removed mentioning recursion, typos, etc. 2019-02-27 13:35:06 +03:00
Misagh 4e291795a6
Merge pull request #1601 from hroff-1902/no-recursion-edge
eliminate recursion in Edge
2019-02-27 11:18:23 +01:00
hroff-1902 4c2961f0d9 eliminate recursion in _detect_next_stop_or_sell_point() 2019-02-27 06:31:27 +03:00
Matthias ef26484153 Super() should not be called with parameters
source: https://realpython.com/python-super/
2019-02-26 21:01:50 +01:00
Matthias 79aac473b3 Remove market_url from tests 2019-02-26 19:27:28 +01:00
Matthias 6c75b8a36a Remove pair market url 2019-02-26 19:27:28 +01:00
Matthias ee0e381d65
Merge pull request #1595 from freqtrade/binance_subclass
Create binance Subclass and parametrize exchange-tests
2019-02-26 19:26:23 +01:00
Misagh cee4116b80
Merge pull request #1576 from hroff-1902/patch-10
Minor: code cleanup in _process()
2019-02-26 10:17:21 +01:00
Matthias 0c53bd6dd4 Complete refactor, moving query_trades to persistance as get_open_trades 2019-02-25 20:00:17 +01:00
Matthias 006635003e Fix small typos 2019-02-24 20:18:41 +01:00
Matthias f2fd5205ef Fix typo 2019-02-24 20:13:38 +01:00
Matthias 31be4d2454 Add parametrized tests 2019-02-24 20:08:27 +01:00
Matthias 5c18346cd5 Add typehint to binance dict 2019-02-24 20:01:20 +01:00
Matthias e0b634ba3b Parametrize exchanges and test multiple exchanges 2019-02-24 19:59:45 +01:00
Matthias a05155cb75 Adapt failing test 2019-02-24 19:41:47 +01:00
Matthias 455b168366 add _ft_has to exchangeclass 2019-02-24 19:35:29 +01:00
Matthias 06f486a8eb Add binance exchange subclass 2019-02-24 19:30:05 +01:00
Matthias 2531961bf8
Merge pull request #1571 from hroff-1902/patch-9
multiple --config options
2019-02-24 13:50:39 +01:00
Matthias 9b288c6933 Add test to specifically test for merged dict 2019-02-24 13:29:22 +01:00
iuvbio 403ed48c3e rename _store_dry_order 2019-02-23 16:28:13 +01:00
iuvbio ec6794b9ba fix dry_orders 2019-02-23 16:03:15 +01:00
iuvbio 98bca30dfb reorganize imports 2019-02-22 21:16:31 +01:00
iuvbio cc0fae8e4e change < to <= 2019-02-22 21:13:08 +01:00
iuvbio 8d8da71f20 Merge branch 'develop' into feature/volume-precision-pairlist 2019-02-22 20:31:24 +01:00
iuvbio 9a097214a6 return complete dry_order in buy and sell 2019-02-22 19:22:48 +01:00
iuvbio 71774bce6f Merge branch 'develop' of https://github.com/freqtrade/freqtrade into order_creation 2019-02-22 19:02:31 +01:00
iuvbio b79d967371 add tests, further consolidate orders 2019-02-22 01:48:35 +01:00
iuvbio 69bb6ebaf6 fix comments 2019-02-21 22:43:15 +01:00
iuvbio bf5d2a68f5 Merge branch 'develop' into order_creation 2019-02-21 19:03:29 +01:00
Matthias be754244a3 Only resolve exchanges from correct location 2019-02-21 07:07:45 +01:00
Matthias e0f426d863 Allow import freqtrade.exchange.* 2019-02-21 06:59:52 +01:00
Matthias e987a915e8 Rename exchange file 2019-02-21 06:56:22 +01:00
Matthias 2dcb4134cc Merge branch 'develop' into pr/iuvbio/1563 2019-02-21 06:29:37 +01:00
Matthias e309f75118
Merge pull request #1581 from hroff-1902/patch-11
Minor changes to exchange
2019-02-21 06:25:47 +01:00
iuvbio b5758e67f9 order creation cleanup 2019-02-21 00:29:59 +01:00
hroff-1902 2851833726 added _now_is_time_to_refresh() 2019-02-21 01:20:24 +03:00
hroff-1902 c1ef6940b0 removed wrong comment: tuple is not created here 2019-02-21 00:47:18 +03:00
hroff-1902 2aba9c081c fixed typos in comments 2019-02-21 00:46:35 +03:00
hroff-1902 eb21170691
added amount_reserve_percent into config json-schema 2019-02-21 00:26:02 +03:00
Matthias 4315c157c7 Move exception handling to resolver, add test 2019-02-20 20:13:23 +01:00
hroff-1902 4fbba98168 tests adjusted for multiple --config options 2019-02-20 17:54:20 +03:00
hroff-1902 87c82dea3d support for multiple --config in the download_backtest_data.py utility 2019-02-20 17:00:35 +03:00
hroff-1902 c08a2b6638 help message fixed 2019-02-20 16:23:09 +03:00
hroff-1902 7bc874c7fd comments adjusted 2019-02-20 16:12:17 +03:00
hroff-1902 fac0e4e603 more code cleanup in _process() 2019-02-20 16:01:56 +03:00
hroff-1902 199e3d2234 typo in a comment 2019-02-20 15:13:21 +03:00
hroff-1902 5906d37818 code cleanup in _process() 2019-02-20 15:12:04 +03:00
iuvbio e495ffec78 align dry_run_orders 2019-02-20 02:38:16 +01:00
iuvbio 84ccb85184 Merge branch 'develop' into feature/volume-precision-pairlist 2019-02-20 01:03:03 +01:00
iuvbio 686949b258 Merge branch 'develop' into kraken_support 2019-02-20 00:52:10 +01:00
iuvbio 3e2f90a32a formatting 2019-02-19 22:27:20 +01:00
iuvbio bb31e64752 add test_sell_kraken_trading_agreement 2019-02-19 21:56:20 +01:00
iuvbio 481cf02db9 add test and fix exchange_resolver 2019-02-19 19:15:22 +01:00
hroff-1902 2f225e2340 multiple --config options 2019-02-19 15:14:47 +03:00
hroff-1902 f9d68d919c move default amount_reserve_percent value into constants 2019-02-19 11:49:49 +03:00
iuvbio eed1c2344d delete unnecessary arguments 2019-02-18 01:03:09 +01:00
iuvbio 4241caef95 changes to base and subclass 2019-02-17 23:34:15 +01:00
iuvbio 62382809b2 Merge branch 'develop' into feature/volume-precision-pairlist 2019-02-17 16:14:20 +01:00
iuvbio 0572336ff7 revert changes to history 2019-02-17 16:12:40 +01:00
iuvbio d8feceebb5 fix type-hints 2019-02-17 15:54:22 +01:00
iuvbio da4faacd6b flake8 2019-02-17 15:34:44 +01:00
iuvbio 39c28626aa remove error message to make pytest pass 2019-02-17 15:29:58 +01:00
iuvbio 5e8a7a03c3 correct time_in_force param 2019-02-17 15:26:33 +01:00
iuvbio dd2522d8d0 Merge branch 'develop' into kraken_support 2019-02-17 15:21:14 +01:00
iuvbio fe792882b5 load generic class if no subclass exists 2019-02-17 14:42:55 +01:00
iuvbio d3ead2cd09 exchange import is not needed anymore 2019-02-17 04:25:39 +01:00
iuvbio c879591f45 add exchange_resolver to resolver init 2019-02-17 04:22:24 +01:00
iuvbio c315f63e4b use exchange_resolver in freqbot 2019-02-17 04:18:56 +01:00
iuvbio 2fb36b116d change variable names 2019-02-17 04:15:11 +01:00
iuvbio ca388a9acf create exchange_resolver 2019-02-17 04:01:43 +01:00
iuvbio 32b02c9925 kraken subclass 2019-02-17 04:01:17 +01:00
iuvbio 54d5bce445 undo kraken specific changes 2019-02-17 03:59:40 +01:00
iuvbio b7afcf3416 add VolumePrecisionPairList 2019-02-16 22:56:04 +01:00
hroff-1902 ea6d4a9d36
fetch amount_reserve_percent from config 2019-02-16 19:50:55 +03:00
Matthias e0c420b93f
Merge pull request #1550 from hroff-1902/patch-2
execute_buy, handle_trade: do not use ticker if use_order_book:true is set in config
2019-02-16 13:55:33 +01:00
iuvbio 8ed3658447 Merge branch 'develop' into kraken_support 2019-02-15 23:27:41 +01:00
Crypto God 3aa614b983 bump version 2019-02-15 22:51:09 +01:00
Crypto God 3953092edd output error message 2019-02-15 22:50:31 +01:00
Crypto God ef5a0b9afc add Kraken specifics 2019-02-15 22:50:11 +01:00
Matthias 98bd713624 iUpdate orderbook_bid_test 2019-02-14 19:15:16 +01:00
Matthias f852be1a9b Fix tests for get_ticker fix 2019-02-14 07:27:13 +01:00
hroff-1902 b87e15774b
test adjusted 2019-02-13 13:02:57 +03:00
hroff-1902 8e7e670003
Orthography in the log message 2019-02-13 12:42:39 +03:00
hroff-1902 8fc8c985d8
logs: cosmetic changes
"30 seconds" was errorneously hardcoded in the text of the log message, while actually it's RETRY_TIMEOUT which may differ
2019-02-13 12:38:44 +03:00
hroff-1902 69a24c1272
no need for test_ticker parameter just for making current tests happy, tests should be reimplemented 2019-02-13 12:23:22 +03:00
hroff-1902 e8daadfb7e
same approach for the sell side (at handle_trade) 2019-02-13 03:54:57 +03:00
hroff-1902 91629807f7
shame on me 2019-02-13 03:17:54 +03:00
hroff-1902 f551fb5ff7
adjusted for passing tests
Don't like this test_ticker parameter, but it's needed for tests to pass prepared ticker.
Any ideas?
2019-02-13 03:14:24 +03:00
hroff-1902 e8ef36fb6e
execute_buy: do not use ticker if use_order_book:true is set in config
This PR corresponds to:
https://github.com/freqtrade/freqtrade/issues/1377#issue-386200394
in understanfing that pair Ticker is mostly statistics, but on the other side, create_trade/execute_buy.

It resolves problem with some exchanges (BitMex) where ticker structure returned by ccxt does not contain bid and ask values.

1. On exchanges like Bitmex, set use_order_book: true for buys. FT won't request ticker and will use data from order book only.
2. On exchanges where order book is not available, set use_order_book: false, ticker data (including ask/last balance logic) will be used.
3. On other exchanges, either approach may be used in the config.

Performance: current implementation fetches ticker every time even if order book data will be later used. With this change it's eliminated.

Comparison of order book rate and ticker rate is removed (in order to split fetching order book and ticker completely in execute_buy), so some tests that touch this code may require adjustments.
2019-02-13 02:55:55 +03:00
Matthias d91dbf4090
Merge pull request #1545 from hroff-1902/patch-3
Cosmetic: fix logging
2019-02-11 06:12:17 +01:00
hroff-1902 69f69d965c
test asserts aligned accordingly to new log messages 2019-02-10 23:37:24 +03:00
hroff-1902 5e741a0f73
fixed flake 2019-02-10 22:28:40 +03:00
hroff-1902 d6c0c107ac
fixed flake
hmm, even in the comments?
2019-02-10 22:23:00 +03:00
hroff-1902 7ed15c64ba
what else? 2019-02-10 22:13:40 +03:00
hroff-1902 08d35f3e15
fix checks
Should not make cosmetic changes right in the github editor without local smoketests...
2019-02-10 22:09:11 +03:00
hroff-1902 4dffb17dd6
fix flake 2019-02-10 22:01:46 +03:00
hroff-1902 14d6cdf9b2
OHLCV should be float for TA-LIB indicators in the strategy
Some exchanges (BitMEX) return integer values for Volume field. And sometimes even for OHLC -- same, on BitMEX, since price decrease is 0.5. TA-LIB functions assume floats and fail with exception.
Of course, this can be fixed (converted) in ccxt for particular exchange, but TA-LIB will still fail for exchanges for that such a conversion is not implemented in ccxt code. So let's make perform this conversion here in order to be sure our strategy will not crash on a new exchange.
2019-02-10 21:52:33 +03:00
hroff-1902 b91981f0aa
Cosmetic: fix logging
Output stake_amount as it is defined in the config (it may by int) instead of float. In order to avoid unnecessary questions where and why it was converted to float and changed in the last digit while it should be integer for the exchange...

Other small cosmetic improvements to logging in freqtradebot.py
2019-02-10 21:31:13 +03:00
hroff-1902 585f525879
Cosmetic: fix logging 2019-02-10 21:02:53 +03:00
Matthias 0a71ebce68 Remove unneeded pair conversation, add docstring 2019-02-04 06:13:22 +01:00
Matthias 1d940041e3 Add log test for cancelled order 2019-02-03 13:52:05 +01:00
Matthias 40fea4593f Add log_has_re 2019-02-03 13:52:05 +01:00
Matthias 02c3552954 Adjust comment 2019-02-03 13:52:05 +01:00
Matthias 91ed02134e Add tests for cancelled on exchnage 2019-02-03 13:52:05 +01:00
Matthias e8ed8a2ea7 Handle orders cancelled on exchange
fix #1527
2019-02-03 13:51:52 +01:00
Samuel Husso e3ae8d3f69 flake8 3.7.1 fixes 2019-01-31 07:51:03 +02:00
Matthias 2b71e8de5c
Merge pull request #1525 from mishaker/edge_messages
Edge messages enriched
2019-01-30 11:41:32 +01:00
misagh 84b6b8fe97 edge messages enriched 2019-01-30 11:23:23 +01:00
Misagh 421be5da86
Merge pull request #1511 from freqtrade/fix/more_settings_strategy
add more settings to strategy
2019-01-30 11:22:10 +01:00
Misagh 22e82f5e47
Merge pull request #1507 from xmatthias/feat/dataprovider
Data Provider
2019-01-27 12:32:18 +01:00
Matthias 38f73dafb3 Fix indexing error 2019-01-27 10:47:24 +01:00
Matthias e0ad095bc7 Simplify conversation to python dates (pandas offers this "for free" 2019-01-27 10:47:02 +01:00
Matthias 1d08ada939 Fix backtest-test with timestamp-conversion 2019-01-27 10:40:52 +01:00
Matthias 3446dd1792 Add test informative_pairs_added 2019-01-26 20:05:49 +01:00
Matthias 02d13645b0 Merge branch 'develop' into feat/dataprovider 2019-01-26 19:29:41 +01:00
Matthias ba07348b82 Rename additional_pairs to informative_pairs 2019-01-26 19:22:45 +01:00
Matthias bfd8609352 Fix comment 2019-01-26 19:16:33 +01:00
Matthias da5210ef5b
Merge branch 'develop' into feature/plot_df_refactoring_multiple_pairs 2019-01-26 11:04:35 +01:00
AxelCh eec7276393 fix crash when backtest-result.json not exist 2019-01-26 11:00:04 +01:00
Matthias 3c316fe3e4 Fix alignment 2019-01-25 19:14:38 +01:00
Matthias 3afe54790e
Merge pull request #1510 from gianlup/add_totprofit_to_bt
Added total profit column to backtest result
2019-01-25 06:38:39 +01:00
Matthias 74b03d0529 Add tests and default values for all experimental features 2019-01-24 07:03:41 +01:00
Matthias d136cac181 Merge branch 'develop' into feat/dataprovider 2019-01-23 21:01:19 +01:00
Matthias 97f6a45819 Allow more settings to come from strategy 2019-01-23 20:59:41 +01:00
Matthias 5ea332e9be fix bug with trailing_stop_offset if it's disabled 2019-01-23 20:57:31 +01:00
Gianluca Puglia 896c9d34fd Added total profit column do backtest result 2019-01-22 22:41:53 +01:00
Matthias 13e2f71d30 Add flake8 plugins and implement small improvements 2019-01-22 20:01:12 +01:00
Matthias 86a0863e30 Clarify logmessage Done fetching 2019-01-22 19:26:07 +01:00
Matthias a06593e6e9 Fix test 2019-01-22 19:17:21 +01:00
Matthias 89ddfe08f4 Add additional-pairs (sample) to defaultstrategy 2019-01-22 19:17:08 +01:00
Matthias c77607b997 Fix tests after rebase 2019-01-22 07:38:15 +01:00
Matthias 3221f883d3 Wrap line correctly 2019-01-22 07:07:15 +01:00
Matthias 1e7431a7b8 Blackify 2019-01-22 07:07:15 +01:00
Matthias e66808bb02 Add additional pairs to refresh call 2019-01-22 07:07:15 +01:00
Matthias 6e2de75bcb Add additional_pairs to strategy 2019-01-22 07:07:15 +01:00
Matthias d6cdfc58af Fix mypy hickup after changing list to tuples 2019-01-22 07:07:15 +01:00
Matthias 27b2021726 Only run once per pair 2019-01-22 07:07:15 +01:00
Matthias e7800aa88a Import only what's necessary 2019-01-22 07:07:15 +01:00
Matthias a2bc1da669 Remove private var from class instance
it's overwritten in __init__ anyway
2019-01-22 07:07:15 +01:00
Matthias 1e749a0f9b Rename variable to be clearer 2019-01-22 07:07:15 +01:00
Matthias d7df5d5715 Keep last_pair_refresh as tuple asw ell 2019-01-22 07:07:15 +01:00
Matthias 6525a838d1 Adjust documentation to tuple use 2019-01-22 07:07:15 +01:00
Matthias f0af4601f9 Adopt plot_dataframe to work with --live 2019-01-22 07:07:15 +01:00
Matthias a9abc25785 Improve data-provider tests 2019-01-22 07:07:15 +01:00
Matthias 0aa0b1d4fe Store tickers by pair / ticker_interval 2019-01-22 07:07:15 +01:00
Matthias 5f61da30ed Adjust tests to 3tuple return value from async method 2019-01-22 07:06:30 +01:00
Matthias d6df3e55c0 Return ticker_interval from async routine
used to identify calls in refresh_latest_ohlcv
2019-01-22 07:06:30 +01:00
Matthias e503d811bd Change logmessages to match functions called 2019-01-22 07:05:09 +01:00