xmatthias
88755fcded
fix typing
2018-05-30 22:09:20 +02:00
xmatthias
0d6dffdc7e
fix typehinting
2018-05-30 22:09:03 +02:00
xmatthias
9aa468adda
fix for typehint
2018-05-30 22:01:29 +02:00
Samuel Husso
c471ccb2db
Merge pull request #734 from arudov/fix/pair-downloads
...
Do not download pairs if --refresh-pairs-cached isn't set
2018-05-29 08:05:10 +03:00
Pan Long
a98fcee4f9
Sell filled amount or an open limit buy order in forcesell.
...
Currently forcesell only cancels an open limit buy order and doesn't sell the filled amount.
After this change, forcesell will also update trade's amount to filled amount and sell the filled amount.
2018-05-26 09:55:31 +08:00
xmatthias
1ba5c5d9c6
set ccxt loglevel to info
2018-05-25 21:23:15 +02:00
Anton
8c22cfce37
Fix tests; fix codestyle
2018-05-21 23:15:01 +03:00
Anton
e1cb0dbf28
Do not try to redownload pair data if --refresh-pairs-cached is not set
2018-05-21 22:31:08 +03:00
xmatthias
e2efd7c6ec
add test to verify network exception is cought on init of coinmarketcap
2018-05-21 20:03:25 +02:00
xmatthias
56e697acf5
Fix error initializing coinmarketcap
2018-05-21 20:01:41 +02:00
peterkorodi
0c051b1b7a
Make plot_dataframe able to show trades stored in database. ( #692 )
...
* Show trades stored in db on the graph
2018-05-19 09:14:42 +03:00
Matthias Voppichler
ef78f2f03a
Add test for invalid order_fee dict
2018-05-15 20:13:43 +02:00
Matthias Voppichler
a1fa688da0
Add tests for the new scenario
2018-05-15 19:49:47 +02:00
Matthias Voppichler
263bf918b1
Fix bug pointed out in #679
2018-05-15 19:49:28 +02:00
Anton
d112d90e8e
Make telegram message beautiful
2018-05-15 13:37:34 +03:00
Anton
f175f48418
Fix get balance functionality
2018-05-15 00:31:56 +03:00
Matthias Voppichler
8549201502
add test for new fiat_convert logic
2018-05-13 20:46:02 +02:00
Matthias Voppichler
b1c53ec656
refactor "patch_coinmarketcap" to conftest"
...
add patch_coinmarketcap to get_patched_freqtradebot
2018-05-13 20:04:40 +02:00
Matthias Voppichler
790f35a5c8
fix test which resets singleton without reinstating it
2018-05-13 20:03:54 +02:00
Matthias Voppichler
3246c60472
Fix coinmarketcap ticker
2018-05-13 20:00:38 +02:00
Matthias Voppichler
57fc9df5f3
Fix typo
2018-05-13 19:54:19 +02:00
Matthias Voppichler
144be37a9a
Convert ID to string
2018-05-13 19:53:23 +02:00
Matthias Voppichler
9b8f90dc9f
log error in find_price
2018-05-13 19:50:04 +02:00
Matthias Voppichler
d07491ceb2
Dynamically load cryptomap
2018-05-13 19:46:08 +02:00
Matthias Voppichler
8f17b11610
Fix testfluke in hyperopt
2018-05-13 13:38:29 +02:00
Matthias Voppichler
8b098859f4
Reduce verbosity of get_ticker_history
2018-05-12 20:15:59 +02:00
Michael Egger
5b25ed99ac
Merge pull request #652 from gcarq/feat/objectify-ccxt
...
CCXT into use
2018-05-12 14:04:06 +02:00
Michael Egger
edd840ac35
Merge pull request #640 from xmatthias/ccxt-obj-slippage
...
[cxxt][2/2] Add columns for slippage detection
2018-05-12 13:56:15 +02:00
Matthias Voppichler
58425993da
Adapt tests to verify pair-conversion and exchange conversion
2018-05-12 13:39:29 +02:00
Matthias Voppichler
e3ae1c6c2f
Convert exchange-name to new format
2018-05-12 13:39:16 +02:00
Matthias Voppichler
40c581e5a8
Convert pair-format to new format
2018-05-12 13:37:42 +02:00
Matthias Voppichler
631081a2b2
Add additional tests
2018-05-12 10:37:17 +02:00
Matthias Voppichler
8e3ff8235f
add explaining comments
2018-05-12 10:31:24 +02:00
Matthias Voppichler
ada98abfee
fix flake
2018-05-12 10:30:30 +02:00
Matthias Voppichler
49266fc4b8
Add migration test
2018-05-12 10:29:26 +02:00
Matthias Voppichler
f5ff6ceead
Rename instead of drop/create
2018-05-12 10:29:10 +02:00
Matthias Voppichler
ab4e2bd5a9
Fix migrate script
2018-05-12 10:04:41 +02:00
Samuel Husso
01b6a0eb53
Freqtrade: ccxt release shall be called 0.17.0
2018-05-12 09:57:10 +03:00
Michael Egger
1dbdb880e6
Merge pull request #637 from arudov/fix/dl-testdata-period2
...
Time-range download of backtesting data
2018-05-07 17:19:54 +02:00
Matthias Voppichler
ccf1c894b4
Inital try mirate
2018-05-06 09:09:53 +02:00
Matthias Voppichler
d3fb2e4516
Add open_rate_requested and close_rate_requested for slippage detection
2018-05-05 12:57:07 +02:00
Anton
932b65da27
Fix test_optimize.py
2018-05-04 13:59:50 +03:00
Anton
2bfce64e6a
Fix conflicts
2018-05-04 13:38:51 +03:00
Gert Wohlgemuth
6d2afdb146
added support for showing the exposed real value on the count table ( #634 )
2018-05-03 11:18:35 +02:00
gcarq
43fd9b37df
fix 'max_open_trades must be greater than 0' regression
2018-05-03 10:48:25 +02:00
Anton
ceeb98dda9
Fix conflicts
2018-05-03 11:16:29 +03:00
gcarq
306885e174
Merge branch 'develop' into feat/objectify-ccxt
2018-05-02 22:49:55 +02:00
Michael Egger
90a107393a
Merge pull request #622 from gcarq/fix/dl-testdata
...
fix download testdata
2018-05-02 22:06:43 +02:00
gcarq
a76ed88496
Merge branch 'feat/objectify-ccxt' into feature/catch-exchange-errors
2018-05-02 20:03:13 +02:00
Anton
24ab1b5be5
Fix review comments, documenation update
2018-05-01 00:27:05 +03:00
Samuel Husso
842b0c2270
Exchange: fix missing comma and typehinting per PR comments
2018-04-29 18:55:43 +03:00
Anton
a127e1db07
Fix case with empty dict
2018-04-28 01:40:48 +03:00
Anton
2267a420a4
Fix codestyle
2018-04-28 00:30:42 +03:00
Anton
82ea56c8fd
Fix review comments. Add support of datetime timeganges
2018-04-28 00:16:34 +03:00
Michael Egger
ecaf6b763c
Merge pull request #623 from xmatthias/cxxt_obj_sellfix
...
[cxxt][1/2] fix fee calculation in binance
2018-04-26 19:58:24 +02:00
Matthias Voppichler
0987af910e
remove indicator name from comment
2018-04-25 20:03:32 +02:00
Matthias Voppichler
2e1124af1a
remove unnecessary .keys()
2018-04-25 14:00:25 +02:00
Anton
2fe7812e20
Fix codestyle
2018-04-25 10:32:58 +03:00
Matthias Voppichler
8bd9ed1543
fix flake8
2018-04-25 09:13:56 +02:00
Matthias Voppichler
72c17e29c0
Add test for "no trades found" case
2018-04-25 09:08:02 +02:00
Matthias Voppichler
483415cd65
Add fee entry to DRY_ORDER dict as defined by ccxt
2018-04-25 09:03:32 +02:00
Matthias Voppichler
98669a3d62
remove duplicate log entry, fix key-error
2018-04-25 09:01:21 +02:00
Matthias Voppichler
9c2115c917
refactor get_real_amount
2018-04-25 08:52:08 +02:00
Matthias Voppichler
f6ecd8e514
Add pytest fixture for real_amount test
2018-04-25 08:51:31 +02:00
Anton
6675120324
Add time range support to download_backtest_data
2018-04-25 02:11:07 +03:00
Matthias Voppichler
ab6589d573
Fix comment and improve log message
2018-04-24 19:43:08 +02:00
Matthias Voppichler
9e94778fd7
simplify check for presence of list
2018-04-24 19:42:41 +02:00
Matthias Voppichler
2968347062
fix flake8
2018-04-23 20:32:46 +02:00
Matthias Voppichler
9450b76414
improve style of import in test
2018-04-23 20:08:58 +02:00
Matthias Voppichler
d2608cbf13
improve check when not to run
2018-04-23 20:06:00 +02:00
Matthias Voppichler
f580fbb91d
remove maybe_update_amount and tests
2018-04-23 20:03:10 +02:00
gcarq
9b0fbbdc14
cancel_order: pass all positional arguments
2018-04-23 16:58:52 +02:00
gcarq
aa213a3640
cancel_order: handle InvalidOrder exception
2018-04-23 16:58:32 +02:00
gcarq
baeeaa777d
get_balance: handle case if currency is not in response
2018-04-23 16:57:18 +02:00
gcarq
20af4bae7c
retrier: raise initial exception instead of OperationalException
2018-04-23 16:56:35 +02:00
gcarq
5baab91bb5
catch TemporaryError for buy/sell in _process()
2018-04-22 20:28:39 +02:00
gcarq
4c49229b77
catch DependencyExceptions while selling
2018-04-22 20:27:34 +02:00
Matthias Voppichler
93a7c46977
optimize to only do network calls if necessary
2018-04-22 19:37:24 +02:00
gcarq
bc2bd7fe1e
add retrier decorator to all exchange functions except buy/sell
2018-04-22 17:28:49 +02:00
Matthias Voppichler
a70958da41
test modify-logic
2018-04-22 11:05:23 +02:00
Samuel Husso
9f1544978d
tests: use only coins that most likely are going to be in bittrex
2018-04-22 11:29:21 +03:00
Matthias Voppichler
f838ba2a9b
remove fee column from bot
2018-04-22 10:04:30 +02:00
Samuel Husso
de8db9293c
exchange: extract ccxt init to its own function (so that we can init ccxt from the scripts)
2018-04-22 10:57:48 +03:00
Samuel Husso
fded8e5117
move download_backtest_data to scripts
2018-04-22 10:56:49 +03:00
Matthias Voppichler
be95d699d2
only update if open_fee is set
2018-04-22 09:13:02 +02:00
gcarq
9ab4953472
fix backtesting testsuite
2018-04-22 00:21:03 +02:00
gcarq
bbe3bc4423
catch ccxt.ExchangeError and retry
2018-04-22 00:20:15 +02:00
Matthias
acb1b50924
[ccxt] fix unsupported fiat failures ( #620 )
...
* prepare to support FIAT/Crypto trading
* Don't fail fiat-convert for unsupported stake currencies
* remove commented code
* Add BNB to cryptomap
* Fix test-failure
* related to random execution as fee was not properly mocked if this is
one of the first tests
2018-04-21 23:20:12 +02:00
Matthias Voppichler
a140748b5a
Merge branch 'feat/objectify-ccxt' into cxxt_obj_sellfix
2018-04-21 22:39:22 +02:00
Matthias Voppichler
573b6b8e15
Remove unused line
2018-04-21 22:35:17 +02:00
Matthias
23e989d31f
Fix tests run in random order ( #599 )
...
* allow tests to run in random mode
* Fix random test mode for fiat-convert
* allow random test execution in persistence
* fix pep8 styling
* use "usefixtures" to prevent pylint "unused parameter" message
* add pytest-random-order to travis
2018-04-21 21:21:50 +02:00
Matthias Voppichler
990f8a996b
log in case of error
2018-04-21 21:01:53 +02:00
gcarq
f4077a51c1
log hyperopt progress to stdout instead to the logger
2018-04-21 20:52:01 +02:00
gcarq
403f59ef45
use native python logger
2018-04-21 20:47:06 +02:00
Samuel Husso
001d7443da
Merge pull request #618 from gcarq/feature/add-get_fee-mocks
...
add mocks for exchange.get_fee
2018-04-21 21:26:22 +03:00
Matthias Voppichler
ce90ee4ac2
have backtesting use fee_open and fee_close
2018-04-21 20:05:49 +02:00
Matthias Voppichler
06d230279c
Fix tests
2018-04-21 20:05:39 +02:00
Matthias Voppichler
47748bc6f7
adjust tests for fee_open and fee_close
2018-04-21 19:55:48 +02:00
Matthias Voppichler
a620aa8352
add columns fee_open and fee_close, update value
2018-04-21 19:47:08 +02:00
gcarq
09fb4ea584
add mocks for exchange.get_fee
2018-04-21 19:39:18 +02:00
gcarq
3997b6038d
let cctx handle rate limits
2018-04-21 19:11:29 +02:00
Luis Felipe Díaz Chica
954c6e8c15
Write log when trying to sell opened trades ( #608 )
2018-04-21 18:44:57 +02:00
Matthias Voppichler
7f4c70827a
Test get_amount_lots
2018-04-21 13:33:29 +02:00
Matthias Voppichler
f69e8458f4
Add tests for update_real_amount
2018-04-21 13:33:29 +02:00
Matthias Voppichler
02f0f22621
fix comment
2018-04-21 13:33:29 +02:00
Matthias Voppichler
1d43dc229b
refactor tests of get_real_amount
2018-04-21 13:33:29 +02:00
Matthias Voppichler
c7d1a767f7
add get_trades_for_order
2018-04-21 13:33:29 +02:00
Matthias Voppichler
11d8f7d522
add get_real_amount and tests
2018-04-21 13:33:29 +02:00
gcarq
1332ab397f
fix reference before assignment
2018-04-21 10:19:12 +03:00
Samuel Husso
78bafee39d
download_backtest: fix imports and travis
2018-04-19 09:44:45 +03:00
Samuel Husso
66866ff260
fix travis
2018-04-19 09:06:56 +03:00
Samuel Husso
1dcd7e747e
partial fix for download testdate
2018-04-19 09:01:34 +03:00
Samuel Husso
42c0d7c7c3
Merge pull request #603 from enenn/ccxt-objectify-pr3_1
...
[3/3] Add support for multiple exchanges with ccxt (objectified version)
2018-04-18 15:23:33 +03:00
enenn
488210915a
Flak8 fixes...
2018-04-15 13:11:17 +02:00
enenn
f1d406b1e6
Fix possible race condition during testing
...
Order would sometimes fail to sell during tests,
probably because time between current time and creation was 0
2018-04-15 12:50:47 +02:00
enenn
89ed2e0127
Get mocked exhange buy return value from existing fixture
2018-04-15 12:48:02 +02:00
enenn
53b1f8d3a4
Add a 4th pair to testing dynamic whitelist generation
2018-04-15 12:20:49 +02:00
enenn
cc5991d269
Fixturize fee MagicMock object in tests
2018-04-15 12:09:12 +02:00
Michael Egger
b8184e4fdd
Merge pull request #602 from xmatthias/obj_ccxt_test_formatms
...
Add test for format_ms_time
2018-04-13 00:44:25 +02:00
Matthias Voppichler
37dee02e1c
Add comment and extract magic number to variable
2018-04-12 19:32:14 +02:00
enenn
2765a065a7
Use UNITTEST/BTC pair instead of ETH/BTC pair for load_data tests
2018-04-12 19:21:40 +02:00
Matthias Voppichler
bb7b2cdfd5
Disable dynamic whitelist
...
Revert regression introduced in refactoring for objectify
(cherry picked from commit 5bd7954
)
2018-04-12 18:35:35 +02:00
enenn
94287d66a8
Flake8 fixes
2018-04-12 18:16:27 +02:00
enenn
1678518cd4
Add dry_run=True to config during backtesting
2018-04-12 18:16:26 +02:00
enenn
838bd5824e
Mock validate_pairs
2018-04-12 18:16:26 +02:00
enenn
a650072fe0
Edit signal handler tests to work on windows as well
2018-04-12 18:16:26 +02:00
enenn
6115fb08c0
Remove get_fee_maker/taker and add argument to get_fee instead
2018-04-12 18:16:25 +02:00
enenn
91b2092d55
Remove ticker_history_api and ticker_history_without_bv from conftest.py
2018-04-12 18:16:25 +02:00
enenn
cba8745164
Update exchange validate_pairs and related tests
2018-04-12 18:16:19 +02:00
enenn
c3d00a8825
Change ticker format to ccxt in backtesting and optimize tests
2018-04-12 18:14:33 +02:00
enenn
261522446e
Change to ccxt ticker format in test_analyze.py
2018-04-12 18:07:45 +02:00
enenn
a86104d0fe
Update backtesting and hyperopt tests to use default_config and mock validate_pairs
...
Use default_config from conftest.py instead of user supplied config in user_data/hyperopt_conf
Mock validate pairs so tests don't fail if pairs don't exist/are removed from exchanges
2018-04-12 18:07:45 +02:00
enenn
4ac2afacfa
Use global backtest instance for backtesting tests
2018-04-12 18:07:45 +02:00
enenn
07c655cf41
Use os.path.join for file paths
2018-04-12 18:07:45 +02:00
enenn
a9ba0981c7
Use exchange id for Trade and exchange name for RPC
2018-04-12 18:07:44 +02:00
enenn
7a074f21bd
Remove duplicate result pytest fixture
2018-04-12 18:07:44 +02:00
enenn
fef8a4c978
Update tests related to whitelist
2018-04-12 18:07:44 +02:00
enenn
0c8ecf2b1f
Add 'get_tickers' function to exchange and use it for dynamic whitelists
2018-04-12 18:07:44 +02:00
enenn
5fc8250ee4
Add 'exchange_has' function to check if exchange supports specific API call
...
Catch ccxt.NotSupported exception instead of checking beforehand
2018-04-12 18:07:44 +02:00
enenn
e42403fecc
Change date to timestamp conversion method in backtesting
2018-04-12 18:07:44 +02:00
enenn
12a84cc30b
Mock fee during testing as 0.0025
...
Ensures profit calculations does not vary if exchange fees change, which can cause tests to fail
2018-04-12 18:07:44 +02:00
enenn
0ae5b75f33
Update order structure to ccxt generic structure instead of bittrex specific
2018-04-12 18:07:43 +02:00
enenn
4810d87044
Change buy/sell return value in tests
2018-04-12 18:07:43 +02:00
enenn
0b71f7186c
Replace 'get_wallet_health' and 'get_markets_summaries'
...
Both are now covered by 'get_markets'
2018-04-12 18:07:43 +02:00
Matthias Voppichler
d03f58417b
Fix timezone dependency in test
2018-04-11 20:19:13 +02:00
Matthias Voppichler
7123985325
Add test for format_ms_time
2018-04-10 20:10:20 +02:00
enenn
7eb5138276
Update 8m historical unittest data.
...
8m.json.gz should be a copy of 1m.json, 8m.json should be empty
2018-04-09 20:25:26 +02:00
enenn
d50445108e
Fix issue where datetime string was converted to timestamp with timezone dependent offset
2018-04-08 13:12:55 +02:00
enenn
65c5a0b308
Remove comment from donwload_backtest_data.py
2018-04-08 13:11:36 +02:00
enenn
ce3603f84f
Change ticker_interval from 5 to 5m in default strategy
2018-04-07 21:31:52 +02:00