Commit Graph

2401 Commits

Author SHA1 Message Date
Matthias be754244a3 Only resolve exchanges from correct location 2019-02-21 07:07:45 +01:00
Matthias e0f426d863 Allow import freqtrade.exchange.* 2019-02-21 06:59:52 +01:00
Matthias e987a915e8 Rename exchange file 2019-02-21 06:56:22 +01:00
Matthias 2dcb4134cc Merge branch 'develop' into pr/iuvbio/1563 2019-02-21 06:29:37 +01:00
Matthias e309f75118
Merge pull request #1581 from hroff-1902/patch-11
Minor changes to exchange
2019-02-21 06:25:47 +01:00
hroff-1902 2851833726 added _now_is_time_to_refresh() 2019-02-21 01:20:24 +03:00
hroff-1902 c1ef6940b0 removed wrong comment: tuple is not created here 2019-02-21 00:47:18 +03:00
hroff-1902 2aba9c081c fixed typos in comments 2019-02-21 00:46:35 +03:00
hroff-1902 eb21170691
added amount_reserve_percent into config json-schema 2019-02-21 00:26:02 +03:00
Matthias 4315c157c7 Move exception handling to resolver, add test 2019-02-20 20:13:23 +01:00
iuvbio 686949b258 Merge branch 'develop' into kraken_support 2019-02-20 00:52:10 +01:00
iuvbio 3e2f90a32a formatting 2019-02-19 22:27:20 +01:00
iuvbio bb31e64752 add test_sell_kraken_trading_agreement 2019-02-19 21:56:20 +01:00
iuvbio 481cf02db9 add test and fix exchange_resolver 2019-02-19 19:15:22 +01:00
hroff-1902 f9d68d919c move default amount_reserve_percent value into constants 2019-02-19 11:49:49 +03:00
iuvbio eed1c2344d delete unnecessary arguments 2019-02-18 01:03:09 +01:00
iuvbio 4241caef95 changes to base and subclass 2019-02-17 23:34:15 +01:00
iuvbio d8feceebb5 fix type-hints 2019-02-17 15:54:22 +01:00
iuvbio da4faacd6b flake8 2019-02-17 15:34:44 +01:00
iuvbio 39c28626aa remove error message to make pytest pass 2019-02-17 15:29:58 +01:00
iuvbio 5e8a7a03c3 correct time_in_force param 2019-02-17 15:26:33 +01:00
iuvbio dd2522d8d0 Merge branch 'develop' into kraken_support 2019-02-17 15:21:14 +01:00
iuvbio fe792882b5 load generic class if no subclass exists 2019-02-17 14:42:55 +01:00
iuvbio d3ead2cd09 exchange import is not needed anymore 2019-02-17 04:25:39 +01:00
iuvbio c879591f45 add exchange_resolver to resolver init 2019-02-17 04:22:24 +01:00
iuvbio c315f63e4b use exchange_resolver in freqbot 2019-02-17 04:18:56 +01:00
iuvbio 2fb36b116d change variable names 2019-02-17 04:15:11 +01:00
iuvbio ca388a9acf create exchange_resolver 2019-02-17 04:01:43 +01:00
iuvbio 32b02c9925 kraken subclass 2019-02-17 04:01:17 +01:00
iuvbio 54d5bce445 undo kraken specific changes 2019-02-17 03:59:40 +01:00
hroff-1902 ea6d4a9d36
fetch amount_reserve_percent from config 2019-02-16 19:50:55 +03:00
Matthias e0c420b93f
Merge pull request #1550 from hroff-1902/patch-2
execute_buy, handle_trade: do not use ticker if use_order_book:true is set in config
2019-02-16 13:55:33 +01:00
iuvbio 8ed3658447 Merge branch 'develop' into kraken_support 2019-02-15 23:27:41 +01:00
Crypto God 3aa614b983 bump version 2019-02-15 22:51:09 +01:00
Crypto God 3953092edd output error message 2019-02-15 22:50:31 +01:00
Crypto God ef5a0b9afc add Kraken specifics 2019-02-15 22:50:11 +01:00
Matthias 98bd713624 iUpdate orderbook_bid_test 2019-02-14 19:15:16 +01:00
Matthias f852be1a9b Fix tests for get_ticker fix 2019-02-14 07:27:13 +01:00
hroff-1902 b87e15774b
test adjusted 2019-02-13 13:02:57 +03:00
hroff-1902 8e7e670003
Orthography in the log message 2019-02-13 12:42:39 +03:00
hroff-1902 8fc8c985d8
logs: cosmetic changes
"30 seconds" was errorneously hardcoded in the text of the log message, while actually it's RETRY_TIMEOUT which may differ
2019-02-13 12:38:44 +03:00
hroff-1902 69a24c1272
no need for test_ticker parameter just for making current tests happy, tests should be reimplemented 2019-02-13 12:23:22 +03:00
hroff-1902 e8daadfb7e
same approach for the sell side (at handle_trade) 2019-02-13 03:54:57 +03:00
hroff-1902 91629807f7
shame on me 2019-02-13 03:17:54 +03:00
hroff-1902 f551fb5ff7
adjusted for passing tests
Don't like this test_ticker parameter, but it's needed for tests to pass prepared ticker.
Any ideas?
2019-02-13 03:14:24 +03:00
hroff-1902 e8ef36fb6e
execute_buy: do not use ticker if use_order_book:true is set in config
This PR corresponds to:
https://github.com/freqtrade/freqtrade/issues/1377#issue-386200394
in understanfing that pair Ticker is mostly statistics, but on the other side, create_trade/execute_buy.

It resolves problem with some exchanges (BitMex) where ticker structure returned by ccxt does not contain bid and ask values.

1. On exchanges like Bitmex, set use_order_book: true for buys. FT won't request ticker and will use data from order book only.
2. On exchanges where order book is not available, set use_order_book: false, ticker data (including ask/last balance logic) will be used.
3. On other exchanges, either approach may be used in the config.

Performance: current implementation fetches ticker every time even if order book data will be later used. With this change it's eliminated.

Comparison of order book rate and ticker rate is removed (in order to split fetching order book and ticker completely in execute_buy), so some tests that touch this code may require adjustments.
2019-02-13 02:55:55 +03:00
Matthias d91dbf4090
Merge pull request #1545 from hroff-1902/patch-3
Cosmetic: fix logging
2019-02-11 06:12:17 +01:00
hroff-1902 69f69d965c
test asserts aligned accordingly to new log messages 2019-02-10 23:37:24 +03:00
hroff-1902 5e741a0f73
fixed flake 2019-02-10 22:28:40 +03:00
hroff-1902 d6c0c107ac
fixed flake
hmm, even in the comments?
2019-02-10 22:23:00 +03:00