Rokas Kupstys
d34da3f981
Revert "Add dataframe parameter to custom_stoploss() and custom_sell() methods."
...
This reverts commit 595b8735f8
.
# Conflicts:
# freqtrade/optimize/backtesting.py
# freqtrade/strategy/interface.py
2021-05-08 10:29:47 +03:00
Joe Schr
f3388ed9aa
fix IStrategy: abstract methods still need to pass through return value
...
otherwise doing something like:
```py
dataframe = super().populate_indicators(dataframe, ...)
```
won't work, because `dataframe` becomes `None`.
This is needed if one of those methods uses dataframe.copy() instead of
just working on reference. e.g. using `merge_informative` in
`populate_indicator` in a nested class hierarchy
2021-04-30 14:39:01 +02:00
Matthias
55faa6a84a
safe_wrapper should use kwargs to call methods
2021-04-26 20:18:03 +02:00
Matthias
dbf33271b5
Small doc changes
2021-04-26 19:52:26 +02:00
Rokas Kupstys
31a2285eac
Fix mypy complaints.
2021-04-26 10:42:24 +03:00
Rokas Kupstys
595b8735f8
Add dataframe parameter to custom_stoploss() and custom_sell() methods.
2021-04-25 09:48:40 +03:00
Rokas Kupstys
961b38636f
Remove explicit sell_flag parameter from SellCheckTuple.
2021-04-25 09:48:40 +03:00
Rokas Kupstys
bfad4e82ad
Make execute_sell() use SellCheckTuple for sell reason.
2021-04-25 09:48:40 +03:00
Rokas Kupstys
a90e795695
Warn and trim custom sell reason if it is too long.
2021-04-25 09:48:40 +03:00
Rokas Kupstys
1aad128d85
Support returning a string from custom_sell() and have it recorded as custom sell reason.
2021-04-25 09:48:40 +03:00
Rokas Kupstys
1292e08fe4
Use strategy_safe_wrapper() when calling custom_sell().
2021-04-25 09:48:40 +03:00
Rokas Kupstys
0fd68aee51
Add IStrategy.custom_sell method which allows per-trade sell signal evaluation.
2021-04-25 09:48:40 +03:00
Rokas Kupstys
bbe6ece38d
[SQUASH] Fix parameter configs not loading.
2021-03-26 16:56:24 +02:00
Rokas Kupstys
e9f0babe8a
[SQUASH] Use HyperStrategyMixin as part of IStrategy interface.
2021-03-26 16:56:24 +02:00
Matthias
e32b2097f0
Use timestamp in UTC timezone for ROI comparisons
2021-02-27 09:32:59 +01:00
JoeSchr
642e3be7c5
Fix(strategy/interface.py): comment typo
...
`advice_buy` -> `advise_buy`
2021-02-26 23:17:59 +01:00
Matthias
3d9b4034e6
Use already calculated current_profit for sell_profit_offset comparison
2021-02-02 08:06:19 +01:00
Pan Long
4cc93151c5
Fix a bug when compare sell_profit_offset
...
It should be comparing the ratio instead of absolut profit.
Also updated the comment.
2021-01-31 12:14:09 +08:00
Matthias
6007d5182a
Merge pull request #4147 from hoeckxer/ignore_expired_candle
...
Ignoring candles that have expired within timeframe
2021-01-12 19:04:16 +01:00
hoeckxer
1f6a71fdd9
Reformat code on new version
2021-01-12 08:24:11 +01:00
hoeckxer
71f45021b9
Removed redundant statement
2021-01-12 07:35:30 +01:00
hoeckxer
e328182bd7
Changed workings so it only needs to timing-parameter, instead of also requiring a boolean value
2021-01-12 07:30:39 +01:00
Matthias
63a579dbab
Add sell_profit_offset parameter
...
Allows defining positive offsets before enabling the sell signal
2021-01-11 19:30:25 +01:00
Matthias
b43ef474ad
Fix expired candle implementation
...
Improve and simplify test by passing the current time to the function
2021-01-07 07:51:49 +01:00
Matthias
c9e477214f
Allow protections to be set in the strategy
2021-01-06 16:37:09 +01:00
hoeckxer
65d91a3a58
isort fix
2021-01-05 15:36:34 +01:00
hoeckxer
573de1cf08
Fixed flake8 warnings
2021-01-05 15:30:29 +01:00
hoeckxer
e3f3f36298
Changes based on review comments
2021-01-05 14:49:35 +01:00
hoeckxer
c9ed2137bb
Simplified return statements
...
Signed-off-by: hoeckxer <hawkeyenl@yahoo.com>
2021-01-05 09:07:46 +01:00
Erwin Hoeckx
67306d943a
Update interface.py
...
Simplified return value, thereby including the situation where the time simply hasn't expired yet
2021-01-05 07:33:34 +01:00
Erwin Hoeckx
9a93a0876a
Update interface.py
...
Adjusted comment
2021-01-05 07:32:07 +01:00
hoeckxer
844df96ec7
Making changes so the build checks are satisified (imports & flake8)
...
Signed-off-by: hoeckxer <hawkeyenl@yahoo.com>
2021-01-05 07:06:53 +01:00
hoeckxer
614a996597
First commit about ignoring expired candle
...
Signed-off-by: hoeckxer <hawkeyenl@yahoo.com>
2021-01-04 20:49:24 +01:00
Matthias
512e163355
change docstring to better reflect what the method is for
2020-12-31 09:48:49 +01:00
Matthias
9d5961e224
Rename method to custom_stoploss
2020-12-20 11:17:50 +01:00
Matthias
277342f167
Rename flag to "use_custom_stoposs"
2020-12-20 11:12:22 +01:00
Matthias
6892c08e9b
Improve docstring
2020-12-19 13:18:06 +01:00
Matthias
b2c1098316
more docs for dynamic stoploss method
2020-12-19 12:03:18 +01:00
Matthias
f7b54c2415
Allow and document time-based custom stoploss
...
closes #3206
2020-12-19 11:46:49 +01:00
Matthias
a414b57d54
Experiment with custom stoploss interface
2020-12-18 06:56:56 +01:00
Matthias
768a24c375
Add stoplossvalue interface
2020-12-18 06:56:56 +01:00
Matthias
7eab33de08
Merge branch 'develop' into plugins/protections_backtest
2020-12-13 10:31:33 +01:00
Matthias
f1af2972e2
Ensure non-defined attributes fail correctly
...
Remove unnecessary check, as stoploss cannot be none (it's mandatory and
a number)
2020-12-09 07:55:08 +01:00
Matthias
be57ceb252
Remove confusing entry
...
(in this branch of the if statement, candle_date is empty
2020-12-07 08:23:10 +01:00
Matthias
fefb4b23d0
revise logic in should_sell
2020-11-27 09:24:53 +01:00
Matthias
81d08c4def
Add detailed backtest test verifying the ROI / trailing stop collision
2020-11-27 08:24:56 +01:00
radwayne
8e03fee868
Update interface.py
...
Changed The should_sell() method, to handle the case where both ROI and trailing stoploss are reached in backtest.
2020-11-06 13:56:46 +01:00
Matthias
e602ac3406
Introduce Pairlocks middleware
2020-10-27 07:06:06 +01:00
Matthias
a143f7bc43
Improve pairlock docstrings
2020-10-21 19:35:57 +02:00
Matthias
7caa6cfe31
Add tests for pairlock
2020-10-20 19:21:13 +02:00
Matthias
e513871fd5
Persist pairlocks
...
closes #3034
2020-10-20 19:21:13 +02:00
Matthias
66b77d2f53
Fix some types
2020-10-02 06:52:43 +02:00
Matthias
253b7b763e
Apply isort to freqtrade codebase
2020-09-28 19:40:46 +02:00
Matthias
3bb69bc1bd
Add returns statement to docstring
2020-08-24 17:31:00 +02:00
Matthias
fca11160e4
Improve docstring of is_pair_locked
2020-08-24 17:18:57 +02:00
Matthias
354a406248
Sort imports in interface.py
2020-08-24 11:45:38 +02:00
Matthias
c272944834
Lock pair until a new candle arrives
2020-08-24 11:09:09 +02:00
Matthias
8b767eedfd
Merge branch 'develop' into pr/yazeed/3055
2020-08-24 07:21:48 +02:00
Matthias
87e4a82041
Merge branch 'develop' into bt_add_maxdrawdown
2020-08-09 08:34:36 +02:00
Matthias
c4a9a79be0
Apply suggested documentation changes from code review
...
Co-authored-by: hroff-1902 <47309513+hroff-1902@users.noreply.github.com>
2020-07-04 09:43:49 +02:00
Matthias
1339479882
Have sell_type stringify correctly
2020-07-03 06:58:27 +02:00
Matthias
eef3c01da7
Fix function header formatting
2020-06-18 19:49:05 +02:00
Matthias
f1993fb2f4
Pass analyzed dataframe to get_signal
2020-06-18 08:09:52 +02:00
Matthias
48225e0d80
Improve interface docstrings for analyze functions
2020-06-18 07:54:00 +02:00
Matthias
f2a778d294
Combine tests for empty dataframe
2020-06-18 07:03:30 +02:00
Matthias
8b186dbe0e
Add additional test scenarios
2020-06-18 06:50:06 +02:00
Matthias
84329ad2ca
Add confirm_trade* methods to abort buying or selling
2020-06-18 06:50:06 +02:00
Matthias
910100f1c8
Improve docstring comment
2020-06-18 06:50:06 +02:00
Matthias
bc821c7c20
Add documentation for bot_loop_start
2020-06-18 06:50:06 +02:00
Matthias
77056a3119
Add bot_loop_start callback
2020-06-18 06:50:06 +02:00
Matthias
8166b37253
Explicitly check if dp is available
2020-06-18 06:50:06 +02:00
Matthias
55fa514ec9
Adapt most tests
2020-06-18 06:50:05 +02:00
Matthias
273aaaff12
Introduce .analyze() function for Strategy
...
Fixing a few tests along the way
2020-06-18 06:50:05 +02:00
Matthias
95f3ac08d4
Update some comments
2020-06-18 06:50:05 +02:00
Matthias
fd97ad9b76
Cache analyzed dataframe
2020-06-18 06:50:05 +02:00
Matthias
a8005819c9
Add class-level attributes to hyperopt and strategy
2020-06-02 10:19:27 +02:00
Matthias
09fe3c6f5e
create compatibility code
2020-06-02 09:52:30 +02:00
Matthias
cadc50ce9b
Replace more occurances of ticker_interval with timeframe
2020-06-01 20:49:40 +02:00
Matthias
ea5daee505
Allow changing severity of strategy-validations to log only.
2020-05-29 19:37:18 +02:00
Matthias
27e0c2604c
Add comment to ensure we're not accidentally removing this again
2020-05-26 16:58:29 +02:00
hroff-1902
9f573481a8
Fix #3378
2020-05-26 13:54:45 +03:00
Matthias
046202fdda
Fix typing circular dependency
2020-05-22 20:56:34 +02:00
hroff-1902
8bf38443c2
Merge branch 'develop' into verify_date_on_new_candle_on_get_signal
2020-05-20 14:05:21 +03:00
hroff-1902
a8b1dcf3c8
Minor: cleanup in get_signal()
2020-05-19 22:20:53 +03:00
hroff-1902
7b2bb73a12
Merge branch 'develop' into verify_date_on_new_candle_on_get_signal
2020-05-19 21:34:58 +03:00
hroff-1902
115586a50f
Introduce freqtrade.typing
2020-05-18 21:59:50 +03:00
hroff-1902
627c5059f0
Move create_pair_list to pairlistmanager
2020-05-18 13:54:21 +03:00
hroff-1902
f8b01f5a43
Make flake happy
2020-05-16 12:27:56 +03:00
hroff-1902
bf25746965
Introduce datatype for informative pairs
2020-05-16 12:27:56 +03:00
Matthias
431b244f43
Merge branch 'develop' into interface_ordertimeoutcallback
2020-04-19 06:58:44 +02:00
Matthias
c465552df4
Update comment to mention .copy() usage
2020-04-02 20:17:54 +02:00
Matthias
3fcd531eac
Copy dataframe in interfac.py (reduces memory consumption)
2020-04-02 19:30:59 +02:00
Matthias
cd2e738e35
Add test for assert error
2020-03-29 11:40:13 +02:00
orehunt
3ef568029f
different exception messages
2020-03-26 07:05:30 +01:00
orehunt
0f53e646fd
check that the strategy dataframe matches the one given by the bot
2020-03-24 14:08:34 +01:00
Matthias
a1bbeaa668
Merge branch 'develop' into interface_ordertimeoutcallback
2020-03-15 14:56:14 +01:00
Yazeed Al Oyoun
1395f65872
meh
2020-03-11 17:29:22 +01:00
Yazeed Al Oyoun
c442913feb
final
2020-03-11 17:28:03 +01:00
Yazeed Al Oyoun
ba596af636
final?
2020-03-11 17:26:57 +01:00
Yazeed Al Oyoun
d25cf1395b
fixed log message
2020-03-11 17:23:22 +01:00