hroff-1902
ea6d4a9d36
fetch amount_reserve_percent from config
2019-02-16 19:50:55 +03:00
Matthias
e0c420b93f
Merge pull request #1550 from hroff-1902/patch-2
...
execute_buy, handle_trade: do not use ticker if use_order_book:true is set in config
2019-02-16 13:55:33 +01:00
hroff-1902
8fc8c985d8
logs: cosmetic changes
...
"30 seconds" was errorneously hardcoded in the text of the log message, while actually it's RETRY_TIMEOUT which may differ
2019-02-13 12:38:44 +03:00
hroff-1902
69a24c1272
no need for test_ticker parameter just for making current tests happy, tests should be reimplemented
2019-02-13 12:23:22 +03:00
hroff-1902
e8daadfb7e
same approach for the sell side (at handle_trade)
2019-02-13 03:54:57 +03:00
hroff-1902
91629807f7
shame on me
2019-02-13 03:17:54 +03:00
hroff-1902
f551fb5ff7
adjusted for passing tests
...
Don't like this test_ticker parameter, but it's needed for tests to pass prepared ticker.
Any ideas?
2019-02-13 03:14:24 +03:00
hroff-1902
e8ef36fb6e
execute_buy: do not use ticker if use_order_book:true is set in config
...
This PR corresponds to:
https://github.com/freqtrade/freqtrade/issues/1377#issue-386200394
in understanfing that pair Ticker is mostly statistics, but on the other side, create_trade/execute_buy.
It resolves problem with some exchanges (BitMex) where ticker structure returned by ccxt does not contain bid and ask values.
1. On exchanges like Bitmex, set use_order_book: true for buys. FT won't request ticker and will use data from order book only.
2. On exchanges where order book is not available, set use_order_book: false, ticker data (including ask/last balance logic) will be used.
3. On other exchanges, either approach may be used in the config.
Performance: current implementation fetches ticker every time even if order book data will be later used. With this change it's eliminated.
Comparison of order book rate and ticker rate is removed (in order to split fetching order book and ticker completely in execute_buy), so some tests that touch this code may require adjustments.
2019-02-13 02:55:55 +03:00
hroff-1902
5e741a0f73
fixed flake
2019-02-10 22:28:40 +03:00
hroff-1902
08d35f3e15
fix checks
...
Should not make cosmetic changes right in the github editor without local smoketests...
2019-02-10 22:09:11 +03:00
hroff-1902
b91981f0aa
Cosmetic: fix logging
...
Output stake_amount as it is defined in the config (it may by int) instead of float. In order to avoid unnecessary questions where and why it was converted to float and changed in the last digit while it should be integer for the exchange...
Other small cosmetic improvements to logging in freqtradebot.py
2019-02-10 21:31:13 +03:00
Matthias
0a71ebce68
Remove unneeded pair conversation, add docstring
2019-02-04 06:13:22 +01:00
Matthias
02c3552954
Adjust comment
2019-02-03 13:52:05 +01:00
Matthias
e8ed8a2ea7
Handle orders cancelled on exchange
...
fix #1527
2019-02-03 13:51:52 +01:00
Samuel Husso
e3ae8d3f69
flake8 3.7.1 fixes
2019-01-31 07:51:03 +02:00
Matthias
ba07348b82
Rename additional_pairs to informative_pairs
2019-01-26 19:22:45 +01:00
Matthias
d136cac181
Merge branch 'develop' into feat/dataprovider
2019-01-23 21:01:19 +01:00
Matthias
13e2f71d30
Add flake8 plugins and implement small improvements
2019-01-22 20:01:12 +01:00
Matthias
e66808bb02
Add additional pairs to refresh call
2019-01-22 07:07:15 +01:00
Matthias
1e749a0f9b
Rename variable to be clearer
2019-01-22 07:07:15 +01:00
Matthias
0aa0b1d4fe
Store tickers by pair / ticker_interval
2019-01-22 07:07:15 +01:00
Matthias
b981cfcaa0
remove comment which proves untrue now
2019-01-22 07:05:09 +01:00
Matthias
a206777fe5
Rename refresh_tickers to refresh_latest_ohlcv
2019-01-22 07:05:09 +01:00
Matthias
5ecdecd1eb
remove unused local variable persistance
2019-01-22 07:04:19 +01:00
Matthias
58f1abf287
Add dp / wallets to strategy interface
2019-01-22 07:04:19 +01:00
Matthias
4ab7edd3d6
small adaptations
2019-01-22 07:04:19 +01:00
Matthias
7206287b00
Use Dataprovider
2019-01-22 07:04:19 +01:00
Matthias
c2578c7321
Merge pull request #1474 from mishaker/tsl_on_exchange
...
Making trailing stoploss compatible with stoploss on exchange
2019-01-18 19:29:39 +01:00
misagh
70780bb01e
using dict.get to fetch interval
2019-01-18 12:02:29 +01:00
misagh
75cedfafb8
unreachable code removed
2019-01-16 20:03:34 +01:00
misagh
611b48dbb9
fix return value from info hash: value is in string
2019-01-16 16:15:36 +01:00
misagh
baa5cc5b9e
logs enriched
2019-01-16 15:10:31 +01:00
misagh
aa03a864f7
comments added for TSL on exchange function
2019-01-16 15:00:35 +01:00
misagh
6d588b3b0b
trailing stop loss on exchange extracted to a separate function
2019-01-16 14:28:52 +01:00
misagh
bfb7121583
refactoring handle_stoploss_on_exchange
2019-01-16 12:16:32 +01:00
misagh
29439c05d6
adding update beat test
2019-01-16 11:51:54 +01:00
misagh
1cd5abde37
removing unnecessary guard
2019-01-16 11:22:25 +01:00
misagh
12e8108015
checking params of cancel order and stop loss order
2019-01-15 15:36:41 +01:00
misagh
cfe00c2f0c
initial test added for TSL on exchange
2019-01-15 11:04:32 +01:00
misagh
e025ad3918
temp test commit
2019-01-09 16:23:13 +01:00
misagh
1a27258469
condition fixed
2019-01-08 16:34:23 +01:00
misagh
9e133eb32e
adding guard not to cancel the previous stop loss on exchange if market
...
is falling quickly
2019-01-08 16:31:02 +01:00
misagh
aed855284c
comparing with stopPrice instead of price
2019-01-08 13:44:51 +01:00
misagh
821e299afb
adjusting trailing stoploss on exchange
2019-01-06 14:45:29 +01:00
misagh
a5137e4fa4
comparing float instead of int
2018-12-24 11:39:11 +01:00
Misagh
1dbcab0b09
Merge pull request #1413 from freqtrade/feat/data_helpers
...
Feat/data helpers
2018-12-17 09:14:10 +01:00
Matthias
b3bb98777b
Merge branch 'develop' into time_in_force
2018-12-17 06:37:46 +01:00
Matthias
b38195e9b3
Rename to converter
2018-12-14 06:32:49 +01:00
Matthias
453f62cdfa
Adjust imports
2018-12-14 06:32:49 +01:00
Matthias
627ab9f583
pass around dataframe instead of list
2018-12-12 19:17:09 +01:00
