hroff-1902
d4362ed357
Minor: improve exception handling in exchange
2020-05-09 09:29:40 +03:00
Matthias
021e2b58ca
Support partially cancelled orders for fee calculation
2020-05-01 20:24:26 +02:00
Matthias
6b33d5af1e
Fix fee-calculation for dry-run orders
2020-05-01 19:51:35 +02:00
Matthias
59bafc8d02
Implement fee rate calculation
2020-05-01 15:50:02 +02:00
Matthias
45c97fde2d
Use correct typehint for extract_cost_curr_rate
2020-05-01 15:50:02 +02:00
Matthias
e74ed0ba7b
Add tests for fee extraction methods
2020-04-30 20:05:27 +02:00
Matthias
2e4dc6c253
Exchange should return fee dict for dry-run orders
2020-04-30 19:56:48 +02:00
Matthias
a867d40eac
Move fee_methods to exchange
2020-04-30 19:33:27 +02:00
Matthias
c775d65126
Update typehint for cancel_order
2020-04-18 06:55:25 +02:00
Matthias
5e3e0e819f
Add tests for cancel_order_with_result
2020-04-17 17:53:18 +02:00
Matthias
800891a475
Add tests for cancel_order_with_result
2020-04-17 07:18:46 +02:00
hroff-1902
df79011aba
Merge pull request #3112 from freqtrade/trade_state_updates
...
Trade state updates
2020-04-16 12:05:19 +03:00
Matthias
33b6c7de5b
Add tests for price_one_pip
2020-04-15 07:53:31 +02:00
Matthias
36e714a7b2
Add price_get_one_pip filter
2020-04-15 07:19:27 +02:00
Matthias
cfe1e4876a
Improve testcase for cancel_order_empty
2020-04-14 19:20:47 +02:00
Matthias
d76bb1ccf4
Use List of Lists instead of list of Dicts for trades data
2020-04-01 19:45:21 +02:00
Matthias
270ac2e8c1
Add check_order_cancelled_empty method to exchange
2020-03-25 09:43:04 +01:00
hroff-1902
3208faf7ed
Do not use ticker where it's not a ticker
2020-03-08 20:47:02 +03:00
hroff-1902
8475baba4e
Merge pull request #2995 from freqtrade/stake_curr_empty
...
Allow Stake currency empty when using download-data
2020-03-02 00:53:09 +03:00
Matthias
60f04cff4d
Simplify expression
2020-02-29 20:41:03 +01:00
Matthias
d7373be553
Add official support for Kraken
2020-02-29 16:58:22 +01:00
Matthias
60579485e5
fix empty stake currency problem
2020-02-29 14:56:36 +01:00
hroff-1902
e6d003f8f2
Merge pull request #2973 from freqtrade/support_non_pairs
...
Support non pairs
2020-02-26 12:20:45 +03:00
Matthias
f38accb77b
Return empty string if no quote / base currency can be found
2020-02-26 07:09:54 +01:00
Matthias
4e218be51d
Don't use markets[pair]['quote']
2020-02-26 07:08:09 +01:00
Matthias
31ac4598ba
Fix last occurances of pair splitting
2020-02-25 07:16:37 +01:00
Matthias
61037ab7b8
Implement get_pair_base_curr and get_pair_quote_curr
2020-02-24 21:50:27 +01:00
Matthias
3e4f663418
Move pairlist validation to exchange (we need to use .quote) from
...
markets
2020-02-24 21:33:42 +01:00
Matthias
f5b4a6d3d7
Remove fetch_ticker caching
2020-02-22 11:10:05 +01:00
hroff-1902
d457d43999
Merge pull request #2833 from hroff-1902/type-hints
...
Add some type hints
2020-02-03 23:24:26 +03:00
hroff-1902
684cb54992
Add pair to exception msg
2020-02-03 17:17:46 +03:00
hroff-1902
df249c7c03
Remove unclear comment
2020-02-03 09:37:50 +03:00
hroff-1902
f3d500085c
Add some type hints
2020-02-02 07:00:40 +03:00
Matthias
cf9331919f
move exchange-specific order-parsing to exchange class
...
Related to stoploss_on_exchange in combination with trailing stoploss.
Binance contains stopPrice in the info, while kraken returns the same
value as "price".
2020-01-19 19:54:30 +01:00
Matthias
16b34e11ca
Complete rename of stoploss_limit to stoploss
2020-01-19 14:40:09 +01:00
Matthias
256fc2e78c
Rename stoploss_limit to stoploss
2020-01-19 13:30:56 +01:00
Matthias
8d2e0bfd62
Move rate-calcuation for stoploss-limit order to exchange
2020-01-19 13:13:09 +01:00
hroff-1902
2f82122fc4
Merge pull request #2763 from freqtrade/fix/precision_rounding
...
Fix/precision rounding
2020-01-17 01:25:30 +03:00
Matthias
4c823f12e3
Sort imports
2020-01-14 20:25:58 +01:00
Matthias
bea4ad8eff
Revert price_to_precision to rounding up
2020-01-14 20:16:20 +01:00
Matthias
5fcab1eee8
Align method names to internal ccxt names
...
These methods are reimplemented from ccxt so we can test their behaviour.
2020-01-12 14:55:05 +01:00
Matthias
b60d7ad42f
Use ccxt.decimal_to_precision instead of our own calculation
2020-01-12 14:41:09 +01:00
Matthias
fa1f9bcdbd
expose precisionMode from exchange class
2020-01-12 14:37:45 +01:00
Matthias
53abfdbcbf
Use sorted on set instead of explicit list conversion
2020-01-12 12:48:29 +01:00
Matthias
3519cebf66
Add test for failing stake_validation
2020-01-11 13:14:19 +01:00
Matthias
60b47b6eec
Add tests for get_quote_currencies
2020-01-11 12:01:34 +01:00
Matthias
13274964a9
Implement validation for valid stake currency
2020-01-11 11:54:00 +01:00
Matthias
235a10ab86
Don't suppport <1m timeframes
2020-01-11 11:36:28 +01:00
Matthias
1ffda29fd2
Adjust improts to new exception location
2019-12-30 15:02:17 +01:00
Matthias
cadde3ab6d
Check if markets.info is a dict before using it
2019-12-27 16:15:44 +01:00
Matthias
21622ac313
Rename get_ticker to fetch_ticker
2019-12-18 16:34:30 +01:00
hroff-1902
39197458f4
Merge pull request #2661 from freqtrade/wallet_dry
...
Introduce Dry-Run Wallet
2019-12-16 14:00:11 +03:00
Matthias
c741b67c3c
Adjust tests for dry_run wallet simulation
2019-12-15 10:39:52 +01:00
Matthias
931d24b5a8
Have dry_run_wallet default to 1000
2019-12-15 09:26:17 +01:00
Matthias
2275a1539e
Remove default symbol from get_fee()
2019-12-14 13:22:42 +01:00
Matthias
b69f5afaaf
Round amount to precision also for dry-runs
2019-12-13 06:59:10 +01:00
hroff-1902
6174a5dd55
Reimplement adjustment of ccxt 'has' with more generic ccxt_config class attribute
2019-11-13 20:22:23 +03:00
hroff-1902
e26bbc7de8
Add fix for bibox exchange
2019-11-13 19:50:54 +03:00
Matthias
08aedc18e1
Exchange ticker_interval with timeframe in some more places
2019-11-12 15:13:06 +01:00
Matthias
da57396d07
Fix UTC handling of timestamp() conversation in fetch_my_trades
2019-11-08 06:55:07 +01:00
Matthias
9a42afe0be
Move exchange-constants and retriers to exchange.common
2019-10-31 10:59:17 +01:00
Matthias
132a4da7cf
Small style fixes and adjusted tests
2019-10-27 10:56:38 +01:00
Matthias
73f5bff9c5
Add validation to make sure strategies work on that exchange
2019-10-27 10:38:21 +01:00
hroff-1902
b26faa13bd
Call validate_timeframe only when validate is True
2019-10-22 13:51:36 +03:00
hroff-1902
ad5f7e1581
Merge remote-tracking branch 'origin/develop' into list-pairs2
2019-10-22 12:30:39 +03:00
hroff-1902
3cf95f9f6c
Merge pull request #2369 from freqtrade/disable_exchangevalidate
...
Allow skipping of exchange validation
2019-10-22 12:22:48 +03:00
hroff-1902
1bc63288a3
Merge branch 'develop' into list-pairs2
2019-10-20 23:22:45 +03:00
hroff-1902
47fabca1d9
Merge pull request #2372 from xmatthias/kraken_ohlcv_emulate
...
download tick-based data to emulate candles
2019-10-19 19:32:37 +03:00
Matthias
fd22c87295
Some minor cleanups to trades download methods and docs
2019-10-19 10:05:30 +02:00
hroff-1902
8564affdf0
Add tests for Exchange.get_markets()
2019-10-17 22:45:20 +03:00
hroff-1902
b6e26c82ea
Replace market_is_pair() by symbol_is_pair()
2019-10-17 18:44:25 +03:00
hroff-1902
1e61263a28
More sofisticated market_is_pair(), taken from #1989
2019-10-17 17:49:04 +03:00
hroff-1902
92fda0f76c
Allow --base and --quote be lists of currencies
2019-10-17 02:09:19 +03:00
hroff-1902
6e27c47dee
Handle properly exchanges with no active flag set for markets
2019-10-14 13:32:39 +03:00
Matthias
76ad5bea0e
Load correct exchange class
...
closes #2371
2019-10-14 11:36:42 +02:00
Matthias
13e80e449c
cleanup and better docstring
2019-10-14 06:22:10 +02:00
Matthias
762ae3a598
Extend tests
2019-10-13 13:15:22 +02:00
Matthias
640d58eb13
Remove unneeded checks
2019-10-13 13:15:22 +02:00
Matthias
fa8c61382b
Remove unneeded exception handlers
2019-10-13 13:15:22 +02:00
Matthias
16d6914b15
Add test to cover missing line
2019-10-13 13:15:22 +02:00
Matthias
05e473642b
Small adjustments to get_trade_history
2019-10-13 13:15:22 +02:00
Matthias
0d592f6c55
Refactor trade downloading to handle exceptions only once
2019-10-13 13:15:22 +02:00
Matthias
9584629f50
Rename argument from dl_path to datadir
2019-10-13 13:15:22 +02:00
Matthias
1f79ca9539
Remove duplicate check
2019-10-13 13:15:22 +02:00
Matthias
1d8fc97053
Fix duplicate trade error, rename some methods
2019-10-13 13:15:22 +02:00
Matthias
57dee794d1
Fix end-reached for id-based trade-download
2019-10-13 13:15:22 +02:00
Matthias
2c0bb71a6e
Add download_trades_history()
2019-10-13 13:15:22 +02:00
Matthias
ab8f638e44
Move id/time detection to get_historic_trades method
2019-10-13 13:15:22 +02:00
Matthias
77c367ad1d
First draft of async get_trade methods
2019-10-13 13:15:22 +02:00
Matthias
26b3148904
Add build_ohlcv wrapper
2019-10-13 13:15:22 +02:00
Matthias
27dc9ca799
Add trades_pagination attributes
2019-10-13 13:15:22 +02:00
Matthias
baad1a5166
Explain _params element
2019-10-13 13:15:22 +02:00
hroff-1902
7cf7982565
Add list-pairs and list-markets subcommands
2019-10-13 13:12:20 +03:00
Matthias
f3f6e9d365
Allow skipping of exchange validation
2019-10-13 10:33:22 +02:00
hroff-1902
946b8c29d7
Merge pull request #2317 from hroff-1902/list-timeframes
...
Add list-timeframes subcommand
2019-10-06 16:28:15 +03:00
hroff-1902
d1fa5f307b
Add --all option to list-exchanges
2019-10-01 00:33:33 +03:00
hroff-1902
7617dd5029
Add separate message for hitbtc
exchange
2019-09-30 20:01:55 +03:00
hroff-1902
272c977d08
Add exchanges to the list of bad exchanges
2019-09-30 03:55:55 +03:00
hroff-1902
75446d8195
Refactor list-timeframes command with the use of the Exchange class methods
2019-09-29 23:18:04 +03:00
hroff-1902
c5f455d660
Merge pull request #2256 from freqtrade/kraken_balance
...
fix Kraken balance calculation
2019-09-12 23:12:55 +03:00
hroff-1902
849d694c27
Don't inherit from object
2019-09-12 04:39:52 +03:00
Matthias
c01953daf2
Remove kraken block
2019-09-11 06:57:58 +02:00
Matthias
48ac37a1b8
BLock kraken trading - it's not working at the moment
2019-09-05 20:16:09 +02:00
Matthias
aae9c3194f
Reenable stoploss_on_exchange for dry-run
2019-09-01 17:48:06 +02:00
Matthias
b5789203f2
Merge branch 'develop' into timeframe_use_ccxt
2019-08-26 19:48:58 +02:00
Matthias
565a543b7b
Use ccxt base methods to round timeframe
2019-08-25 10:34:56 +02:00
Matthias
2c66b33fd1
Adapt some tests to use Binance subclass for stoplosslimit
2019-08-25 09:57:21 +02:00
Matthias
defa1c027d
Move stoploss_limit to binance subclass
2019-08-25 09:50:37 +02:00
Matthias
ea179a8e38
stoploss_limit shall not use create_order()
...
It needs to handle exceptions differently
2019-08-25 09:43:10 +02:00
Matthias
8a17615b5a
move exceptionhandling from create_order() to calling functions
2019-08-25 09:42:02 +02:00
hroff-1902
d19b11a00f
exchange cosmetics
2019-08-22 20:01:41 +03:00
Matthias
dc35a8022b
Merge pull request #2157 from freqtrade/fix/create_order_crash
...
create market order crash if exchange raises an exception
2019-08-20 06:22:43 +02:00
Matthias
a4ede02ced
Gracefully handle problems with dry-run orders
2019-08-18 19:38:23 +02:00
Matthias
045ac1019e
Split test for buy-orders too
2019-08-18 15:58:53 +02:00
Matthias
ee7ba96e85
Don't do calculations in exception handlers when one element can be None
...
fixes #2011
2019-08-18 15:46:38 +02:00
Matthias
93cf2cd19b
Merge pull request #2135 from freqtrade/ohlcv_docstring
...
[minor] Improve docstring for some downloading methods
2019-08-15 16:23:42 +02:00
Matthias
14c4854987
Merge branch 'develop' into lock_pairs
2019-08-15 06:56:39 +02:00
Matthias
9f26c4ebdc
Merge branch 'develop' into fix/sell_order_hanging
2019-08-15 06:46:12 +02:00
Matthias
11790fbf01
Fix typos in docstrings
2019-08-15 06:37:26 +02:00
Matthias
84baef922c
Rename get_history to get_historic_ohlcv
2019-08-14 10:14:54 +02:00
Matthias
4da2bfefb7
Improve docstring for some downloading methods
2019-08-14 09:37:17 +02:00
Matthias
3c589bb877
fail if known bad exchanges are detcted
2019-08-13 08:27:46 +02:00
Matthias
d8dbea9d5b
Add exchange_reasons to bad exchanges
2019-08-13 08:20:35 +02:00
Matthias
ca739f71fb
Fix default argument handling for timeframe_to_nextdate
2019-08-12 20:39:24 +02:00
Matthias
2600cb7b64
simplify timeframe_next_date calculation
2019-08-12 20:04:19 +02:00
Matthias
444ee274d7
close dry-run orders in case of market orders
2019-08-12 16:46:45 +02:00
Matthias
1ce63b5b42
Reformat tests to be easier readable
2019-08-12 16:25:01 +02:00
Matthias
dd0ba183f8
Add timeframe_to_prev_candle
2019-08-12 16:11:43 +02:00
Matthias
933a553dd4
Convert timeframe to next date
2019-08-12 16:08:23 +02:00
Matthias
a90ced1f38
Since arguments are in milliseconds integer throughout ccxt.
...
Explained here: https://github.com/ccxt/ccxt/issues/5636
fixes #2093
2019-08-06 20:09:09 +02:00
Matthias
bbd58e772e
Warn when using restricted pairs
...
As noted in https://github.com/ccxt/ccxt/issues/5624 , there is currently
no way to detect if a user is impacted by this or not prior to creating
a order.
2019-08-03 13:14:36 +02:00
Matthias
4b8b2f7c5b
Use raise xxx from e to have a nicer traceback
2019-07-25 20:06:20 +02:00
Matthias
9887cb997e
Check if Price is needed for market orders
...
This is currently the case for:
cex, coinex, cointiger, fcoin, fcoinjp, hadax, huobipro, huobiru, uex,
2019-07-14 14:17:09 +02:00
Matthias
61b24180f0
Merge pull request #1998 from freqtrade/fix/pax_balance
...
Support all types of pairs for /balance
2019-07-08 16:31:57 +02:00
Matthias
6c2415d32f
Rename parameters from pair to curr
2019-07-07 06:36:35 +02:00
Matthias
40fe2d2c16
Test get_valid_pair_combination
2019-07-03 20:20:12 +02:00
Matthias
fcdbe846e5
Fix #1981 - Detect reverted currency pairs
2019-07-03 20:06:50 +02:00
Matthias
e19c192570
Merge pull request #1994 from hroff-1902/fix-validate_timeframes
...
fix validate_timeframes()
2019-07-03 11:11:28 +02:00
hroff-1902
b80cef964e
fix validate_timeframes(); test added
2019-07-03 11:18:39 +03:00
hroff-1902
d41b8cc96e
catch ccxt.BaseError
2019-07-03 05:13:41 +03:00
hroff-1902
91fb9d0113
fix #1995
2019-07-03 05:02:44 +03:00
Matthias
0d601fd111
Remove logger message
2019-07-01 06:18:28 +02:00
Matthias
0c7d14fe50
Check if timeframes is available and fail gracefully otherwise
2019-06-30 20:30:31 +02:00
AlexV
e8796e009c
adding bitstamp to list of bad exchanges.
2019-06-29 17:20:10 +02:00
Matthias
a07653a6cc
Merge branch 'develop' into fix/validate_dataframe
2019-06-24 06:21:08 +02:00
Matthias
89ff614e1d
Add pair as parameter, and warn when fillup was necessary
2019-06-15 13:46:19 +02:00
hroff-1902
0cc2210f22
wording fixed
2019-06-12 22:53:43 +03:00
hroff-1902
db6ccef6bd
return back check in init_ccxt()
2019-06-11 13:43:29 +03:00
hroff-1902
676e730013
enhance check_exchange
2019-06-11 13:18:35 +03:00
Matthias
9f2e0b11d1
Parametrize ohlcv_candle_limit (per call)
2019-06-09 14:52:17 +02:00
Matthias
fdbbefdddd
Make drop_incomplete optional
2019-06-09 14:35:58 +02:00
Matthias
7108a2e57d
Add deep_merge for _ft_has and test
2019-06-09 14:06:29 +02:00
hroff-1902
0e228acbfb
minor: exchange debug logging humanized
2019-05-25 22:42:17 +03:00
Matthias
45ecbc91e8
Use BaseError, not NetworkError in exception handler
2019-04-24 22:20:05 +02:00
Matthias
65dcb6acea
Catch errors on reload_markets
2019-04-24 21:56:24 +02:00
Matthias
577ccd32f0
Merge pull request #1750 from hroff-1902/ccxt-to-exchange-only
...
minor: limit usage of ccxt to freqtrade/exchange only
2019-04-19 06:51:08 +02:00
Matthias
43119efaf0
Remove ccxt_rate_limit completely (was deprecated)
2019-04-16 19:41:02 +02:00
hroff-1902
f03acce84c
typing of return value corrected
2019-04-11 00:07:27 +03:00
hroff-1902
9fbe573cca
limit usage of ccxt to freqtrade/exchange only
2019-04-09 12:27:35 +03:00
Matthias
6856848efc
Merge pull request #1744 from hroff-1902/ccxt-parse_timeframe
...
cosmetic: rename interval, tick_interval, etc --> ticker_interval
2019-04-08 20:26:36 +02:00
hroff-1902
ebf1126351
cosmetic: rename interval, tick_interval, etc --> ticker_interval
2019-04-07 16:28:53 +03:00
Matthias
4a6c8f3cb2
Merge pull request #1735 from hroff-1902/ccxt-parse_timeframe
...
Resolution for #1137
2019-04-07 12:52:13 +02:00
Misagh
d294cab933
adding order id to invalidorder exception message
2019-04-06 20:27:03 +02:00
Misagh
2b49a11b2a
returning InvalidOrder exception for get_order
2019-04-05 19:46:43 +02:00
hroff-1902
2aa1b43f01
get rid of TICKER_INTERVAL_MINUTES dict, use ccxt's parse_timeframe() instead
2019-04-04 20:56:40 +03:00
Misagh
40df0dcf3d
tests fixed
2019-04-02 18:45:18 +02:00
Misagh
99d256422e
adding InvalidOrder to exchange
2019-04-02 18:31:03 +02:00
Matthias
9b22d5cab1
Fix typo, add test for validate_order_tif
2019-03-27 20:51:55 +01:00
iuvbio
e15f2ef11a
add order_time_in_force in _ft_has and revert binance
2019-03-26 00:49:39 +01:00
iuvbio
4005b8d1d2
remove the if condition for binance
2019-03-25 23:57:14 +01:00
iuvbio
85ac99aee0
move exchange urls to constants
2019-03-25 23:57:14 +01:00
Matthias
35d65bc7d7
Merge branch 'develop' into 'validate_whitelist'
2019-03-21 06:22:48 +01:00
hroff-1902
580ada8c4f
exchange cleanup
2019-03-19 20:52:35 +03:00
iuvbio
a241e950f2
prune validate_pairs
2019-03-17 16:04:09 +01:00
misagh
b5034cf535
TSL validator removed from exchange
2019-03-14 09:04:41 +01:00
misagh
9a226ec7e6
conflict with develop resolved
2019-03-14 07:56:21 +01:00
iuvbio
a1841c35ae
reset _last_markets_refresh
2019-03-13 20:18:49 +01:00
iuvbio
779bcdd990
remove reload for async api
2019-03-12 16:35:32 +01:00
iuvbio
1a92bf9e8e
add test
2019-03-12 16:31:22 +01:00
iuvbio
8741017819
remove get_markets
2019-03-12 16:31:22 +01:00
iuvbio
0d980134e7
add markets reload func
2019-03-12 16:31:22 +01:00
iuvbio
3ad0686bc7
fix typing
2019-03-12 16:31:22 +01:00
iuvbio
df9410cd15
check if markets were loaded
2019-03-12 16:31:22 +01:00
iuvbio
041e9957dd
add reload argument
2019-03-12 16:31:22 +01:00
iuvbio
6b97af4a03
add comment
2019-03-12 16:31:22 +01:00
iuvbio
5c840f333f
slight change to exception message
2019-03-12 16:31:22 +01:00
iuvbio
47cc04c0a3
use self.markets instead of _api.markets
2019-03-12 16:31:22 +01:00
iuvbio
ccad883256
adjust get_markets
2019-03-12 16:31:22 +01:00
iuvbio
3a2aa54d2a
add markets property
2019-03-12 16:31:22 +01:00
iuvbio
d423f58566
replace fetch_markets
2019-03-12 16:31:22 +01:00
misagh
f55d75e7fc
TSL validation tests added
2019-03-12 15:35:44 +01:00
misagh
36e95bc868
unnecessary variable removed
2019-03-12 13:10:59 +01:00
misagh
3e40f5c588
if condition simplified
2019-03-12 13:09:27 +01:00
misagh
643262bc6a
add trailing stop loss config validator
2019-03-12 13:03:29 +01:00
Matthias
0eb9dd5fe5
Don't use timeInForce for market orders
2019-03-11 20:30:36 +01:00
Matthias
0a2cacbba8
Fix #1637
2019-03-08 21:17:12 +01:00
hroff-1902
b792f00553
exchange cleanup
2019-03-01 02:13:16 +03:00
Matthias
6c75b8a36a
Remove pair market url
2019-02-26 19:27:28 +01:00
Matthias
006635003e
Fix small typos
2019-02-24 20:18:41 +01:00
Matthias
f2fd5205ef
Fix typo
2019-02-24 20:13:38 +01:00
Matthias
455b168366
add _ft_has to exchangeclass
2019-02-24 19:35:29 +01:00
iuvbio
403ed48c3e
rename _store_dry_order
2019-02-23 16:28:13 +01:00
iuvbio
ec6794b9ba
fix dry_orders
2019-02-23 16:03:15 +01:00
iuvbio
9a097214a6
return complete dry_order in buy and sell
2019-02-22 19:22:48 +01:00
iuvbio
71774bce6f
Merge branch 'develop' of https://github.com/freqtrade/freqtrade into order_creation
2019-02-22 19:02:31 +01:00
Matthias
e987a915e8
Rename exchange file
2019-02-21 06:56:22 +01:00