Merge pull request #3217 from freqtrade/remove_deprecation

Remove deprecated pairlist and binary

tests/pairlist/test_pairlist.py

@@ -4,11 +4,11 @@ from unittest.mock import MagicMock, PropertyMock
 
 import pytest
 
-from freqtrade.exceptions import OperationalException
 from freqtrade.constants import AVAILABLE_PAIRLISTS
-from freqtrade.resolvers import PairListResolver
+from freqtrade.exceptions import OperationalException
 from freqtrade.pairlist.pairlistmanager import PairListManager
-from tests.conftest import get_patched_freqtradebot, log_has_re
+from freqtrade.resolvers import PairListResolver
+from tests.conftest import get_patched_freqtradebot, log_has, log_has_re
 
 # whitelist, blacklist
 
@@ -228,6 +228,13 @@ def test_VolumePairList_whitelist_gen(mocker, whitelist_conf, shitcoinmarkets, t
             assert (log_has_re(r'^Removed .* from whitelist, because 1 unit is .*%$', caplog) or
                     log_has_re(r"^Removed .* from whitelist, because ticker\['last'\] is empty.*",
                                caplog))
+        if pairlist['method'] == 'VolumePairList':
+            logmsg = ("DEPRECATED: using any key other than quoteVolume for "
+                      "VolumePairList is deprecated.")
+            if pairlist['sort_key'] != 'quoteVolume':
+                assert log_has(logmsg, caplog)
+            else:
+                assert not log_has(logmsg, caplog)
 
 
 def test_gen_pair_whitelist_not_supported(mocker, default_conf, tickers) -> None:

tests/test_configuration.py

@@ -1041,18 +1041,6 @@ def test_process_temporary_deprecated_settings(mocker, default_conf, setting, ca
     assert default_conf[setting[0]][setting[1]] == setting[5]
 
 
-def test_process_deprecated_setting_pairlists(mocker, default_conf, caplog):
-    patched_configuration_load_config_file(mocker, default_conf)
-    default_conf.update({'pairlist': {
-        'method': 'VolumePairList',
-        'config': {'precision_filter': True}
-    }})
-
-    process_temporary_deprecated_settings(default_conf)
-    assert log_has_re(r'DEPRECATED.*precision_filter.*', caplog)
-    assert log_has_re(r'DEPRECATED.*in pairlist is deprecated and must be moved*', caplog)
-
-
 def test_process_deprecated_setting_edge(mocker, edge_conf, caplog):
     patched_configuration_load_config_file(mocker, edge_conf)
     edge_conf.update({'edge': {