adelorenzo/stable
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cleanup based on feedback

Browse Source
This commit is contained in:
matt ferrante 2021-09-22 10:32:30 -06:00
parent 553c868d7f
commit f768bdea50
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
tests/test_freqtradebot.py
View File

@ -3594,19 +3594,13 @@ def test_get_real_amount(
@pytest.mark.parametrize( @pytest.mark.parametrize(
'stake_currency, fee_cost, fee_currency, fee_reduction_amount, expected_fee, expected_log', [ 'stake_currency, fee_cost, fee_currency, fee_reduction_amount, expected_fee, expected_log_amount', [
("BTC", None, None, 0.001, 0.001, ( (None, None, None, 0.001, 0.001, 7.992),
'Applying fee on amount for Trade(id=None, pair=LTC/ETH, amount=8.00000000, ' ("ETH", 0.02, 'BNB', 0.0005, 0.001518575, 7.996),
'open_rate=0.24544100, open_since=closed) (from 8.0 to 7.992).'
)),
("ETH", 0.02, 'BNB', 0.0005, 0.001518575, (
'Applying fee on amount for Trade(id=None, pair=LTC/ETH, amount=8.00000000, '
'open_rate=0.24544100, open_since=closed) (from 8.0 to 7.996).'
)),
]) ])
def test_get_real_amount_multi( def test_get_real_amount_multi(
default_conf, trades_for_order2, buy_order_fee, caplog, fee, mocker, markets, default_conf, trades_for_order2, buy_order_fee, caplog, fee, mocker, markets,
stake_currency, fee_cost, fee_currency, fee_reduction_amount, expected_fee, expected_log, stake_currency, fee_cost, fee_currency, fee_reduction_amount, expected_fee, expected_log_amount,
): ):
trades_for_order = deepcopy(trades_for_order2) trades_for_order = deepcopy(trades_for_order2)
@ -3617,6 +3611,7 @@ def test_get_real_amount_multi(
mocker.patch('freqtrade.exchange.Exchange.get_trades_for_order', return_value=trades_for_order) mocker.patch('freqtrade.exchange.Exchange.get_trades_for_order', return_value=trades_for_order)
amount = float(sum(x['amount'] for x in trades_for_order)) amount = float(sum(x['amount'] for x in trades_for_order))
if stake_currency:
default_conf['stake_currency'] = stake_currency default_conf['stake_currency'] = stake_currency
trade = Trade( trade = Trade(
@ -3639,7 +3634,13 @@ def test_get_real_amount_multi(
# Amount is reduced by "fee" # Amount is reduced by "fee"
expected_amount = amount - (amount * fee_reduction_amount) expected_amount = amount - (amount * fee_reduction_amount)
assert freqtrade.get_real_amount(trade, buy_order_fee) == expected_amount assert freqtrade.get_real_amount(trade, buy_order_fee) == expected_amount
assert log_has(expected_log, caplog) assert log_has(
(
'Applying fee on amount for Trade(id=None, pair=LTC/ETH, amount=8.00000000, '
f'open_rate=0.24544100, open_since=closed) (from 8.0 to {expected_log_amount}).'
),
caplog
)
assert trade.fee_open == expected_fee assert trade.fee_open == expected_fee
assert trade.fee_close == expected_fee assert trade.fee_close == expected_fee