From e4500af736d96a2bae8a2bd9e52035fa81229e46 Mon Sep 17 00:00:00 2001
From: kryofly <kryofly@space>
Date: Sat, 6 Jan 2018 08:27:44 +0100
Subject: [PATCH] test case for common CLI parsing

Rearrange current tests.
---
 freqtrade/tests/test_misc.py | 53 ++++++++++++++++++++++++------------
 1 file changed, 35 insertions(+), 18 deletions(-)

diff --git a/freqtrade/tests/test_misc.py b/freqtrade/tests/test_misc.py
index 8c5cc1b24..3271b1a1e 100644
--- a/freqtrade/tests/test_misc.py
+++ b/freqtrade/tests/test_misc.py
@@ -1,13 +1,15 @@
 # pragma pylint: disable=missing-docstring,C0103
 import json
 import time
+import argparse
 from copy import deepcopy
 from unittest.mock import MagicMock
 
 import pytest
 from jsonschema import ValidationError
 
-from freqtrade.misc import throttle, parse_args, load_config
+from freqtrade.misc import throttle, parse_args, load_config,\
+     parse_args_common
 
 
 def test_throttle():
@@ -38,44 +40,59 @@ def test_throttle_with_assets():
     assert result == -1
 
 
+# Parse common command-line-arguments
+# used for all tools
+
+
+def test_parse_args_none():
+    args = parse_args_common([], '')
+    assert isinstance(args, argparse.ArgumentParser)
+
+
 def test_parse_args_defaults():
     args = parse_args([], '')
-    assert args is not None
     assert args.config == 'config.json'
     assert args.dynamic_whitelist is None
     assert args.loglevel == 20
 
 
+def test_parse_args_config():
+    args = parse_args(['-c', '/dev/null'], '')
+    assert args.config == '/dev/null'
+
+    args = parse_args(['--config', '/dev/null'], '')
+    assert args.config == '/dev/null'
+
+
+def test_parse_args_verbose():
+    args = parse_args(['-v'], '')
+    assert args.loglevel == 10
+
+    args = parse_args(['--verbose'], '')
+    assert args.loglevel == 10
+
+
+def test_parse_args_version():
+    with pytest.raises(SystemExit, match=r'0'):
+        parse_args(['--version'], '')
+
+
 def test_parse_args_invalid():
     with pytest.raises(SystemExit, match=r'2'):
         parse_args(['-c'], '')
 
 
-def test_parse_args_config():
-    args = parse_args(['-c', '/dev/null'], '')
-    assert args is not None
-    assert args.config == '/dev/null'
-
-    args = parse_args(['--config', '/dev/null'], '')
-    assert args is not None
-    assert args.config == '/dev/null'
-
-
-def test_parse_args_verbose():
-    args = parse_args(['-v'], '')
-    assert args is not None
-    assert args.loglevel == 10
+# Parse command-line-arguments
+# used for main, backtesting and hyperopt
 
 
 def test_parse_args_dynamic_whitelist():
     args = parse_args(['--dynamic-whitelist'], '')
-    assert args is not None
     assert args.dynamic_whitelist is 20
 
 
 def test_parse_args_dynamic_whitelist_10():
     args = parse_args(['--dynamic-whitelist', '10'], '')
-    assert args is not None
     assert args.dynamic_whitelist is 10