From d7903f012f7af5f3c19df527780456bab0ca986f Mon Sep 17 00:00:00 2001
From: Matthias <xmatthias@outlook.com>
Date: Thu, 23 Sep 2021 07:25:11 +0200
Subject: [PATCH] Move PerformanceWarning to advanced section

rewrite to use strategy parameters instead of plain range
---
 docs/strategy-advanced.md      | 30 ++++++++++++++++++++++++++++++
 docs/strategy-customization.md | 27 ---------------------------
 2 files changed, 30 insertions(+), 27 deletions(-)

diff --git a/docs/strategy-advanced.md b/docs/strategy-advanced.md
index 4409af6ea..d7d0dd04a 100644
--- a/docs/strategy-advanced.md
+++ b/docs/strategy-advanced.md
@@ -695,3 +695,33 @@ The variable 'content', will contain the strategy file in a BASE64 encoded form.
 ```
 
 Please ensure that 'NameOfStrategy' is identical to the strategy name!
+
+## Performance warning
+
+When executing a strategy, one can sometimes be greeted by the following in the logs
+
+> PerformanceWarning: DataFrame is highly fragmented.
+
+This is a warning from [`pandas`](https://github.com/pandas-dev/pandas) and as the warning continues to say:
+use `pd.concat(axis=1)`.
+This can have slight performance implications, which are usually only visible during hyperopt (when optimizing an indicator).
+
+For example:
+
+```python
+for val in self.buy_ema_short.range:
+    dataframe[f'ema_short_{val}'] = ta.EMA(dataframe, timeperiod=val)
+```
+
+should be rewritten to
+
+```python
+frames = [dataframe]
+for val in self.buy_ema_short.range:
+    frames.append({
+        f'ema_short_{val}': ta.EMA(dataframe, timeperiod=val)
+    })
+
+# Append columns to existing dataframe
+merged_frame = pd.concat(frames, axis=1)
+```
diff --git a/docs/strategy-customization.md b/docs/strategy-customization.md
index 194517b2b..6d6eff2aa 100644
--- a/docs/strategy-customization.md
+++ b/docs/strategy-customization.md
@@ -793,33 +793,6 @@ The following lists some common patterns which should be avoided to prevent frus
 - don't use `dataframe['volume'].mean()`. This uses the full DataFrame for backtesting, including data from the future. Use `dataframe['volume'].rolling(<window>).mean()` instead
 - don't use `.resample('1h')`. This uses the left border of the interval, so moves data from an hour to the start of the hour. Use `.resample('1h', label='right')` instead.
 
-### Performance warning
-
-When executing a strategy, one can sometimes be greeted by the following in the logs
-
-> PerformanceWarning: DataFrame is highly fragmented.
-
-This is a warning from [`pandas`](https://github.com/pandas-dev/pandas) and as the warning continues to say:
- use `pd.concat(axis=1)`. For example
-
-```python
-for i in range(100):
-   dataframe[i] = ta.indicator(dataframe, param=i)
-```
-
-should be rewritten to
-
-```python
-frames = [dataframe]
-for i in range(100):
-    frames.append({
-        str(i): ta.indicator(dataframe, param=i)
-    })
-
-# Append columns to existing dataframe
-merged_frame = pd.concat(frames, axis=1)
-```
-
 ## Further strategy ideas
 
 To get additional Ideas for strategies, head over to our [strategy repository](https://github.com/freqtrade/freqtrade-strategies). Feel free to use them as they are - but results will depend on the current market situation, pairs used etc. - therefore please backtest the strategy for your exchange/desired pairs first, evaluate carefully, use at your own risk.