From b41c2344405c438eb3f81e60eb8eeb3cef1510ad Mon Sep 17 00:00:00 2001
From: Matthias <xmatthias@outlook.com>
Date: Sat, 10 Jul 2021 12:18:55 +0200
Subject: [PATCH] Extract Closed profit calculation to trade object

---
 freqtrade/persistence/models.py | 13 +++++++++++++
 freqtrade/wallets.py            |  4 +---
 tests/test_persistence.py       | 16 ++++++++++++++++
 3 files changed, 30 insertions(+), 3 deletions(-)

diff --git a/freqtrade/persistence/models.py b/freqtrade/persistence/models.py
index b4c299120..8dcfc6c94 100644
--- a/freqtrade/persistence/models.py
+++ b/freqtrade/persistence/models.py
@@ -801,6 +801,19 @@ class Trade(_DECL_BASE, LocalTrade):
                                  Trade.is_open.is_(False),
                                  ]).all()
 
+    @staticmethod
+    def get_total_closed_profit() -> float:
+        """
+        Retrieves total realized profit
+        """
+        if Trade.use_db:
+            total_profit = Trade.query.with_entities(
+                func.sum(Trade.close_profit_abs)).filter(Trade.is_open.is_(False)).scalar()
+        else:
+            total_profit = sum(
+                t.close_profit_abs for t in LocalTrade.get_trades_proxy(is_open=False))
+        return total_profit or 0
+
     @staticmethod
     def total_open_trades_stakes() -> float:
         """
diff --git a/freqtrade/wallets.py b/freqtrade/wallets.py
index ece496c90..3d80cc892 100644
--- a/freqtrade/wallets.py
+++ b/freqtrade/wallets.py
@@ -70,9 +70,7 @@ class Wallets:
         # If not backtesting...
         # TODO: potentially remove the ._log workaround to determine backtest mode.
         if self._log:
-            closed_trades = Trade.get_trades_proxy(is_open=False)
-            tot_profit = sum(
-                [trade.close_profit_abs for trade in closed_trades if trade.close_profit_abs])
+            tot_profit = Trade.get_total_closed_profit()
         else:
             tot_profit = LocalTrade.total_profit
         tot_in_trades = sum([trade.stake_amount for trade in open_trades])
diff --git a/tests/test_persistence.py b/tests/test_persistence.py
index 1576aaa5a..89d07ca74 100644
--- a/tests/test_persistence.py
+++ b/tests/test_persistence.py
@@ -1124,6 +1124,21 @@ def test_total_open_trades_stakes(fee, use_db):
     Trade.use_db = True
 
 
+@pytest.mark.usefixtures("init_persistence")
+@pytest.mark.parametrize('use_db', [True, False])
+def test_get_total_closed_profit(fee, use_db):
+
+    Trade.use_db = use_db
+    Trade.reset_trades()
+    res = Trade.get_total_closed_profit()
+    assert res == 0
+    create_mock_trades(fee, use_db)
+    res = Trade.get_total_closed_profit()
+    assert res == 0.000739127
+
+    Trade.use_db = True
+
+
 @pytest.mark.usefixtures("init_persistence")
 @pytest.mark.parametrize('use_db', [True, False])
 def test_get_trades_proxy(fee, use_db):
@@ -1298,6 +1313,7 @@ def test_Trade_object_idem():
         'open_date',
         'get_best_pair',
         'get_overall_performance',
+        'get_total_closed_profit',
         'total_open_trades_stakes',
         'get_sold_trades_without_assigned_fees',
         'get_open_trades_without_assigned_fees',