Merge branch 'develop' into feat/backtest_detail

freqtrade/optimize/hyperopt.py

@@ -107,13 +107,25 @@ class Hyperopt:
             # Populate "fallback" functions here
             # (hasattr is slow so should not be run during "regular" operations)
             if hasattr(self.custom_hyperopt, 'populate_indicators'):
-                self.backtesting.strategy.advise_indicators = (  # type: ignore
+                logger.warning(
+                    "DEPRECATED: Using `populate_indicators()` in the hyperopt file is deprecated. "
+                    "Please move these methods to your strategy."
+                    )
+                self.backtesting.strategy.populate_indicators = (  # type: ignore
                     self.custom_hyperopt.populate_indicators)  # type: ignore
             if hasattr(self.custom_hyperopt, 'populate_buy_trend'):
-                self.backtesting.strategy.advise_buy = (  # type: ignore
+                logger.warning(
+                    "DEPRECATED: Using `populate_buy_trend()` in the hyperopt file is deprecated. "
+                    "Please move these methods to your strategy."
+                )
+                self.backtesting.strategy.populate_buy_trend = (  # type: ignore
                     self.custom_hyperopt.populate_buy_trend)  # type: ignore
             if hasattr(self.custom_hyperopt, 'populate_sell_trend'):
-                self.backtesting.strategy.advise_sell = (  # type: ignore
+                logger.warning(
+                    "DEPRECATED: Using `populate_sell_trend()` in the hyperopt file is deprecated. "
+                    "Please move these methods to your strategy."
+                )
+                self.backtesting.strategy.populate_sell_trend = (  # type: ignore
                     self.custom_hyperopt.populate_sell_trend)  # type: ignore
 
         # Use max_open_trades for hyperopt as well, except --disable-max-market-positions is set

freqtrade/optimize/hyperopt_auto.py

@@ -74,7 +74,7 @@ class HyperOptAuto(IHyperOpt):
         return self._get_indicator_space('sell', 'sell_indicator_space')
 
     def protection_space(self) -> List['Dimension']:
-        return self._get_indicator_space('protection', 'indicator_space')
+        return self._get_indicator_space('protection', 'protection_space')
 
     def generate_roi_table(self, params: Dict) -> Dict[int, float]:
         return self._get_func('generate_roi_table')(params)