Update custom_sell to custom_exit

tests/strategy/strats/broken_strats/broken_futures_strategies.py

@@ -1,4 +1,9 @@
-# The strategy which fails to load due to non-existent dependency
+"""
+The strategies here are minimal strategies designed to fail loading in certain conditions.
+They are not operational, and don't aim to be.
+"""
+
+from datetime import datetime
 
 from pandas import DataFrame
 
@@ -14,3 +19,13 @@ class TestStrategyNoImplements(IStrategy):
 class TestStrategyNoImplementSell(TestStrategyNoImplements):
     def populate_entry_trend(self, dataframe: DataFrame, metadata: dict) -> DataFrame:
         return super().populate_entry_trend(dataframe, metadata)
+
+
+class TestStrategyImplementCustomSell(TestStrategyNoImplementSell):
+    def populate_exit_trend(self, dataframe: DataFrame, metadata: dict) -> DataFrame:
+        return super().populate_exit_trend(dataframe, metadata)
+
+    def custom_sell(self, pair: str, trade, current_time: datetime,
+                    current_rate: float, current_profit: float,
+                    **kwargs):
+        return False

tests/strategy/test_interface.py

@@ -477,7 +477,7 @@ def test_stop_loss_reached(default_conf, fee, profit, adjusted, expected, traili
     strategy.custom_stoploss = original_stopvalue
 
 
-def test_custom_sell(default_conf, fee, caplog) -> None:
+def test_custom_exit(default_conf, fee, caplog) -> None:
 
     strategy = StrategyResolver.load_strategy(default_conf)
     trade = Trade(
@@ -499,7 +499,7 @@ def test_custom_sell(default_conf, fee, caplog) -> None:
     assert res.sell_flag is False
     assert res.sell_type == SellType.NONE
 
-    strategy.custom_sell = MagicMock(return_value=True)
+    strategy.custom_exit = MagicMock(return_value=True)
     res = strategy.should_exit(trade, 1, now,
                                enter=False, exit_=False,
                                low=None, high=None)
@@ -507,7 +507,7 @@ def test_custom_sell(default_conf, fee, caplog) -> None:
     assert res.sell_type == SellType.CUSTOM_SELL
     assert res.sell_reason == 'custom_sell'
 
-    strategy.custom_sell = MagicMock(return_value='hello world')
+    strategy.custom_exit = MagicMock(return_value='hello world')
 
     res = strategy.should_exit(trade, 1, now,
                                enter=False, exit_=False,
@@ -517,14 +517,14 @@ def test_custom_sell(default_conf, fee, caplog) -> None:
     assert res.sell_reason == 'hello world'
 
     caplog.clear()
-    strategy.custom_sell = MagicMock(return_value='h' * 100)
+    strategy.custom_exit = MagicMock(return_value='h' * 100)
     res = strategy.should_exit(trade, 1, now,
                                enter=False, exit_=False,
                                low=None, high=None)
     assert res.sell_type == SellType.CUSTOM_SELL
     assert res.sell_flag is True
     assert res.sell_reason == 'h' * 64
-    assert log_has_re('Custom sell reason returned from custom_sell is too long.*', caplog)
+    assert log_has_re('Custom sell reason returned from custom_exit is too long.*', caplog)
 
 
 @pytest.mark.parametrize('side', TRADE_SIDES)

tests/strategy/test_strategy_loading.py

@@ -392,7 +392,7 @@ def test_deprecate_populate_indicators(result, default_conf):
 
 
 @pytest.mark.filterwarnings("ignore:deprecated")
-def test_missing_implements(result, default_conf):
+def test_missing_implements(default_conf):
     default_location = Path(__file__).parent / "strats/broken_strats"
     default_conf.update({'strategy': 'TestStrategyNoImplements',
                          'strategy_path': default_location})
@@ -406,6 +406,7 @@ def test_missing_implements(result, default_conf):
                        match=r"`populate_exit_trend` or `populate_sell_trend`.*"):
         StrategyResolver.load_strategy(default_conf)
 
+    # Futures mode is more strict ...
     default_conf['trading_mode'] = 'futures'
 
     with pytest.raises(OperationalException,
@@ -417,6 +418,12 @@ def test_missing_implements(result, default_conf):
                        match=r"`populate_entry_trend` must be implemented.*"):
         StrategyResolver.load_strategy(default_conf)
 
+    default_conf['strategy'] = 'TestStrategyImplementCustomSell'
+
+    with pytest.raises(OperationalException,
+                       match=r"Please migrate your implementation of `custom_sell`.*"):
+        StrategyResolver.load_strategy(default_conf)
+
 
 @pytest.mark.filterwarnings("ignore:deprecated")
 def test_call_deprecated_function(result, default_conf, caplog):