define common fixtures

freqtrade/tests/test_main.py

@@ -1,71 +1,25 @@
 # pragma pylint: disable=missing-docstring
 import copy
-from datetime import datetime
 from unittest.mock import MagicMock, call
 
-import pytest
-from jsonschema import validate
-
 from freqtrade.exchange import Exchanges
 from freqtrade.main import create_trade, handle_trade, close_trade_if_fulfilled, init, \
     get_target_bid
-from freqtrade.misc import CONF_SCHEMA
 from freqtrade.persistence import Trade
 
 
-@pytest.fixture
-def conf():
-    configuration = {
-        "max_open_trades": 3,
-        "stake_currency": "BTC",
-        "stake_amount": 0.05,
-        "dry_run": True,
-        "minimal_roi": {
-            "2880": 0.005,
-            "720": 0.01,
-            "0": 0.02
-        },
-        "bid_strategy": {
-            "ask_last_balance": 0.0
-        },
-        "exchange": {
-            "name": "bittrex",
-            "enabled": True,
-            "key": "key",
-            "secret": "secret",
-            "pair_whitelist": [
-                "BTC_ETH",
-                "BTC_TKN",
-                "BTC_TRST",
-                "BTC_SWT",
-            ]
-        },
-        "telegram": {
-            "enabled": True,
-            "token": "token",
-            "chat_id": "chat_id"
-        }
-    }
-    validate(configuration, CONF_SCHEMA)
-    return configuration
-
-
-def test_create_trade(conf, mocker):
-    mocker.patch.dict('freqtrade.main._CONF', conf)
+def test_create_trade(default_conf, ticker, limit_buy_order, mocker):
+    mocker.patch.dict('freqtrade.main._CONF', default_conf)
     buy_signal = mocker.patch('freqtrade.main.get_buy_signal', side_effect=lambda _: True)
     mocker.patch.multiple('freqtrade.main.telegram', init=MagicMock(), send_msg=MagicMock())
     mocker.patch.multiple('freqtrade.main.exchange',
                           validate_pairs=MagicMock(),
-                          get_ticker=MagicMock(return_value={
-                              'bid': 0.07256061,
-                              'ask': 0.072661,
-                              'last': 0.07256061
-                          }),
+                          get_ticker=ticker,
                           buy=MagicMock(return_value='mocked_limit_buy'))
     # Save state of current whitelist
-    whitelist = copy.deepcopy(conf['exchange']['pair_whitelist'])
+    whitelist = copy.deepcopy(default_conf['exchange']['pair_whitelist'])
 
-    init(conf, 'sqlite://')
+    init(default_conf, 'sqlite://')
     for _ in ['BTC_ETH', 'BTC_TKN', 'BTC_TRST', 'BTC_SWT']:
         trade = create_trade(15.0)
         Trade.session.add(trade)
@@ -77,29 +31,20 @@ def test_create_trade(conf, mocker):
         assert trade.exchange == Exchanges.BITTREX.name
 
         # Simulate fulfilled LIMIT_BUY order for trade
-        trade.update({
-            'id': 'mocked_limit_buy',
-            'type': 'LIMIT_BUY',
-            'pair': 'mocked',
-            'opened': datetime.utcnow(),
-            'rate': 0.072661,
-            'amount': 206.43811673387373,
-            'remaining': 0.0,
-            'closed': datetime.utcnow(),
-        })
+        trade.update(limit_buy_order)
 
-        assert trade.open_rate == 0.072661
+        assert trade.open_rate == 0.07256061
         assert trade.amount == 206.43811673387373
 
-        assert whitelist == conf['exchange']['pair_whitelist']
+        assert whitelist == default_conf['exchange']['pair_whitelist']
 
     buy_signal.assert_has_calls(
         [call('BTC_ETH'), call('BTC_TKN'), call('BTC_TRST'), call('BTC_SWT')]
     )
 
 
-def test_handle_trade(conf, mocker):
-    mocker.patch.dict('freqtrade.main._CONF', conf)
+def test_handle_trade(default_conf, limit_sell_order, mocker):
+    mocker.patch.dict('freqtrade.main._CONF', default_conf)
     mocker.patch.multiple('freqtrade.main.telegram', init=MagicMock(), send_msg=MagicMock())
     mocker.patch.multiple('freqtrade.main.exchange',
                           validate_pairs=MagicMock(),
@@ -116,24 +61,15 @@ def test_handle_trade(conf, mocker):
     assert trade.open_order_id == 'mocked_limit_sell'
 
     # Simulate fulfilled LIMIT_SELL order for trade
-    trade.update({
-        'id': 'mocked_sell_limit',
-        'type': 'LIMIT_SELL',
-        'pair': 'mocked',
-        'opened': datetime.utcnow(),
-        'rate': 0.17256061,
-        'amount': 206.43811673387373,
-        'remaining': 0.0,
-        'closed': datetime.utcnow(),
-    })
+    trade.update(limit_sell_order)
 
-    assert trade.close_rate == 0.17256061
-    assert trade.close_profit == 1.3698725
+    assert trade.close_rate == 0.0802134
+    assert trade.close_profit == 0.10046755
     assert trade.close_date is not None
 
 
-def test_close_trade(conf, mocker):
-    mocker.patch.dict('freqtrade.main._CONF', conf)
+def test_close_trade(default_conf, mocker):
+    mocker.patch.dict('freqtrade.main._CONF', default_conf)
     trade = Trade.query.filter(Trade.is_open.is_(True)).first()
     assert trade
 
@@ -155,6 +91,6 @@ def test_balance_fully_last_side(mocker):
     assert get_target_bid({'ask': 20, 'last': 10}) == 10
 
 
-def test_balance_when_last_bigger_than_ask(mocker):
+def test_balance_bigger_last_ask(mocker):
     mocker.patch.dict('freqtrade.main._CONF', {'bid_strategy': {'ask_last_balance': 1.0}})
     assert get_target_bid({'ask': 5, 'last': 10}) == 5