Deleting must delete orders first

freqtrade/freqtradebot.py

@@ -1118,8 +1118,7 @@ class FreqtradeBot:
         if isclose(filled_amount, 0.0, abs_tol=constants.MATH_CLOSE_PREC):
             logger.info('Buy order fully cancelled. Removing %s from database.', trade)
             # if trade is not partially completed, just delete the trade
-            Trade.session.delete(trade)
+            trade.delete()
-            Trade.session.flush()
             was_trade_fully_canceled = True
         else:
             # if trade is partially complete, edit the stake details for the trade

freqtrade/persistence/models.py

@@ -446,6 +446,14 @@ class Trade(_DECL_BASE):
     def update_order(self, order: Dict) -> None:
         Order.update_orders(self.orders, order)
 
+    def delete(self) -> None:
+
+        for order in self.orders:
+            Order.session.delete(order)
+
+        Trade.session.delete(self)
+        Trade.session.flush()
+
     def _calc_open_trade_price(self) -> float:
         """
         Calculate the open_rate including open_fee.

freqtrade/rpc/rpc.py

@@ -567,8 +567,7 @@ class RPC:
                 except (ExchangeError):
                     pass
 
-            Trade.session.delete(trade)
+            trade.delete()
-            Trade.session.flush()
             self._freqtrade.wallets.update()
             return {
                 'result': 'success',

tests/rpc/test_rpc.py

@@ -313,7 +313,6 @@ def test_rpc_delete_trade(mocker, default_conf, fee, markets, caplog):
     with pytest.raises(RPCException, match='invalid argument'):
         rpc._rpc_delete('200')
 
-    create_mock_trades(fee)
     trades = Trade.query.all()
     trades[1].stoploss_order_id = '1234'
     trades[2].stoploss_order_id = '1234'

tests/test_persistence.py

@@ -1074,6 +1074,3 @@ def test_update_order_from_ccxt():
     assert o.remaining == 0.0
     assert not o.ft_is_open
     assert o.order_filled_date is not None
-
-
-