From 9cbf8c5f008520b99016a7a63fe299b4b0dcb821 Mon Sep 17 00:00:00 2001
From: hroff-1902 <hroff_raeyd9tzpttf@mail.ru>
Date: Fri, 14 Feb 2020 21:15:36 +0300
Subject: [PATCH] Add status for listed strategies

---
 freqtrade/commands/list_commands.py | 11 +++++++++--
 freqtrade/resolvers/iresolver.py    | 20 +++++++++++++++-----
 2 files changed, 24 insertions(+), 7 deletions(-)

diff --git a/freqtrade/commands/list_commands.py b/freqtrade/commands/list_commands.py
index f2b6bf995..b6ff682e6 100644
--- a/freqtrade/commands/list_commands.py
+++ b/freqtrade/commands/list_commands.py
@@ -43,10 +43,17 @@ def start_list_strategies(args: Dict[str, Any]) -> None:
     config = setup_utils_configuration(args, RunMode.UTIL_NO_EXCHANGE)
 
     directory = Path(config.get('strategy_path', config['user_data_dir'] / USERPATH_STRATEGIES))
-    strategies = StrategyResolver.search_all_objects(directory)
+    strategies = StrategyResolver.search_all_objects(directory, not args['print_one_column'])
     # Sort alphabetically
     strategies = sorted(strategies, key=lambda x: x['name'])
-    strats_to_print = [{'name': s['name'], 'location': s['location'].name} for s in strategies]
+    names = [s['name'] for s in strategies]
+    strats_to_print = [{
+        'name': s['name'] if s['name'] else "--",
+        'location': s['location'].name,
+        'status': ("LOAD FAILED" if s['class'] is None
+                   else "OK" if names.count(s['name']) == 1
+                   else "DUPLICATED NAME")
+    } for s in strategies]
 
     if args['print_one_column']:
         print('\n'.join([s['name'] for s in strategies]))
diff --git a/freqtrade/resolvers/iresolver.py b/freqtrade/resolvers/iresolver.py
index a75c45933..8b5aa1dff 100644
--- a/freqtrade/resolvers/iresolver.py
+++ b/freqtrade/resolvers/iresolver.py
@@ -41,11 +41,15 @@ class IResolver:
 
     @classmethod
     def _get_valid_object(cls, module_path: Path,
-                          object_name: Optional[str]) -> Generator[Any, None, None]:
+                          object_name: Optional[str],
+                          enum_failed: bool = False) -> Union[Generator[Any, None, None],
+                                                              Tuple[None]]:
         """
         Generator returning objects with matching object_type and object_name in the path given.
         :param module_path: absolute path to the module
         :param object_name: Class name of the object
+        :param enum_failed: If True, will return None for modules which fail.
+            Otherwise, failing modules are skipped.
         :return: generator containing matching objects
         """
 
@@ -58,6 +62,8 @@ class IResolver:
         except (ModuleNotFoundError, SyntaxError) as err:
             # Catch errors in case a specific module is not installed
             logger.warning(f"Could not import {module_path} due to '{err}'")
+            if enum_failed:
+                return (None, )
 
         valid_objects_gen = (
             obj for name, obj in inspect.getmembers(module, inspect.isclass)
@@ -136,10 +142,13 @@ class IResolver:
         )
 
     @classmethod
-    def search_all_objects(cls, directory: Path) -> List[Dict[str, Any]]:
+    def search_all_objects(cls, directory: Path,
+                           enum_failed: bool) -> List[Dict[str, Any]]:
         """
         Searches a directory for valid objects
         :param directory: Path to search
+        :param enum_failed: If True, will return None for modules which fail.
+            Otherwise, failing modules are skipped.
         :return: List of dicts containing 'name', 'class' and 'location' entires
         """
         logger.debug(f"Searching for {cls.object_type.__name__} '{directory}'")
@@ -151,10 +160,11 @@ class IResolver:
                 continue
             module_path = entry.resolve()
             logger.debug(f"Path {module_path}")
-            for obj in cls._get_valid_object(module_path, object_name=None):
+            for obj in cls._get_valid_object(module_path, object_name=None,
+                                             enum_failed=enum_failed):
                 objects.append(
-                    {'name': obj.__name__,
-                     'class': obj,
+                    {'name': obj.__name__ if obj is not None else '',
+                     'class': obj if obj is not None else None,
                      'location': entry,
                      })
         return objects