From 966c6b308f182392c85a74568350de4ac5cd9ced Mon Sep 17 00:00:00 2001
From: Leif Segen <leif.nabil.segen@gmail.com>
Date: Sat, 28 Nov 2020 01:34:18 -0600
Subject: [PATCH] Satisfy linter.

---
 freqtrade/pairlist/PerformanceFilter.py |  6 +--
 tests/pairlist/test_pairlist.py         | 51 +++++++++++++------------
 2 files changed, 30 insertions(+), 27 deletions(-)

diff --git a/freqtrade/pairlist/PerformanceFilter.py b/freqtrade/pairlist/PerformanceFilter.py
index b2889dc6b..099b8d271 100644
--- a/freqtrade/pairlist/PerformanceFilter.py
+++ b/freqtrade/pairlist/PerformanceFilter.py
@@ -12,6 +12,7 @@ from freqtrade.persistence import Trade
 
 logger = logging.getLogger(__name__)
 
+
 class PerformanceFilter(IPairList):
 
     def __init__(self, exchange, pairlistmanager,
@@ -19,7 +20,6 @@ class PerformanceFilter(IPairList):
                  pairlist_pos: int) -> None:
         super().__init__(exchange, pairlistmanager, config, pairlistconfig, pairlist_pos)
 
-
     @property
     def needstickers(self) -> bool:
         """
@@ -46,11 +46,11 @@ class PerformanceFilter(IPairList):
         # Get the trading performance for pairs from database
         perf = pd.DataFrame(Trade.get_overall_performance())
         # get pairlist from performance dataframe values
-        list_df = pd.DataFrame({'pair':pairlist})
+        list_df = pd.DataFrame({'pair': pairlist})
         # set initial value for pairs with no trades to 0
         # and sort the list using performance and count
         sorted_df = list_df.join(perf.set_index('pair'), on='pair')\
             .fillna(0).sort_values(by=['profit', 'count'], ascending=False)
         pairlist = sorted_df['pair'].tolist()
 
-        return pairlist
\ No newline at end of file
+        return pairlist
diff --git a/tests/pairlist/test_pairlist.py b/tests/pairlist/test_pairlist.py
index 65a0fa835..9e2bab12c 100644
--- a/tests/pairlist/test_pairlist.py
+++ b/tests/pairlist/test_pairlist.py
@@ -729,27 +729,32 @@ def test_pairlistmanager_no_pairlist(mocker, whitelist_conf):
 
 @pytest.mark.parametrize("pairlists,pair_allowlist,overall_performance,allowlist_result", [
     # Happy path, descending order, all values filled
-    ([{"method": "StaticPairList"},{"method": "PerformanceFilter"}],
-    ['ETH/BTC','TKN/BTC'],
-    [{'pair':'TKN/BTC','profit':5,'count':3}, {'pair':'ETH/BTC','profit':4,'count':2}],
-    ['TKN/BTC','ETH/BTC']),
+    ([{"method": "StaticPairList"}, {"method": "PerformanceFilter"}],
+     ['ETH/BTC', 'TKN/BTC'],
+     [{'pair': 'TKN/BTC', 'profit': 5, 'count': 3}, {'pair': 'ETH/BTC', 'profit': 4, 'count': 2}],
+     ['TKN/BTC', 'ETH/BTC']),
     # Performance data outside allow list ignored
-    ([{"method": "StaticPairList"},{"method": "PerformanceFilter"}],
-    ['ETH/BTC','TKN/BTC'],
-    [{'pair':'OTHER/BTC','profit':5,'count':3}, {'pair':'ETH/BTC','profit':4,'count':2}],
-    ['ETH/BTC','TKN/BTC']),
+    ([{"method": "StaticPairList"}, {"method": "PerformanceFilter"}],
+     ['ETH/BTC', 'TKN/BTC'],
+     [{'pair': 'OTHER/BTC', 'profit': 5, 'count': 3}, 
+      {'pair': 'ETH/BTC', 'profit': 4, 'count': 2}],
+     ['ETH/BTC', 'TKN/BTC']),
     # Partial performance data missing and sorted between positive and negative profit
-    ([{"method": "StaticPairList"},{"method": "PerformanceFilter"}],
-    ['ETH/BTC','TKN/BTC','LTC/BTC'],
-    [{'pair':'ETH/BTC','profit':-5,'count':100}, {'pair':'TKN/BTC','profit':4,'count':2}],
-    ['TKN/BTC','LTC/BTC','ETH/BTC']),
+    ([{"method": "StaticPairList"}, {"method": "PerformanceFilter"}],
+     ['ETH/BTC', 'TKN/BTC', 'LTC/BTC'],
+     [{'pair': 'ETH/BTC', 'profit': -5, 'count': 100},
+      {'pair': 'TKN/BTC', 'profit': 4, 'count': 2}],
+     ['TKN/BTC', 'LTC/BTC', 'ETH/BTC']),
     # Tie in performance data broken by count
-    ([{"method": "StaticPairList"},{"method": "PerformanceFilter"}],
-    ['ETH/BTC','TKN/BTC','LTC/BTC'],
-    [{'pair':'LTC/BTC','profit':-5,'count':101}, {'pair':'TKN/BTC','profit':-5,'count':2}, {'pair':'ETH/BTC','profit':-5,'count':100}, ],
-    ['LTC/BTC','ETH/BTC','TKN/BTC']),
+    ([{"method": "StaticPairList"}, {"method": "PerformanceFilter"}],
+     ['ETH/BTC', 'TKN/BTC', 'LTC/BTC'],
+     [{'pair': 'LTC/BTC', 'profit': -5, 'count': 101},
+      {'pair': 'TKN/BTC', 'profit': -5, 'count': 2},
+      {'pair': 'ETH/BTC', 'profit': -5, 'count': 100}],
+     ['LTC/BTC', 'ETH/BTC', 'TKN/BTC']),
 ])
-def test_performance_filter(mocker, whitelist_conf, pairlists, pair_allowlist, overall_performance, allowlist_result, tickers, markets, ohlcv_history_list):
+def test_performance_filter(mocker, whitelist_conf, pairlists, pair_allowlist, overall_performance,
+                            allowlist_result, tickers, markets, ohlcv_history_list):
     allowlist_conf = whitelist_conf
     allowlist_conf['pairlists'] = pairlists
     allowlist_conf['exchange']['pair_whitelist'] = pair_allowlist
@@ -761,14 +766,12 @@ def test_performance_filter(mocker, whitelist_conf, pairlists, pair_allowlist, o
                           get_tickers=tickers,
                           markets=PropertyMock(return_value=markets)
                           )
-    mocker.patch.multiple(
-        'freqtrade.exchange.Exchange',
-        get_historic_ohlcv=MagicMock(return_value=ohlcv_history_list),
-    )
-    
+    mocker.patch.multiple('freqtrade.exchange.Exchange',
+                          get_historic_ohlcv=MagicMock(return_value=ohlcv_history_list),
+                          )    
     mocker.patch.multiple('freqtrade.persistence.Trade',
-        get_overall_performance=MagicMock(return_value=overall_performance),
-    )
+                          get_overall_performance=MagicMock(return_value=overall_performance),
+                          )
     freqtrade.pairlists.refresh_pairlist()
     allowlist = freqtrade.pairlists.whitelist
     assert allowlist == allowlist_result