adelorenzo/stable
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert --clean argument to --continue

Browse Source
This commit is contained in:
Matthias 2019-07-16 05:50:27 +02:00
parent c4e55d78d5
commit 7d62bb8c53
4 changed files with 32 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
freqtrade/configuration/arguments.py
View File

@ -223,10 +223,10 @@ AVAILABLE_CLI_OPTIONS = {
metavar='INT', metavar='INT',
default=1, default=1,
), ),
"hyperopt_clean_state": Arg( "hyperopt_continue": Arg(
"--clean", "--continue",
help="Remove temporary hyperopt files (should be used when the custom hyperopt file " help="Continue hyperopt from previous runs. "
"was changed, or when changing the arguments for --min-trades or spaces.", "By default, temporary files will be removed and hyperopt will start from scratch.",
default=False, default=False,
action='store_true', action='store_true',
), ),
@ -325,7 +325,7 @@ ARGS_BACKTEST = ARGS_COMMON_OPTIMIZE + ["position_stacking", "use_max_market_pos
ARGS_HYPEROPT = ARGS_COMMON_OPTIMIZE + ["hyperopt", "position_stacking", "epochs", "spaces", ARGS_HYPEROPT = ARGS_COMMON_OPTIMIZE + ["hyperopt", "position_stacking", "epochs", "spaces",
"use_max_market_positions", "print_all", "hyperopt_jobs", "use_max_market_positions", "print_all", "hyperopt_jobs",
"hyperopt_random_state", "hyperopt_min_trades", "hyperopt_random_state", "hyperopt_min_trades",
"hyperopt_clean_state", "loss_function"] "hyperopt_continue", "loss_function"]
ARGS_EDGE = ARGS_COMMON_OPTIMIZE + ["stoploss_range"] ARGS_EDGE = ARGS_COMMON_OPTIMIZE + ["stoploss_range"]

4
freqtrade/configuration/configuration.py
View File

@ -285,8 +285,8 @@ class Configuration(object):
self._args_to_config(config, argname='hyperopt_min_trades', self._args_to_config(config, argname='hyperopt_min_trades',
logstring='Parameter --min-trades detected: {}') logstring='Parameter --min-trades detected: {}')
self._args_to_config(config, argname='hyperopt_clean_state', self._args_to_config(config, argname='hyperopt_continue',
logstring='Removing hyperopt temp files') logstring='Hyperopt continue: {}')
self._args_to_config(config, argname='loss_function', self._args_to_config(config, argname='loss_function',
logstring='Using loss function: {}') logstring='Using loss function: {}')

8
freqtrade/optimize/hyperopt.py
View File

@ -65,8 +65,11 @@ class Hyperopt(Backtesting):
# Note, this is ratio. 3.85 stated above means 385Σ%. # Note, this is ratio. 3.85 stated above means 385Σ%.
self.expected_max_profit = 3.0 self.expected_max_profit = 3.0
if self.config.get('hyperopt_clean_state'): if not self.config.get('hyperopt_continue'):
self.clean_hyperopt() self.clean_hyperopt()
else:
logger.info("Continuing on previous hyperopt results.")
# Previous evaluations # Previous evaluations
self.trials_file = TRIALSDATA_PICKLE self.trials_file = TRIALSDATA_PICKLE
self.trials: List = [] self.trials: List = []
@ -99,6 +102,7 @@ class Hyperopt(Backtesting):
else: else:
logger.debug('Ignoring max_open_trades (--disable-max-market-positions was used) ...') logger.debug('Ignoring max_open_trades (--disable-max-market-positions was used) ...')
self.max_open_trades = 0 self.max_open_trades = 0
self.position_stacking = self.config.get('position_stacking', False),
def clean_hyperopt(self): def clean_hyperopt(self):
""" """
@ -231,7 +235,7 @@ class Hyperopt(Backtesting):
'stake_amount': self.config['stake_amount'], 'stake_amount': self.config['stake_amount'],
'processed': processed, 'processed': processed,
'max_open_trades': self.max_open_trades, 'max_open_trades': self.max_open_trades,
'position_stacking': self.config.get('position_stacking', False), 'position_stacking': self.position_stacking,
'start_date': min_date, 'start_date': min_date,
'end_date': max_date, 'end_date': max_date,
} }

21
freqtrade/tests/optimize/test_hyperopt.py
View File

@ -418,6 +418,7 @@ def test_start_calls_optimizer(mocker, default_conf, caplog) -> None:
assert hasattr(hyperopt, "advise_buy") assert hasattr(hyperopt, "advise_buy")
assert hasattr(hyperopt, "max_open_trades") assert hasattr(hyperopt, "max_open_trades")
assert hyperopt.max_open_trades == default_conf['max_open_trades'] assert hyperopt.max_open_trades == default_conf['max_open_trades']
assert hasattr(hyperopt, "position_stacking")
def test_format_results(hyperopt): def test_format_results(hyperopt):
@ -569,8 +570,24 @@ def test_clean_hyperopt(mocker, default_conf, caplog):
}) })
mocker.patch("freqtrade.optimize.hyperopt.Path.is_file", MagicMock(return_value=True)) mocker.patch("freqtrade.optimize.hyperopt.Path.is_file", MagicMock(return_value=True))
unlinkmock = mocker.patch("freqtrade.optimize.hyperopt.Path.unlink", MagicMock()) unlinkmock = mocker.patch("freqtrade.optimize.hyperopt.Path.unlink", MagicMock())
hyp = Hyperopt(default_conf) Hyperopt(default_conf)
hyp.clean_hyperopt()
assert unlinkmock.call_count == 2 assert unlinkmock.call_count == 2
assert log_has(f"Removing `{TICKERDATA_PICKLE}`.", caplog.record_tuples) assert log_has(f"Removing `{TICKERDATA_PICKLE}`.", caplog.record_tuples)
def test_continue_hyperopt(mocker, default_conf, caplog):
patch_exchange(mocker)
default_conf.update({'config': 'config.json.example',
'epochs': 1,
'timerange': None,
'spaces': 'all',
'hyperopt_jobs': 1,
'hyperopt_continue': True
})
mocker.patch("freqtrade.optimize.hyperopt.Path.is_file", MagicMock(return_value=True))
unlinkmock = mocker.patch("freqtrade.optimize.hyperopt.Path.unlink", MagicMock())
Hyperopt(default_conf)
assert unlinkmock.call_count == 0
assert log_has(f"Continuing on previous hyperopt results.", caplog.record_tuples)