Merge pull request #6628 from topscoder/patch-2

Fixes CoinGecko typos in fiat_convert
This commit is contained in:
Matthias 2022-04-02 08:16:32 +02:00 committed by GitHub
commit 7c5e730007
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions

View File

@ -63,7 +63,7 @@ class CryptoToFiatConverter:
except RequestException as request_exception: except RequestException as request_exception:
if "429" in str(request_exception): if "429" in str(request_exception):
logger.warning( logger.warning(
"Too many requests for Coingecko API, backing off and trying again later.") "Too many requests for CoinGecko API, backing off and trying again later.")
# Set backoff timestamp to 60 seconds in the future # Set backoff timestamp to 60 seconds in the future
self._backoff = datetime.datetime.now().timestamp() + 60 self._backoff = datetime.datetime.now().timestamp() + 60
return return
@ -96,7 +96,7 @@ class CryptoToFiatConverter:
if len(found) > 0: if len(found) > 0:
# Wrong! # Wrong!
logger.warning(f"Found multiple mappings in goingekko for {crypto_symbol}.") logger.warning(f"Found multiple mappings in CoinGecko for {crypto_symbol}.")
return None return None
def convert_amount(self, crypto_amount: float, crypto_symbol: str, fiat_symbol: str) -> float: def convert_amount(self, crypto_amount: float, crypto_symbol: str, fiat_symbol: str) -> float:
@ -160,7 +160,7 @@ class CryptoToFiatConverter:
def _find_price(self, crypto_symbol: str, fiat_symbol: str) -> float: def _find_price(self, crypto_symbol: str, fiat_symbol: str) -> float:
""" """
Call CoinGekko API to retrieve the price in the FIAT Call CoinGecko API to retrieve the price in the FIAT
:param crypto_symbol: Crypto-currency you want to convert (e.g btc) :param crypto_symbol: Crypto-currency you want to convert (e.g btc)
:param fiat_symbol: FIAT currency you want to convert to (e.g usd) :param fiat_symbol: FIAT currency you want to convert to (e.g usd)
:return: float, price of the crypto-currency in Fiat :return: float, price of the crypto-currency in Fiat

View File

@ -137,7 +137,7 @@ def test_fiat_too_many_requests_response(mocker, caplog):
assert len(fiat_convert._coinlistings) == 0 assert len(fiat_convert._coinlistings) == 0
assert fiat_convert._backoff > datetime.datetime.now().timestamp() assert fiat_convert._backoff > datetime.datetime.now().timestamp()
assert log_has( assert log_has(
'Too many requests for Coingecko API, backing off and trying again later.', 'Too many requests for CoinGecko API, backing off and trying again later.',
caplog caplog
) )
@ -156,7 +156,7 @@ def test_fiat_multiple_coins(mocker, caplog):
assert fiat_convert._get_gekko_id('hnt') is None assert fiat_convert._get_gekko_id('hnt') is None
assert fiat_convert._get_gekko_id('eth') == 'ethereum' assert fiat_convert._get_gekko_id('eth') == 'ethereum'
assert log_has('Found multiple mappings in goingekko for hnt.', caplog) assert log_has('Found multiple mappings in CoinGecko for hnt.', caplog)
def test_fiat_invalid_response(mocker, caplog): def test_fiat_invalid_response(mocker, caplog):