updated unit test - this file was trying to create a dir in / of the host OS, should never have worked?

updated configuration.py call to os to be more pythony!
This commit is contained in:
creslinux 2018-06-03 22:30:25 +03:00
parent 343ca8fe19
commit 732523544f
2 changed files with 7 additions and 7 deletions

View File

@ -4,7 +4,7 @@ This module contains the configuration class
import json
import logging
import os
from os import path, makedirs
from argparse import Namespace
from typing import Optional, Dict, Any
from jsonschema import Draft4Validator, validate
@ -150,15 +150,15 @@ class Configuration(object):
else:
exchange = config.get('exchange', {}).get('name').lower()
if exchange:
default = os.path.join('freqtrade', 'tests', 'testdata', exchange)
default = path.join('freqtrade', 'tests', 'testdata', exchange)
config.update({'datadir': default})
# What if user has no exchange as arg or in file - set catchall
else:
logger.info("No exchange set")
default = os.path.join('freqtrade', 'tests', 'testdata', 'catchall')
default = path.join('freqtrade', 'tests', 'testdata', 'catchall')
if not os.path.exists(config['datadir']):
os.makedirs(config['datadir'])
if not path.exists(config['datadir']):
makedirs(config['datadir'])
logger.info("Made directory: %s", config['datadir'])
logger.info('Using data folder: %s ...', config['datadir'])

View File

@ -266,14 +266,14 @@ def test_setup_configuration_with_arguments(mocker, default_conf, caplog) -> Non
arglist = [
'--config', 'config.json',
'--strategy', 'DefaultStrategy',
'--datadir', '/foo/bar',
'--datadir', 'freqtrade/tests/testdata/',
'backtesting',
'--ticker-interval', '1m',
'--live',
'--realistic-simulation',
'--refresh-pairs-cached',
'--timerange', ':100',
'--export', '/bar/foo'
'--export', 'user_data/data'
]
args = Arguments(arglist, '').get_parsed_arg()