adelorenzo/stable
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Verify if trade is closed before acting on Stoploss_on_exchange

Browse Source
This commit is contained in:
Matthias
2020-01-23 20:36:48 +01:00
parent ea5ac1efb5
commit 70b9bd9c0e
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
freqtrade/freqtradebot.py
View File

@@ -689,9 +689,10 @@ class FreqtradeBot:
self._notify_sell(trade, "stoploss") self._notify_sell(trade, "stoploss")
return True return True
if trade.open_order_id: if trade.open_order_id or not trade.is_open:
# Trade has an open Buy or Sell order, Stoploss-handling can't happen in this case # Trade has an open Buy or Sell order, Stoploss-handling can't happen in this case
# as the Amount on the exchange is tied up in another trade. # as the Amount on the exchange is tied up in another trade.
# The trade can be closed already (sell-order fill confirmation came in this iteration)
return False return False
# If buy order is fulfilled but there is no stoploss, we add a stoploss on exchange # If buy order is fulfilled but there is no stoploss, we add a stoploss on exchange

1
tests/test_freqtradebot.py
View File

@@ -1127,6 +1127,7 @@ def test_handle_stoploss_on_exchange(mocker, default_conf, fee, caplog,
'freqtrade.exchange.Exchange.stoploss_limit', 'freqtrade.exchange.Exchange.stoploss_limit',
side_effect=DependencyException() side_effect=DependencyException()
) )
trade.is_open = True
freqtrade.handle_stoploss_on_exchange(trade) freqtrade.handle_stoploss_on_exchange(trade)
assert log_has('Unable to place a stoploss order on exchange.', caplog) assert log_has('Unable to place a stoploss order on exchange.', caplog)
assert trade.stoploss_order_id is None assert trade.stoploss_order_id is None