Support both position modes on OKX

tests/exchange/test_exchange.py

@@ -99,6 +99,8 @@ def test_remove_credentials(default_conf, caplog) -> None:
 def test_init_ccxt_kwargs(default_conf, mocker, caplog):
     mocker.patch('freqtrade.exchange.Exchange._load_markets', MagicMock(return_value={}))
     mocker.patch('freqtrade.exchange.Exchange.validate_stakecurrency')
+    aei_mock = mocker.patch('freqtrade.exchange.Exchange.additional_exchange_init')
+
     caplog.set_level(logging.INFO)
     conf = copy.deepcopy(default_conf)
     conf['exchange']['ccxt_async_config'] = {'aiohttp_trust_env': True, 'asyncio_loop': True}
@@ -108,6 +110,7 @@ def test_init_ccxt_kwargs(default_conf, mocker, caplog):
         caplog)
     assert ex._api_async.aiohttp_trust_env
     assert not ex._api.aiohttp_trust_env
+    assert aei_mock.call_count == 1
 
     # Reset logging and config
     caplog.clear()
@@ -4758,8 +4761,10 @@ def test__get_params(mocker, default_conf, exchange_name):
 
     if exchange_name == 'okx':
         params2['tdMode'] = 'isolated'
+        params2['posSide'] = 'net'
 
     assert exchange._get_params(
+        side="buy",
         ordertype='market',
         reduceOnly=False,
         time_in_force='gtc',
@@ -4767,6 +4772,7 @@ def test__get_params(mocker, default_conf, exchange_name):
     ) == params1
 
     assert exchange._get_params(
+        side="buy",
         ordertype='market',
         reduceOnly=False,
         time_in_force='ioc',
@@ -4774,6 +4780,7 @@ def test__get_params(mocker, default_conf, exchange_name):
     ) == params1
 
     assert exchange._get_params(
+        side="buy",
         ordertype='limit',
         reduceOnly=False,
         time_in_force='gtc',
@@ -4786,6 +4793,7 @@ def test__get_params(mocker, default_conf, exchange_name):
     exchange._params = {'test': True}
 
     assert exchange._get_params(
+        side="buy",
         ordertype='limit',
         reduceOnly=True,
         time_in_force='ioc',

tests/exchange/test_okx.py

@@ -1,7 +1,10 @@
 from unittest.mock import MagicMock, PropertyMock
 
+import pytest
+
 from freqtrade.enums import MarginMode, TradingMode
 from tests.conftest import get_patched_exchange
+from tests.exchange.test_exchange import ccxt_exceptionhandlers
 
 
 def test_get_maintenance_ratio_and_amt_okx(
@@ -170,6 +173,69 @@ def test_get_max_pair_stake_amount_okx(default_conf, mocker, leverage_tiers):
     assert exchange.get_max_pair_stake_amount('TTT/USDT', 1.0) == float('inf')  # Not in tiers
 
 
+@pytest.mark.parametrize('mode,side,reduceonly,result', [
+    ('net', 'buy', False, 'net'),
+    ('net', 'sell', True, 'net'),
+    ('net', 'sell', False, 'net'),
+    ('net', 'buy', True, 'net'),
+    ('longshort', 'buy', False, 'long'),
+    ('longshort', 'sell', True, 'long'),
+    ('longshort', 'sell', False, 'short'),
+    ('longshort', 'buy', True, 'short'),
+])
+def test__get_posSide(default_conf, mocker, mode, side, reduceonly, result):
+
+    exchange = get_patched_exchange(mocker, default_conf, id="okx")
+    exchange.net_only = mode == 'net'
+    assert exchange._get_posSide(side, reduceonly) == result
+
+
+def test_additional_exchange_init_okx(default_conf, mocker):
+    api_mock = MagicMock()
+    api_mock.fetch_accounts = MagicMock(return_value=[
+        {'id': '2555',
+         'type': '2',
+         'currency': None,
+         'info': {'acctLv': '2',
+                  'autoLoan': False,
+                  'ctIsoMode': 'automatic',
+                  'greeksType': 'PA',
+                  'level': 'Lv1',
+                  'levelTmp': '',
+                  'mgnIsoMode': 'automatic',
+                  'posMode': 'long_short_mode',
+                  'uid': '2555'}}])
+    exchange = get_patched_exchange(mocker, default_conf, id="okx", api_mock=api_mock)
+    assert api_mock.fetch_accounts.call_count == 0
+    exchange.trading_mode = TradingMode.FUTURES
+    # Default to netOnly
+    assert exchange.net_only
+    exchange.additional_exchange_init()
+    assert api_mock.fetch_accounts.call_count == 1
+    assert not exchange.net_only
+
+    api_mock.fetch_accounts = MagicMock(return_value=[
+            {'id': '2555',
+             'type': '2',
+             'currency': None,
+             'info': {'acctLv': '2',
+                      'autoLoan': False,
+                      'ctIsoMode': 'automatic',
+                      'greeksType': 'PA',
+                      'level': 'Lv1',
+                      'levelTmp': '',
+                      'mgnIsoMode': 'automatic',
+                      'posMode': 'net_mode',
+                      'uid': '2555'}}])
+    exchange.additional_exchange_init()
+    assert api_mock.fetch_accounts.call_count == 1
+    assert exchange.net_only
+    default_conf['trading_mode'] = 'futures'
+    default_conf['margin_mode'] = 'isolated'
+    ccxt_exceptionhandlers(mocker, default_conf, api_mock, 'okx',
+                           "additional_exchange_init", "fetch_accounts")
+
+
 def test_load_leverage_tiers_okx(default_conf, mocker, markets):
     api_mock = MagicMock()
     type(api_mock).has = PropertyMock(return_value={