From 6899b331304479b06c878546978aff25a853ed7b Mon Sep 17 00:00:00 2001 From: Gerald Lonlas Date: Sun, 21 Jan 2018 14:00:05 -0800 Subject: [PATCH] Speed up unit test test_fiat_convert_get_price and test_fiat_convert_find_price Change the mock of the unit test_fiat_convert_get_price Duration get optimized: - test_fiat_convert_get_price from 1.83s to 0.08s - test_fiat_convert_find_price from 1.72s to 0.08s --- freqtrade/tests/test_fiat_convert.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/freqtrade/tests/test_fiat_convert.py b/freqtrade/tests/test_fiat_convert.py index 48b305438..3e3e82ae9 100644 --- a/freqtrade/tests/test_fiat_convert.py +++ b/freqtrade/tests/test_fiat_convert.py @@ -63,10 +63,12 @@ def test_fiat_convert_add_pair(): def test_fiat_convert_find_price(mocker): api_mock = MagicMock(return_value={ - 'price_usd': 12345.0, + 'ticker': MagicMock(return_value={ + 'price_usd': 12345.0, 'price_eur': 13000.2 + }) }) - mocker.patch('freqtrade.fiat_convert.Pymarketcap.ticker', api_mock) + mocker.patch('freqtrade.fiat_convert.Pymarketcap', api_mock) fiat_convert = CryptoToFiatConverter() with pytest.raises(ValueError, match=r'The fiat ABC is not supported.'): @@ -82,10 +84,12 @@ def test_fiat_convert_find_price(mocker): def test_fiat_convert_get_price(mocker): api_mock = MagicMock(return_value={ - 'price_usd': 28000.0, - 'price_eur': 15000.0 + 'ticker': MagicMock(return_value={ + 'price_usd': 28000.0, + 'price_eur': 15000.0 + }) }) - mocker.patch('freqtrade.fiat_convert.Pymarketcap.ticker', api_mock) + mocker.patch('freqtrade.fiat_convert.Pymarketcap', api_mock) mocker.patch('freqtrade.fiat_convert.CryptoToFiatConverter._find_price', return_value=28000.0) fiat_convert = CryptoToFiatConverter()