diff --git a/freqtrade/fiat_convert.py b/freqtrade/fiat_convert.py index 91e04fff9..6f9d3d3d5 100644 --- a/freqtrade/fiat_convert.py +++ b/freqtrade/fiat_convert.py @@ -1,12 +1,19 @@ +""" +Module that define classes to convert Crypto-currency to FIAT +e.g BTC to USD +""" + import logging import time - from pymarketcap import Pymarketcap logger = logging.getLogger(__name__) class CryptoFiat(): + """ + Object to describe what is the price of Crypto-currency in a FIAT + """ # Constants CACHE_DURATION = 6 * 60 * 60 # 6 hours @@ -49,6 +56,11 @@ class CryptoFiat(): class CryptoToFiatConverter(object): + """ + Main class to initiate Crypto to FIAT. + This object contains a list of pair Crypto, FIAT + This object is also a Singleton + """ __instance = None _coinmarketcap = None diff --git a/freqtrade/strategy/default_strategy.py b/freqtrade/strategy/default_strategy.py index c89b20527..abccf065b 100644 --- a/freqtrade/strategy/default_strategy.py +++ b/freqtrade/strategy/default_strategy.py @@ -1,7 +1,9 @@ +# pragma pylint: disable=missing-docstring, invalid-name, pointless-string-statement + import talib.abstract as ta +from pandas import DataFrame import freqtrade.vendor.qtpylib.indicators as qtpylib from freqtrade.strategy.interface import IStrategy -from pandas import DataFrame class_name = 'DefaultStrategy' diff --git a/freqtrade/tests/test_fiat_convert.py b/freqtrade/tests/test_fiat_convert.py index 2d112f921..7d0acfc91 100644 --- a/freqtrade/tests/test_fiat_convert.py +++ b/freqtrade/tests/test_fiat_convert.py @@ -1,4 +1,5 @@ -# pragma pylint: disable=missing-docstring, too-many-arguments, too-many-ancestors, C0103 +# pragma pylint: disable=missing-docstring, too-many-arguments, too-many-ancestors, +# pragma pylint: disable=protected-access, C0103 import time from unittest.mock import MagicMock @@ -47,16 +48,19 @@ def test_fiat_convert_is_supported(): def test_fiat_convert_add_pair(): fiat_convert = CryptoToFiatConverter() - assert len(fiat_convert._pairs) == 0 + pair_len = len(fiat_convert._pairs) + assert pair_len == 0 fiat_convert._add_pair(crypto_symbol='btc', fiat_symbol='usd', price=12345.0) - assert len(fiat_convert._pairs) == 1 + pair_len = len(fiat_convert._pairs) + assert pair_len == 1 assert fiat_convert._pairs[0].crypto_symbol == 'BTC' assert fiat_convert._pairs[0].fiat_symbol == 'USD' assert fiat_convert._pairs[0].price == 12345.0 fiat_convert._add_pair(crypto_symbol='btc', fiat_symbol='Eur', price=13000.2) - assert len(fiat_convert._pairs) == 2 + pair_len = len(fiat_convert._pairs) + assert pair_len == 2 assert fiat_convert._pairs[1].crypto_symbol == 'BTC' assert fiat_convert._pairs[1].fiat_symbol == 'EUR' assert fiat_convert._pairs[1].price == 13000.2 @@ -95,7 +99,8 @@ def test_fiat_convert_get_price(mocker): fiat_convert.get_price(crypto_symbol='BTC', fiat_symbol='US Dollar') # Check the value return by the method - assert len(fiat_convert._pairs) == 0 + pair_len = len(fiat_convert._pairs) + assert pair_len == 0 assert fiat_convert.get_price(crypto_symbol='BTC', fiat_symbol='USD') == 28000.0 assert fiat_convert._pairs[0].crypto_symbol == 'BTC' assert fiat_convert._pairs[0].fiat_symbol == 'USD'