From 630b2b19964906544785cdffba18d2292ea4b02d Mon Sep 17 00:00:00 2001 From: Zohar Kol Date: Thu, 30 Mar 2023 10:20:53 +0300 Subject: [PATCH] remove normalizatio test from kitchen and add pickle metadata assertions --- tests/freqai/test_freqai_datakitchen.py | 8 -------- tests/freqai/test_normalization.py | 2 ++ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/tests/freqai/test_freqai_datakitchen.py b/tests/freqai/test_freqai_datakitchen.py index 95665a775..4b8c4a249 100644 --- a/tests/freqai/test_freqai_datakitchen.py +++ b/tests/freqai/test_freqai_datakitchen.py @@ -125,14 +125,6 @@ def test_principal_component_analysis(mocker, freqai_conf, caplog): ) -def test_normalize_data(mocker, freqai_conf): - freqai = make_data_dictionary(mocker, freqai_conf) - data_dict = freqai.dk.data_dictionary - freqai.dk.normalize_data(data_dict) - assert any('_max' in entry for entry in freqai.dk.data.keys()) - assert any('_min' in entry for entry in freqai.dk.data.keys()) - - def test_filter_features(mocker, freqai_conf): freqai, unfiltered_dataframe = make_unfiltered_dataframe(mocker, freqai_conf) freqai.dk.find_features(unfiltered_dataframe) diff --git a/tests/freqai/test_normalization.py b/tests/freqai/test_normalization.py index 375f6c477..9638996d7 100644 --- a/tests/freqai/test_normalization.py +++ b/tests/freqai/test_normalization.py @@ -33,6 +33,7 @@ def test_legacy_normalization_add_max_min_columns(mocker, freqai_conf): assert any('_max' in entry for entry in freqai.dk.data.keys()) assert any('_min' in entry for entry in freqai.dk.data.keys()) + assert all(not entry.endswith('_scaler') for entry in freqai.dk.pkl_data.keys()) def test_standard_normalization_dont_add_max_min_columns(mocker, freqai_conf): @@ -42,6 +43,7 @@ def test_standard_normalization_dont_add_max_min_columns(mocker, freqai_conf): freqai.dk.normalize_data(data_dict) assert all(not entry.endswith('_max') for entry in freqai.dk.data.keys()) assert all(not entry.endswith('_min') for entry in freqai.dk.data.keys()) + assert any(entry.endswith('_scaler') for entry in freqai.dk.pkl_data.keys()) def test_legacy_and_standard_normalization_difference(mocker, freqai_conf):