From 557f849519ef144693135f2f5f51404c28f3bd7f Mon Sep 17 00:00:00 2001 From: Matthias Date: Sat, 11 May 2019 13:18:11 +0200 Subject: [PATCH] Improve 404 handling --- freqtrade/rpc/api_server.py | 2 +- freqtrade/tests/rpc/test_rpc_apiserver.py | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/freqtrade/rpc/api_server.py b/freqtrade/rpc/api_server.py index 5b7da902d..573f89143 100644 --- a/freqtrade/rpc/api_server.py +++ b/freqtrade/rpc/api_server.py @@ -156,7 +156,7 @@ class ApiServer(RPC): """ return self.rest_dump({ 'status': 'error', - 'reason': '''There's no API call for %s''' % request.base_url, + 'reason': f"There's no API call for {request.base_url}.", 'code': 404 }), 404 diff --git a/freqtrade/tests/rpc/test_rpc_apiserver.py b/freqtrade/tests/rpc/test_rpc_apiserver.py index 3590b0dc8..52a456d68 100644 --- a/freqtrade/tests/rpc/test_rpc_apiserver.py +++ b/freqtrade/tests/rpc/test_rpc_apiserver.py @@ -29,6 +29,18 @@ def response_success_assert(response): assert response.content_type == "application/json" +def test_api_not_found(botclient): + ftbot, client = botclient + + rc = client.post("/invalid_url") + assert rc.status_code == 404 + assert rc.content_type == "application/json" + assert rc.json == {'status': 'error', + 'reason': "There's no API call for http://localhost/invalid_url.", + 'code': 404 + } + + def test_api_stop_workflow(botclient): ftbot, client = botclient assert ftbot.state == State.RUNNING