From 4cc93151c5266f77298989262def6778bb85a63f Mon Sep 17 00:00:00 2001 From: Pan Long Date: Sun, 31 Jan 2021 12:14:09 +0800 Subject: [PATCH] Fix a bug when compare sell_profit_offset It should be comparing the ratio instead of absolut profit. Also updated the comment. --- freqtrade/strategy/interface.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/freqtrade/strategy/interface.py b/freqtrade/strategy/interface.py index c58d9aa5d..77d45b445 100644 --- a/freqtrade/strategy/interface.py +++ b/freqtrade/strategy/interface.py @@ -530,8 +530,8 @@ class IStrategy(ABC): current_time=date)) if (ask_strategy.get('sell_profit_only', False) - and trade.calc_profit(rate=rate) <= ask_strategy.get('sell_profit_offset', 0)): - # Negative profits and sell_profit_only - ignore sell signal + and trade.calc_profit_ratio(rate=rate) <= ask_strategy.get('sell_profit_offset', 0)): + # sell_profit_only and profit doesn't reach the offset - ignore sell signal sell_signal = False else: sell_signal = sell and not buy and ask_strategy.get('use_sell_signal', True)