From 48b34c8fd06b2f5cc634e813ddaa9860a6210733 Mon Sep 17 00:00:00 2001 From: Sam Germain Date: Sat, 6 Nov 2021 21:03:18 -0600 Subject: [PATCH] Fixed issues with funding-fee being miscalculated on trade objects in freqtradebot --- freqtrade/freqtradebot.py | 2 +- tests/test_freqtradebot.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/freqtrade/freqtradebot.py b/freqtrade/freqtradebot.py index 0cb99c7bf..a046f85b9 100644 --- a/freqtrade/freqtradebot.py +++ b/freqtrade/freqtradebot.py @@ -275,7 +275,7 @@ class FreqtradeBot(LoggingMixin): trade.pair, trade.amount, trade.open_date - ) + (trade.funding_fees or 0.0) + ) else: funding_fees = self.exchange.get_funding_fees_from_exchange( trade.pair, diff --git a/tests/test_freqtradebot.py b/tests/test_freqtradebot.py index a7153598f..970f26ccf 100644 --- a/tests/test_freqtradebot.py +++ b/tests/test_freqtradebot.py @@ -4780,7 +4780,7 @@ def test_update_funding_fees(mocker, default_conf, time_machine, fee): trades = Trade.get_open_trades() for trade in trades: assert trade.funding_fees == sum([ - 123 * + trade.amount * mark_prices[trade.pair][time] * funding_rates[trade.pair][time] for time in mark_prices[trade.pair].keys() ])