From 43fd9b37df968bbdce3c66beabe86a4f3799213b Mon Sep 17 00:00:00 2001 From: gcarq Date: Thu, 3 May 2018 10:48:25 +0200 Subject: [PATCH] fix 'max_open_trades must be greater than 0' regression --- freqtrade/constants.py | 2 +- freqtrade/tests/test_configuration.py | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/freqtrade/constants.py b/freqtrade/constants.py index fa09d8eab..7731ea610 100644 --- a/freqtrade/constants.py +++ b/freqtrade/constants.py @@ -29,7 +29,7 @@ TICKER_INTERVAL_MINUTES = { CONF_SCHEMA = { 'type': 'object', 'properties': { - 'max_open_trades': {'type': 'integer', 'minimum': 1}, + 'max_open_trades': {'type': 'integer', 'minimum': 0}, 'ticker_interval': {'type': 'string', 'enum': list(TICKER_INTERVAL_MINUTES.keys())}, 'stake_currency': {'type': 'string', 'enum': ['BTC', 'ETH', 'USDT']}, 'stake_amount': {'type': 'number', 'minimum': 0.0005}, diff --git a/freqtrade/tests/test_configuration.py b/freqtrade/tests/test_configuration.py index da7a042f5..d27405d91 100644 --- a/freqtrade/tests/test_configuration.py +++ b/freqtrade/tests/test_configuration.py @@ -69,6 +69,21 @@ def test_load_config_file(default_conf, mocker, caplog) -> None: assert log_has('Validating configuration ...', caplog.record_tuples) +def test_load_config_max_open_trades_zero(default_conf, mocker, caplog) -> None: + """ + Test Configuration._load_config_file() method + """ + conf = deepcopy(default_conf) + conf['max_open_trades'] = 0 + file_mock = mocker.patch('freqtrade.configuration.open', mocker.mock_open( + read_data=json.dumps(conf) + )) + + Configuration([])._load_config_file('somefile') + assert file_mock.call_count == 1 + assert log_has('Validating configuration ...', caplog.record_tuples) + + def test_load_config_file_exception(mocker, caplog) -> None: """ Test Configuration._load_config_file() method