From 4238ee090d4effc75ad14427f335cc254b5c5861 Mon Sep 17 00:00:00 2001 From: Matthias Date: Sun, 14 Jul 2019 20:05:28 +0200 Subject: [PATCH] Cleanup some code after deepcode.ai suggestions --- freqtrade/data/dataprovider.py | 9 ++++++--- freqtrade/tests/strategy/test_strategy.py | 4 ++-- freqtrade/tests/test_talib.py | 2 +- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/freqtrade/data/dataprovider.py b/freqtrade/data/dataprovider.py index 2852cbcb0..b87589df7 100644 --- a/freqtrade/data/dataprovider.py +++ b/freqtrade/data/dataprovider.py @@ -17,7 +17,7 @@ from freqtrade.state import RunMode logger = logging.getLogger(__name__) -class DataProvider(object): +class DataProvider(): def __init__(self, config: dict, exchange: Exchange) -> None: self._config = config @@ -81,11 +81,14 @@ class DataProvider(object): # TODO: Implement me pass - def orderbook(self, pair: str, max: int): + def orderbook(self, pair: str, maximum: int): """ return latest orderbook data + :param pair: pair to get the data for + :param maximum: Maximum number of orderbook entries to query + :return: dict including bids/asks with a total of `maximum` entries. """ - return self._exchange.get_order_book(pair, max) + return self._exchange.get_order_book(pair, maximum) @property def runmode(self) -> RunMode: diff --git a/freqtrade/tests/strategy/test_strategy.py b/freqtrade/tests/strategy/test_strategy.py index 904f84946..9a2c950e5 100644 --- a/freqtrade/tests/strategy/test_strategy.py +++ b/freqtrade/tests/strategy/test_strategy.py @@ -69,8 +69,8 @@ def test_load_strategy(result): def test_load_strategy_base64(result): - with open("freqtrade/tests/strategy/test_strategy.py", "r") as file: - encoded_string = urlsafe_b64encode(file.read().encode("utf-8")).decode("utf-8") + with open("freqtrade/tests/strategy/test_strategy.py", "rb") as file: + encoded_string = urlsafe_b64encode(file.read()).decode("utf-8") resolver = StrategyResolver({'strategy': 'TestStrategy:{}'.format(encoded_string)}) assert 'adx' in resolver.strategy.advise_indicators(result, {'pair': 'ETH/BTC'}) diff --git a/freqtrade/tests/test_talib.py b/freqtrade/tests/test_talib.py index 093c3023c..2c7f73eb1 100644 --- a/freqtrade/tests/test_talib.py +++ b/freqtrade/tests/test_talib.py @@ -13,4 +13,4 @@ def test_talib_bollingerbands_near_zero_values(): {'close': 0.00000014} ]) bollinger = ta.BBANDS(inputs, matype=0, timeperiod=2) - assert (bollinger['upperband'][3] != bollinger['middleband'][3]) + assert bollinger['upperband'][3] != bollinger['middleband'][3]