From 3d86b184929bc6d9d6f2ca75548775a87c35367d Mon Sep 17 00:00:00 2001
From: Sam Germain <sam.germain@usask.ca>
Date: Sat, 13 Nov 2021 05:00:47 -0600
Subject: [PATCH] Added property _ft_has_default.ccxt_futures_name and removed
 subclass ccxt_config properties

---
 freqtrade/exchange/binance.py   | 19 +------------------
 freqtrade/exchange/bybit.py     |  1 +
 freqtrade/exchange/exchange.py  | 16 +++++++++++++++-
 freqtrade/exchange/gateio.py    | 18 ------------------
 freqtrade/exchange/okex.py      | 18 ------------------
 tests/exchange/test_exchange.py |  7 -------
 6 files changed, 17 insertions(+), 62 deletions(-)

diff --git a/freqtrade/exchange/binance.py b/freqtrade/exchange/binance.py
index c16566fde..9a707072d 100644
--- a/freqtrade/exchange/binance.py
+++ b/freqtrade/exchange/binance.py
@@ -27,6 +27,7 @@ class Binance(Exchange):
         "trades_pagination": "id",
         "trades_pagination_arg": "fromId",
         "l2_limit_range": [5, 10, 20, 50, 100, 500, 1000],
+        "ccxt_futures_name": "future"
     }
     funding_fee_times: List[int] = [0, 8, 16]  # hours of the day
     # but the schedule won't check within this timeframe
@@ -38,24 +39,6 @@ class Binance(Exchange):
         # (TradingMode.FUTURES, Collateral.ISOLATED) # TODO-lev: Uncomment once supported
     ]
 
-    @property
-    def _ccxt_config(self) -> Dict:
-        # Parameters to add directly to ccxt sync/async initialization.
-        if self.trading_mode == TradingMode.MARGIN:
-            return {
-                "options": {
-                    "defaultType": "margin"
-                }
-            }
-        elif self.trading_mode == TradingMode.FUTURES:
-            return {
-                "options": {
-                    "defaultType": "future"
-                }
-            }
-        else:
-            return {}
-
     def stoploss_adjust(self, stop_loss: float, order: Dict, side: str) -> bool:
         """
         Verify stop_loss against stoploss-order value (limit or price)
diff --git a/freqtrade/exchange/bybit.py b/freqtrade/exchange/bybit.py
index df19a671b..27deb79d7 100644
--- a/freqtrade/exchange/bybit.py
+++ b/freqtrade/exchange/bybit.py
@@ -21,6 +21,7 @@ class Bybit(Exchange):
 
     _ft_has: Dict = {
         "ohlcv_candle_limit": 200,
+        "ccxt_futures_name": "linear"
     }
 
     funding_fee_times: List[int] = [0, 8, 16]  # hours of the day
diff --git a/freqtrade/exchange/exchange.py b/freqtrade/exchange/exchange.py
index cf7772600..5025d2396 100644
--- a/freqtrade/exchange/exchange.py
+++ b/freqtrade/exchange/exchange.py
@@ -69,6 +69,7 @@ class Exchange:
         "trades_pagination_arg": "since",
         "l2_limit_range": None,
         "l2_limit_range_required": True,  # Allow Empty L2 limit (kucoin)
+        "ccxt_futures_name": "swap"
     }
     _ft_has: Dict = {}
 
@@ -234,7 +235,20 @@ class Exchange:
     @property
     def _ccxt_config(self) -> Dict:
         # Parameters to add directly to ccxt sync/async initialization.
-        return {}
+        if self.trading_mode == TradingMode.MARGIN:
+            return {
+                "options": {
+                    "defaultType": "margin"
+                }
+            }
+        elif self.trading_mode == TradingMode.FUTURES:
+            return {
+                "options": {
+                    "defaultType": self._ft_has["ccxt_futures_name"]
+                }
+            }
+        else:
+            return {}
 
     @property
     def name(self) -> str:
diff --git a/freqtrade/exchange/gateio.py b/freqtrade/exchange/gateio.py
index 83abd1266..d7edb843c 100644
--- a/freqtrade/exchange/gateio.py
+++ b/freqtrade/exchange/gateio.py
@@ -35,24 +35,6 @@ class Gateio(Exchange):
         # (TradingMode.FUTURES, Collateral.ISOLATED) # TODO-lev: Uncomment once supported
     ]
 
-    @property
-    def _ccxt_config(self) -> Dict:
-        # Parameters to add directly to ccxt sync/async initialization.
-        if self.trading_mode == TradingMode.MARGIN:
-            return {
-                "options": {
-                    "defaultType": "margin"
-                }
-            }
-        elif self.trading_mode == TradingMode.FUTURES:
-            return {
-                "options": {
-                    "defaultType": "swap"
-                }
-            }
-        else:
-            return {}
-
     def validate_ordertypes(self, order_types: Dict) -> None:
         super().validate_ordertypes(order_types)
 
diff --git a/freqtrade/exchange/okex.py b/freqtrade/exchange/okex.py
index 100bf3adf..a435ef819 100644
--- a/freqtrade/exchange/okex.py
+++ b/freqtrade/exchange/okex.py
@@ -25,21 +25,3 @@ class Okex(Exchange):
         # (TradingMode.FUTURES, Collateral.CROSS),  # TODO-lev: Uncomment once supported
         # (TradingMode.FUTURES, Collateral.ISOLATED) # TODO-lev: Uncomment once supported
     ]
-
-    @property
-    def _ccxt_config(self) -> Dict:
-        # Parameters to add directly to ccxt sync/async initialization.
-        if self.trading_mode == TradingMode.MARGIN:
-            return {
-                "options": {
-                    "defaultType": "margin"
-                }
-            }
-        elif self.trading_mode == TradingMode.FUTURES:
-            return {
-                "options": {
-                    "defaultType": "swap"
-                }
-            }
-        else:
-            return {}
diff --git a/tests/exchange/test_exchange.py b/tests/exchange/test_exchange.py
index 8e3fdfe74..6b6900752 100644
--- a/tests/exchange/test_exchange.py
+++ b/tests/exchange/test_exchange.py
@@ -3253,13 +3253,6 @@ def test_validate_trading_mode_and_collateral(
     ("binance", "spot", {}),
     ("binance", "margin", {"options": {"defaultType": "margin"}}),
     ("binance", "futures", {"options": {"defaultType": "future"}}),
-    ("kraken", "spot", {}),
-    ("kraken", "margin", {}),
-    ("kraken", "futures", {}),
-    ("ftx", "spot", {}),
-    ("ftx", "margin", {}),
-    ("ftx", "futures", {}),
-    ("bittrex", "spot", {}),
     ("gateio", "spot", {}),
     ("gateio", "margin", {"options": {"defaultType": "margin"}}),
     ("gateio", "futures", {"options": {"defaultType": "swap"}}),