From 2e95df4d8dde6ff7ff4be9ed41af9da742ba3b18 Mon Sep 17 00:00:00 2001
From: Matthias <xmatthias@outlook.com>
Date: Thu, 15 Jul 2021 07:11:44 +0200
Subject: [PATCH] Update docs for /profit output

---
 docs/telegram-usage.md | 8 ++++++--
 freqtrade/rpc/rpc.py   | 8 ++++----
 tests/test_wallets.py  | 2 ++
 3 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/docs/telegram-usage.md b/docs/telegram-usage.md
index f5d9744b4..b020b00db 100644
--- a/docs/telegram-usage.md
+++ b/docs/telegram-usage.md
@@ -245,10 +245,10 @@ current    max
 Return a summary of your profit/loss and performance.
 
 > **ROI:** Close trades  
->   ∙ `0.00485701 BTC (258.45%)`  
+>   ∙ `0.00485701 BTC (2.2%) (15.2 Σ%)`  
 >   ∙ `62.968 USD`  
 > **ROI:** All trades  
->   ∙ `0.00255280 BTC (143.43%)`  
+>   ∙ `0.00255280 BTC (1.5%) (6.43 Σ%)`  
 >   ∙ `33.095 EUR`  
 >  
 > **Total Trade Count:** `138`  
@@ -257,6 +257,10 @@ Return a summary of your profit/loss and performance.
 > **Avg. Duration:** `2:33:45`  
 > **Best Performing:** `PAY/BTC: 50.23%`  
 
+The relative profit of `1.2%` is the average profit per trade.  
+The relative profit of `15.2 Σ%` is be based on the starting capital - so in this case, the starting capital was `0.00485701 * 1.152 = 0.00738 BTC`.
+Starting capital is either taken from the `available_capital` setting, or calculated by using current wallet size - profits.
+
 ### /forcesell <trade_id>
 
 > **BITTREX:** Selling BTC/LTC with limit `0.01650000 (profit: ~-4.07%, -0.00008168)`
diff --git a/freqtrade/rpc/rpc.py b/freqtrade/rpc/rpc.py
index d6eaf7ca6..db89443bf 100644
--- a/freqtrade/rpc/rpc.py
+++ b/freqtrade/rpc/rpc.py
@@ -416,16 +416,16 @@ class RPC:
             'profit_closed_coin': profit_closed_coin_sum,
             'profit_closed_percent_mean': round(profit_closed_ratio_mean * 100, 2),
             'profit_closed_ratio_mean': profit_closed_ratio_mean,
-            'profit_closed_percent_sum': round(profit_closed_ratio_sum * 100, 2),  # Deprecated
-            'profit_closed_ratio_sum': profit_closed_ratio_sum,  # Deprecated
+            'profit_closed_percent_sum': round(profit_closed_ratio_sum * 100, 2),
+            'profit_closed_ratio_sum': profit_closed_ratio_sum,
             'profit_closed_ratio': profit_closed_ratio_fromstart,
             'profit_closed_percent': round(profit_closed_ratio_fromstart * 100, 2),
             'profit_closed_fiat': profit_closed_fiat,
             'profit_all_coin': profit_all_coin_sum,
             'profit_all_percent_mean': round(profit_all_ratio_mean * 100, 2),
             'profit_all_ratio_mean': profit_all_ratio_mean,
-            'profit_all_percent_sum': round(profit_all_ratio_sum * 100, 2),  # Deprecated
-            'profit_all_ratio_sum': profit_all_ratio_sum,  # Deprecated
+            'profit_all_percent_sum': round(profit_all_ratio_sum * 100, 2),
+            'profit_all_ratio_sum': profit_all_ratio_sum,
             'profit_all_ratio': profit_all_ratio_fromstart,
             'profit_all_percent': round(profit_all_ratio_fromstart * 100, 2),
             'profit_all_fiat': profit_all_fiat,
diff --git a/tests/test_wallets.py b/tests/test_wallets.py
index 25f2ad89f..64db3b9cd 100644
--- a/tests/test_wallets.py
+++ b/tests/test_wallets.py
@@ -204,10 +204,12 @@ def test__validate_stake_amount(mocker, default_conf,
     (None, 0, 0, 2500, 2500),
     (None, 500, 0, 2500, 2000),
     (None, 500, 0, 2500, 2000),
+    (None, -70, 0, 1930, 2000),
     # Only available balance matters when it's set.
     (100, 0, 0, 0, 100),
     (1000, 0, 2, 5, 1000),
     (1235, 2250, 2, 5, 1235),
+    (1235, -2250, 2, 5, 1235),
 ])
 def test_get_starting_balance(mocker, default_conf, available_capital, closed_profit,
                               open_stakes, free, expected):