From 264d71e29e153aaf62b6dfc90dcbcac83c573838 Mon Sep 17 00:00:00 2001 From: gcarq Date: Sat, 4 Nov 2017 18:55:41 +0100 Subject: [PATCH] fix some pylint warnings --- freqtrade/exchange/bittrex.py | 2 +- freqtrade/tests/test_backtesting.py | 3 +- freqtrade/tests/test_telegram.py | 47 +++++++++++++++++++++++------ 3 files changed, 40 insertions(+), 12 deletions(-) diff --git a/freqtrade/exchange/bittrex.py b/freqtrade/exchange/bittrex.py index 306a7b698..111f05606 100644 --- a/freqtrade/exchange/bittrex.py +++ b/freqtrade/exchange/bittrex.py @@ -64,7 +64,7 @@ class Bittrex(Exchange): if not data['success']: raise RuntimeError('{}: {}'.format(self.name.upper(), data['message'])) return data['result'] - + def get_ticker(self, pair: str) -> dict: data = _API.get_ticker(pair.replace('_', '-')) if not data['success']: diff --git a/freqtrade/tests/test_backtesting.py b/freqtrade/tests/test_backtesting.py index a19191889..bf6b81a52 100644 --- a/freqtrade/tests/test_backtesting.py +++ b/freqtrade/tests/test_backtesting.py @@ -84,6 +84,7 @@ def test_backtest(conf, pairs, mocker, report=True): results = backtest(conf, pairs, mocker) print('====================== BACKTESTING REPORT ================================') - [print_pair_results(pair, results) for pair in pairs] + for pair in pairs: + print_pair_results(pair, results) print('TOTAL OVER ALL TRADES:') print(format_results(results)) diff --git a/freqtrade/tests/test_telegram.py b/freqtrade/tests/test_telegram.py index 4270ba21c..8ee830d92 100644 --- a/freqtrade/tests/test_telegram.py +++ b/freqtrade/tests/test_telegram.py @@ -9,7 +9,9 @@ from telegram import Bot, Update, Message, Chat from freqtrade.main import init, create_trade from freqtrade.misc import update_state, State, get_state, CONF_SCHEMA from freqtrade.persistence import Trade -from freqtrade.rpc.telegram import _status, _profit, _forcesell, _performance, _start, _stop, _balance +from freqtrade.rpc.telegram import ( + _status, _profit, _forcesell, _performance, _start, _stop, _balance +) @pytest.fixture @@ -62,7 +64,10 @@ def test_status_handle(conf, update, mocker): mocker.patch.dict('freqtrade.main._CONF', conf) mocker.patch('freqtrade.main.get_buy_signal', side_effect=lambda _: True) msg_mock = MagicMock() - mocker.patch.multiple('freqtrade.main.telegram', _CONF=conf, init=MagicMock(), send_msg=msg_mock) + mocker.patch.multiple('freqtrade.main.telegram', + _CONF=conf, + init=MagicMock(), + send_msg=msg_mock) mocker.patch.multiple('freqtrade.main.exchange', validate_pairs=MagicMock(), get_ticker=MagicMock(return_value={ @@ -106,7 +111,10 @@ def test_profit_handle(conf, update, mocker): mocker.patch.dict('freqtrade.main._CONF', conf) mocker.patch('freqtrade.main.get_buy_signal', side_effect=lambda _: True) msg_mock = MagicMock() - mocker.patch.multiple('freqtrade.main.telegram', _CONF=conf, init=MagicMock(), send_msg=msg_mock) + mocker.patch.multiple('freqtrade.main.telegram', + _CONF=conf, + init=MagicMock(), + send_msg=msg_mock) mocker.patch.multiple('freqtrade.main.exchange', validate_pairs=MagicMock(), get_ticker=MagicMock(return_value={ @@ -160,7 +168,10 @@ def test_forcesell_handle(conf, update, mocker): mocker.patch.dict('freqtrade.main._CONF', conf) mocker.patch('freqtrade.main.get_buy_signal', side_effect=lambda _: True) msg_mock = MagicMock() - mocker.patch.multiple('freqtrade.main.telegram', _CONF=conf, init=MagicMock(), send_msg=msg_mock) + mocker.patch.multiple('freqtrade.main.telegram', + _CONF=conf, + init=MagicMock(), + send_msg=msg_mock) mocker.patch.multiple('freqtrade.main.exchange', validate_pairs=MagicMock(), get_ticker=MagicMock(return_value={ @@ -202,7 +213,10 @@ def test_performance_handle(conf, update, mocker): mocker.patch.dict('freqtrade.main._CONF', conf) mocker.patch('freqtrade.main.get_buy_signal', side_effect=lambda _: True) msg_mock = MagicMock() - mocker.patch.multiple('freqtrade.main.telegram', _CONF=conf, init=MagicMock(), send_msg=msg_mock) + mocker.patch.multiple('freqtrade.main.telegram', + _CONF=conf, + init=MagicMock(), + send_msg=msg_mock) mocker.patch.multiple('freqtrade.main.exchange', validate_pairs=MagicMock(), get_ticker=MagicMock(return_value={ @@ -255,8 +269,13 @@ def test_performance_handle(conf, update, mocker): def test_start_handle(conf, update, mocker): mocker.patch.dict('freqtrade.main._CONF', conf) msg_mock = MagicMock() - mocker.patch.multiple('freqtrade.main.telegram', _CONF=conf, init=MagicMock(), send_msg=msg_mock) - mocker.patch.multiple('freqtrade.main.exchange', _CONF=conf, init=MagicMock()) + mocker.patch.multiple('freqtrade.main.telegram', + _CONF=conf, + init=MagicMock(), + send_msg=msg_mock) + mocker.patch.multiple('freqtrade.main.exchange', + _CONF=conf, + init=MagicMock()) init(conf, 'sqlite://') update_state(State.STOPPED) @@ -269,8 +288,13 @@ def test_start_handle(conf, update, mocker): def test_stop_handle(conf, update, mocker): mocker.patch.dict('freqtrade.main._CONF', conf) msg_mock = MagicMock() - mocker.patch.multiple('freqtrade.main.telegram', _CONF=conf, init=MagicMock(), send_msg=msg_mock) - mocker.patch.multiple('freqtrade.main.exchange', _CONF=conf, init=MagicMock()) + mocker.patch.multiple('freqtrade.main.telegram', + _CONF=conf, + init=MagicMock(), + send_msg=msg_mock) + mocker.patch.multiple('freqtrade.main.exchange', + _CONF=conf, + init=MagicMock()) init(conf, 'sqlite://') update_state(State.RUNNING) @@ -290,7 +314,10 @@ def test_balance_handle(conf, update, mocker): 'CryptoAddress': 'XXXX'}] mocker.patch.dict('freqtrade.main._CONF', conf) msg_mock = MagicMock() - mocker.patch.multiple('freqtrade.main.telegram', _CONF=conf, init=MagicMock(), send_msg=msg_mock) + mocker.patch.multiple('freqtrade.main.telegram', + _CONF=conf, + init=MagicMock(), + send_msg=msg_mock) mocker.patch.multiple('freqtrade.main.exchange', get_balances=MagicMock(return_value=mock_balance))