adelorenzo/stable
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

update get_valid_price function and test cases to handle inputs with try catch

Browse Source
This commit is contained in:
axel 2021-08-13 11:06:15 -04:00
parent dbf7f34ecb
commit 20cc60bfde
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
freqtrade/freqtradebot.py
View File

@ -1400,11 +1400,9 @@ class FreqtradeBot(LoggingMixin):
:return: valid price for the order
"""
if custom_price:
if isinstance(custom_price, int):
try:
valid_price = float(custom_price)
elif isinstance(custom_price, float):
valid_price = custom_price
else:
except ValueError:
valid_price = proposed_price
else:
valid_price = proposed_price

6
tests/test_freqtradebot.py
View File

@ -4596,19 +4596,23 @@ def test_get_valid_price(mocker, default_conf) -> None:
freqtrade = FreqtradeBot(default_conf)
custom_price_string = "10"
custom_price_badstring = "10abc"
custom_price_float = 10.0
custom_price_int = 10
proposed_price = 12.2
valid_price_from_string = freqtrade.get_valid_price(custom_price_string, proposed_price)
valid_price_from_badstring = freqtrade.get_valid_price(custom_price_badstring, proposed_price)
valid_price_from_int = freqtrade.get_valid_price(custom_price_int, proposed_price)
valid_price_from_float = freqtrade.get_valid_price(custom_price_float, proposed_price)
assert isinstance(valid_price_from_string, float)
assert isinstance(valid_price_from_badstring, float)
assert isinstance(valid_price_from_int, float)
assert isinstance(valid_price_from_float, float)
assert valid_price_from_string == proposed_price
assert valid_price_from_string == custom_price_float
assert valid_price_from_badstring == proposed_price
assert valid_price_from_int == custom_price_int
assert valid_price_from_float == custom_price_float