From 1f1a819b292ecf927c2d332a1fd788ac5b7359a6 Mon Sep 17 00:00:00 2001 From: Matthias Date: Wed, 12 Aug 2020 11:21:00 +0200 Subject: [PATCH] Remove unused 3rd argument to create_stoploss call --- freqtrade/freqtradebot.py | 10 ++++------ tests/test_freqtradebot.py | 2 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/freqtrade/freqtradebot.py b/freqtrade/freqtradebot.py index 967f68b90..3168976e2 100644 --- a/freqtrade/freqtradebot.py +++ b/freqtrade/freqtradebot.py @@ -768,7 +768,7 @@ class FreqtradeBot: logger.debug('Found no sell signal for %s.', trade) return False - def create_stoploss_order(self, trade: Trade, stop_price: float, rate: float) -> bool: + def create_stoploss_order(self, trade: Trade, stop_price: float) -> bool: """ Abstracts creating stoploss orders from the logic. Handles errors and updates the trade database object. @@ -831,14 +831,13 @@ class FreqtradeBot: stoploss = self.edge.stoploss(pair=trade.pair) if self.edge else self.strategy.stoploss stop_price = trade.open_rate * (1 + stoploss) - if self.create_stoploss_order(trade=trade, stop_price=stop_price, rate=stop_price): + if self.create_stoploss_order(trade=trade, stop_price=stop_price): trade.stoploss_last_update = datetime.now() return False # If stoploss order is canceled for some reason we add it if stoploss_order and stoploss_order['status'] in ('canceled', 'cancelled'): - if self.create_stoploss_order(trade=trade, stop_price=trade.stop_loss, - rate=trade.stop_loss): + if self.create_stoploss_order(trade=trade, stop_price=trade.stop_loss): return False else: trade.stoploss_order_id = None @@ -875,8 +874,7 @@ class FreqtradeBot: f"for pair {trade.pair}") # Create new stoploss order - if not self.create_stoploss_order(trade=trade, stop_price=trade.stop_loss, - rate=trade.stop_loss): + if not self.create_stoploss_order(trade=trade, stop_price=trade.stop_loss): logger.warning(f"Could not create trailing stoploss order " f"for pair {trade.pair}.") diff --git a/tests/test_freqtradebot.py b/tests/test_freqtradebot.py index 5c225bbc0..87071be3e 100644 --- a/tests/test_freqtradebot.py +++ b/tests/test_freqtradebot.py @@ -1301,7 +1301,7 @@ def test_create_stoploss_order_invalid_order(mocker, default_conf, caplog, fee, freqtrade.enter_positions() trade = Trade.query.first() caplog.clear() - freqtrade.create_stoploss_order(trade, 200, 199) + freqtrade.create_stoploss_order(trade, 200) assert trade.stoploss_order_id is None assert trade.sell_reason == SellType.EMERGENCY_SELL.value assert log_has("Unable to place a stoploss order on exchange. ", caplog)