From 14758dbe107d4a460444719c78b7f9fd5477b5b1 Mon Sep 17 00:00:00 2001 From: Matthias Date: Wed, 30 Oct 2019 16:32:22 +0100 Subject: [PATCH] Some small cleanups --- freqtrade/configuration/deprecated_settings.py | 7 +++++++ freqtrade/pairlist/LowPriceFilter.py | 4 ++-- tests/test_configuration.py | 10 ++++++++++ 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/freqtrade/configuration/deprecated_settings.py b/freqtrade/configuration/deprecated_settings.py index f00b23894..8471028aa 100644 --- a/freqtrade/configuration/deprecated_settings.py +++ b/freqtrade/configuration/deprecated_settings.py @@ -57,3 +57,10 @@ def process_temporary_deprecated_settings(config: Dict[str, Any]) -> None: 'experimental', 'sell_profit_only') process_deprecated_setting(config, 'ask_strategy', 'ignore_roi_if_buy_signal', 'experimental', 'ignore_roi_if_buy_signal') + + if config.get('pairlist', {}).get('config', {}).get('precision_filter'): + logger.warning( + "DEPRECATED: " + f"Using precision_filter setting is deprecated and has been replaced by" + "PrecisionFilter. Please refer to the docs on configuration details") + config['pairlist'].update({'filters': {'PrecisionFilter': {}}}) diff --git a/freqtrade/pairlist/LowPriceFilter.py b/freqtrade/pairlist/LowPriceFilter.py index 499dd0c15..778c9b4e0 100644 --- a/freqtrade/pairlist/LowPriceFilter.py +++ b/freqtrade/pairlist/LowPriceFilter.py @@ -15,7 +15,7 @@ class LowPriceFilter(IPairListFilter): self._low_price_percent = config['pairlist']['filters']['LowPriceFilter'].get( 'low_price_percent', 0) - def _validate_precision_filter_lowprice(self, ticker) -> bool: + def _validate_ticker_lowprice(self, ticker) -> bool: """ Check if if one price-step is > than a certain barrier. :param ticker: ticker dict as returned from ccxt.load_markets() @@ -42,7 +42,7 @@ class LowPriceFilter(IPairListFilter): ticker = [t for t in tickers if t['symbol'] == p][0] # Filter out assets which would not allow setting a stoploss - if self._low_price_percent and not self._validate_precision_filter_lowprice(ticker): + if self._low_price_percent and not self._validate_ticker_lowprice(ticker): pairlist.remove(p) return pairlist diff --git a/tests/test_configuration.py b/tests/test_configuration.py index 545dd5df4..258088925 100644 --- a/tests/test_configuration.py +++ b/tests/test_configuration.py @@ -963,6 +963,16 @@ def test_process_temporary_deprecated_settings(mocker, default_conf, setting, ca assert default_conf[setting[0]][setting[1]] == setting[5] +def test_process_deprecated_setting_precision_filter(mocker, default_conf, caplog): + patched_configuration_load_config_file(mocker, default_conf) + default_conf.update({'pairlist': { + 'config': {'precision_filter': True} + }}) + + process_temporary_deprecated_settings(default_conf) + assert log_has_re(r'DEPRECATED.*precision_filter.*', caplog) + + def test_check_conflicting_settings(mocker, default_conf, caplog): patched_configuration_load_config_file(mocker, default_conf)