From 129a88d5da1879e1cae93e1771a995da6d5f0bfc Mon Sep 17 00:00:00 2001
From: Matthias <xmatthias@outlook.com>
Date: Wed, 11 Mar 2020 19:53:28 +0100
Subject: [PATCH] Extract emptyness check to it's own method

---
 freqtrade/data/history/idatahandler.py | 27 ++++++++++++++------------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/freqtrade/data/history/idatahandler.py b/freqtrade/data/history/idatahandler.py
index 87810c95f..bde9612f2 100644
--- a/freqtrade/data/history/idatahandler.py
+++ b/freqtrade/data/history/idatahandler.py
@@ -147,12 +147,7 @@ class IDataHandler(ABC):
 
         pairdf = self._ohlcv_load(pair, timeframe,
                                   timerange=timerange_startup)
-        if pairdf.empty:
-            if warn_no_data:
-                logger.warning(
-                    f'No history data for pair: "{pair}", timeframe: {timeframe}. '
-                    'Use `freqtrade download-data` to download the data'
-                )
+        if self._check_empty_df(pairdf, pair, timeframe, warn_no_data):
             return pairdf
         else:
             enddate = pairdf.iloc[-1]['date']
@@ -160,12 +155,7 @@ class IDataHandler(ABC):
             if timerange_startup:
                 self._validate_pairdata(pair, pairdf, timerange_startup)
                 pairdf = trim_dataframe(pairdf, timerange_startup)
-                if pairdf.empty:
-                    if warn_no_data:
-                        logger.warning(
-                            f'No history data for pair: "{pair}", timeframe: {timeframe}. '
-                            'Use `freqtrade download-data` to download the data'
-                        )
+                if self._check_empty_df(pairdf, pair, timeframe, warn_no_data):
                     return pairdf
 
             # incomplete candles should only be dropped if we didn't trim the end beforehand.
@@ -175,6 +165,19 @@ class IDataHandler(ABC):
                                          drop_incomplete=(drop_incomplete and
                                                           enddate == pairdf.iloc[-1]['date']))
 
+    def _check_empty_df(self, pairdf: DataFrame, pair: str, timeframe: str, warn_no_data: bool):
+        """
+        Warn on empty dataframe
+        """
+        if pairdf.empty:
+            if warn_no_data:
+                logger.warning(
+                    f'No history data for pair: "{pair}", timeframe: {timeframe}. '
+                    'Use `freqtrade download-data` to download the data'
+                )
+            return True
+        return False
+
     def _validate_pairdata(self, pair, pairdata: DataFrame, timerange: TimeRange):
         """
         Validates pairdata for missing data at start end end and logs warnings.