From 0be0ef9e77f8e47ba6d63e95b0c3a4612ce4000c Mon Sep 17 00:00:00 2001 From: Matthias Date: Fri, 13 Jan 2023 07:11:44 +0100 Subject: [PATCH] Remove duplicate binance test The same test exists in test_exchange, but for most exchanges. --- tests/exchange/test_binance.py | 12 ------------ tests/exchange/test_exchange.py | 2 +- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/tests/exchange/test_binance.py b/tests/exchange/test_binance.py index 2bee8f1f5..68e448ab2 100644 --- a/tests/exchange/test_binance.py +++ b/tests/exchange/test_binance.py @@ -575,18 +575,6 @@ async def test__async_get_historic_ohlcv_binance(default_conf, mocker, caplog, c assert log_has_re(r"Candle-data for ETH/BTC available starting with .*", caplog) -@pytest.mark.parametrize("trading_mode,margin_mode,config", [ - ("spot", "", {}), - ("margin", "cross", {"options": {"defaultType": "margin"}}), - ("futures", "isolated", {"options": {"defaultType": "swap"}}), -]) -def test__ccxt_config(default_conf, mocker, trading_mode, margin_mode, config): - default_conf['trading_mode'] = trading_mode - default_conf['margin_mode'] = margin_mode - exchange = get_patched_exchange(mocker, default_conf, id="binance") - assert exchange._ccxt_config == config - - @pytest.mark.parametrize('pair,nominal_value,mm_ratio,amt', [ ("BNB/BUSD", 0.0, 0.025, 0), ("BNB/USDT", 100.0, 0.0065, 0), diff --git a/tests/exchange/test_exchange.py b/tests/exchange/test_exchange.py index 3714291d1..16212e413 100644 --- a/tests/exchange/test_exchange.py +++ b/tests/exchange/test_exchange.py @@ -3957,7 +3957,7 @@ def test_validate_trading_mode_and_margin_mode( @pytest.mark.parametrize("exchange_name,trading_mode,ccxt_config", [ ("binance", "spot", {}), ("binance", "margin", {"options": {"defaultType": "margin"}}), - ("binance", "futures", {"options": {"defaultType": "future"}}), + ("binance", "futures", {"options": {"defaultType": "swap"}}), ("bybit", "spot", {"options": {"defaultType": "spot"}}), ("bybit", "futures", {"options": {"defaultType": "linear"}}), ("gateio", "futures", {"options": {"defaultType": "swap"}}),