Change CryptoToFiatConverter._is_supported_fiat to Static method

We do not need to load the whole object to know if a pair is
in a static list.
Unittest passed from 1.25s to 0.08s
This commit is contained in:
Gerald Lonlas
2018-01-21 13:51:11 -08:00
parent 408f120612
commit 074a4ef65b
2 changed files with 9 additions and 10 deletions

View File

@@ -36,12 +36,11 @@ def test_pair_convertion_object():
assert pair_convertion.price == 30000.123
def test_fiat_convert_is_supported():
fiat_convert = CryptoToFiatConverter()
assert fiat_convert._is_supported_fiat(fiat='USD') is True
assert fiat_convert._is_supported_fiat(fiat='usd') is True
assert fiat_convert._is_supported_fiat(fiat='abc') is False
assert fiat_convert._is_supported_fiat(fiat='ABC') is False
def test_fiat_convert_is_supported(mocker):
assert CryptoToFiatConverter.is_supported_fiat(fiat='USD') is True
assert CryptoToFiatConverter.is_supported_fiat(fiat='usd') is True
assert CryptoToFiatConverter.is_supported_fiat(fiat='abc') is False
assert CryptoToFiatConverter.is_supported_fiat(fiat='ABC') is False
def test_fiat_convert_add_pair():