feat(update): channels, maintenance windows, min-version gate
Some checks failed
ARM64 Build / Build generic ARM64 disk image (push) Failing after 3s
CI / Go Tests (push) Successful in 1m23s
CI / Shellcheck (push) Successful in 46s
CI / Build Go Binaries (amd64, linux, linux-amd64) (push) Successful in 1m32s
CI / Build Go Binaries (arm64, linux, linux-arm64) (push) Successful in 1m15s

Phase 6 of v0.3. The update agent now refuses to apply artifacts whose
channel doesn't match local policy, whose architecture differs from the
running host, or whose min_compatible_version is above the current
version. It also refuses to apply outside a configured maintenance window
unless --force is given.

New package update/pkg/config:
- config.Load parses /etc/kubesolo/update.conf (key=value, # comments,
  unknown keys ignored). Missing file is fine — fresh systems before
  cloud-init has run.
- ParseWindow handles "HH:MM-HH:MM" plus the wrapping midnight case
  (e.g. "23:00-01:00"). Empty input -> AlwaysOpen (no constraint).
  Degenerate zero-length windows never match.
- CompareVersions does a simple 3-component semver compare with the 'v'
  prefix optional and pre-release suffix ignored.
- 14 unit tests total.

update/pkg/image/image.UpdateMetadata gains three optional fields:
- channel ("stable", "beta", ...)
- min_compatible_version (refuse upgrade if current < this)
- architecture ("amd64", "arm64", ...)

update/cmd/opts.go reads update.conf and merges it into opts; explicit
--server / --channel / --pubkey / --maintenance-window CLI flags override
the file. New --force, --conf, --channel, --maintenance-window flags.
Precedence: CLI > config file > package defaults.

update/cmd/apply.go gains four gates in order:
1. Maintenance window — checked locally before any HTTP work; skipped
   with --force.
2. Channel — refused if metadata.channel doesn't match opts.Channel.
3. Architecture — refused if metadata.architecture != runtime.GOARCH.
4. Min compatible version — refused if FromVersion < min_compatible.
All gate failures transition state to Failed with a clear LastError.

cloud-init gains a top-level updates: block (Server, Channel,
MaintenanceWindow, PubKey). cloud-init.ApplyUpdates writes
/etc/kubesolo/update.conf from those fields on first boot. Empty block
leaves any existing file alone (so hand-edited update.conf survives a
reboot without cloud-init re-applying). 4 new tests cover empty / all /
partial / parent-dir-creation cases. full-config.yaml example updated.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-14 18:21:46 -06:00
parent bce565e2f7
commit dfed6ddba8
14 changed files with 839 additions and 16 deletions

View File

@@ -0,0 +1,120 @@
package config
import (
"testing"
"time"
)
func at(hour, min int) time.Time {
return time.Date(2026, 1, 1, hour, min, 0, 0, time.UTC)
}
func TestParseWindowEmpty(t *testing.T) {
w, err := ParseWindow("")
if err != nil {
t.Fatalf("empty window: %v", err)
}
if !w.AlwaysOpen() {
t.Error("empty input should produce AlwaysOpen window")
}
if !w.Contains(at(3, 0)) {
t.Error("AlwaysOpen window should contain any time")
}
if !w.Contains(at(23, 59)) {
t.Error("AlwaysOpen window should contain end-of-day")
}
}
func TestParseWindowSameDay(t *testing.T) {
w, err := ParseWindow("03:00-05:00")
if err != nil {
t.Fatalf("parse: %v", err)
}
tests := []struct {
hour, min int
want bool
}{
{2, 59, false}, // just before
{3, 0, true}, // start (inclusive)
{4, 30, true}, // middle
{4, 59, true}, // just before end
{5, 0, false}, // end (exclusive)
{15, 0, false}, // far outside
}
for _, tt := range tests {
got := w.Contains(at(tt.hour, tt.min))
if got != tt.want {
t.Errorf("Contains(%02d:%02d) = %v, want %v", tt.hour, tt.min, got, tt.want)
}
}
}
func TestParseWindowWrappingMidnight(t *testing.T) {
w, err := ParseWindow("23:00-01:00")
if err != nil {
t.Fatalf("parse: %v", err)
}
tests := []struct {
hour, min int
want bool
}{
{22, 59, false}, // just before
{23, 0, true}, // start (inclusive)
{23, 30, true}, // night-before
{0, 0, true}, // midnight
{0, 30, true}, // early morning
{0, 59, true}, // just before end
{1, 0, false}, // end (exclusive)
{12, 0, false}, // far outside (noon)
}
for _, tt := range tests {
got := w.Contains(at(tt.hour, tt.min))
if got != tt.want {
t.Errorf("Contains(%02d:%02d) wrapping = %v, want %v", tt.hour, tt.min, got, tt.want)
}
}
}
func TestParseWindowDegenerateZeroLength(t *testing.T) {
// 05:00-05:00 is a zero-length window — should never match. Different
// from "always" (empty string).
w, err := ParseWindow("05:00-05:00")
if err != nil {
t.Fatalf("parse: %v", err)
}
if w.AlwaysOpen() {
t.Error("05:00-05:00 must not be AlwaysOpen")
}
if w.Contains(at(5, 0)) {
t.Error("zero-length window must not contain its own boundary")
}
}
func TestParseWindowRejectsBadInput(t *testing.T) {
bad := []string{
"notatime",
"03:00", // no end
"03:00-", // empty end
"03:00-05", // missing minutes
"24:00-05:00", // hour out of range
"03:60-05:00", // minute out of range
"abc:00-05:00", // non-numeric
}
for _, s := range bad {
_, err := ParseWindow(s)
if err == nil {
t.Errorf("ParseWindow(%q) accepted, want error", s)
}
}
}
func TestWindowString(t *testing.T) {
w, _ := ParseWindow("03:05-05:45")
if w.String() != "03:05-05:45" {
t.Errorf("String = %q, want 03:05-05:45", w.String())
}
always, _ := ParseWindow("")
if always.String() != "always" {
t.Errorf("AlwaysOpen.String = %q, want 'always'", always.String())
}
}