feat(update): pre-flight gates + deeper healthcheck + auto-rollback
Some checks failed
ARM64 Build / Build generic ARM64 disk image (push) Failing after 4s
CI / Go Tests (push) Successful in 1m29s
CI / Shellcheck (push) Successful in 48s
CI / Build Go Binaries (amd64, linux, linux-amd64) (push) Successful in 1m12s
CI / Build Go Binaries (arm64, linux, linux-arm64) (push) Has been cancelled
Some checks failed
ARM64 Build / Build generic ARM64 disk image (push) Failing after 4s
CI / Go Tests (push) Successful in 1m29s
CI / Shellcheck (push) Successful in 48s
CI / Build Go Binaries (amd64, linux, linux-amd64) (push) Successful in 1m12s
CI / Build Go Binaries (arm64, linux, linux-arm64) (push) Has been cancelled
Phase 8 of v0.3. Tightens the update lifecycle on both ends. Pre-flight (apply.go, before any download): - Free-space check on the passive partition: image size + 10% headroom must be available. Uses statfs(2) via the new pkg/partition.FreeBytes / HasFreeSpaceFor helpers (tests cover happy path, tiny request, huge request, missing path). Catches corrupted-FS and shrunk-partition cases before we destroy the existing slot data. - Node-block-label check: refuses if the local K8s node carries the updates.kubesolo.io/block=true label. New pkg/health.CheckNodeBlocked shells out to kubectl per the project's zero-deps stance. Silently bypassed when no kubeconfig is reachable (air-gap case). Skipped by --force. Healthcheck (extended via new pkg/health/extended.go + preflight.go): - CheckKubeSystemReady waits until every kube-system pod has held the Running phase for >= N seconds (default 30). Catches "started ok, will crash-loop" bugs that a single-shot phase check misses. - CheckProbeURL fetches an operator-supplied URL; 200 = pass. Wired through update.conf as healthcheck_url= and cloud-init updates.healthcheck_url. - CheckDiskWritable writes/fsyncs/reads a 1-KiB probe under /var/lib/kubesolo. Always runs in healthcheck so a wedged data partition fails fast. - pkg/health.Status grows KubeSystemReady, ProbeURL, DiskWritable booleans. Optional checks default to true in RunAll() so they don't block when unconfigured. health_test.go updated to the new 6-field shape. Auto-rollback (healthcheck.go): - state.UpdateState gains HealthCheckFailures (consecutive post-Activated failures). Reset on a clean pass. - --auto-rollback-after N (also auto_rollback_after= in update.conf) triggers env.ForceRollback() when the failure count reaches the threshold. State transitions to RolledBack with a descriptive LastError. The command still exits with the healthcheck error; the operator/init is expected to reboot. - Only fires while Phase == Activated. Doesn't second-guess a long-stable system that happens to fail one healthcheck. config / opts / cloud-init plumbing: - update.conf gains healthcheck_url= and auto_rollback_after= keys. - New CLI flags: --healthcheck-url, --auto-rollback-after, --kube-system-settle. - cloud-init full-config.yaml documents the new updates: subfields. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
51
update/pkg/health/preflight.go
Normal file
51
update/pkg/health/preflight.go
Normal file
@@ -0,0 +1,51 @@
|
||||
package health
|
||||
|
||||
import (
|
||||
"context"
|
||||
"fmt"
|
||||
"os"
|
||||
"os/exec"
|
||||
"strings"
|
||||
"time"
|
||||
)
|
||||
|
||||
// NodeBlockLabel is the well-known label that workload authors set on the
|
||||
// local node to defer an OS update. When present and "true", apply refuses.
|
||||
const NodeBlockLabel = "updates.kubesolo.io/block"
|
||||
|
||||
// CheckNodeBlocked returns (blocked, error). blocked==true means the local
|
||||
// node carries the updates.kubesolo.io/block=true label and the caller should
|
||||
// refuse the update.
|
||||
//
|
||||
// If the kubeconfig is not available (offline / pre-boot / air-gap), this
|
||||
// returns (false, nil) — silently allowing the update. That's the safe
|
||||
// behaviour for the air-gap case where the node may not be reachable from
|
||||
// the agent's perspective.
|
||||
func CheckNodeBlocked(kubeconfigPath string) (bool, error) {
|
||||
if kubeconfigPath == "" {
|
||||
kubeconfigPath = "/var/lib/kubesolo/pki/admin/admin.kubeconfig"
|
||||
}
|
||||
if _, err := os.Stat(kubeconfigPath); err != nil {
|
||||
// No kubeconfig — assume air-gap / pre-K8s. Don't block updates.
|
||||
return false, nil
|
||||
}
|
||||
|
||||
// Query the node label via kubectl. We don't know the node name a
|
||||
// priori, so we use --kubeconfig on the local admin config and ask for
|
||||
// "the only node" (KubeSolo is single-node by design).
|
||||
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
|
||||
defer cancel()
|
||||
|
||||
cmd := exec.CommandContext(ctx, "kubectl",
|
||||
"--kubeconfig", kubeconfigPath,
|
||||
"get", "node",
|
||||
"-o", `jsonpath={.items[0].metadata.labels.updates\.kubesolo\.io/block}`)
|
||||
out, err := cmd.Output()
|
||||
if err != nil {
|
||||
// API unreachable or no nodes — treat as not blocked (analogous to
|
||||
// the kubeconfig-missing case). We still surface the error so the
|
||||
// caller can decide to log it.
|
||||
return false, fmt.Errorf("query node label: %w", err)
|
||||
}
|
||||
return strings.TrimSpace(string(out)) == "true", nil
|
||||
}
|
||||
Reference in New Issue
Block a user