staticcheck (#313)

* CI: use staticcheck for linting This commit switches the linter for Go code from golint to staticcheck. Golint has been deprecated since last year and staticcheck is a recommended replacement. Signed-off-by: Lucas Servén Marín <lserven@gmail.com> * revendor Signed-off-by: Lucas Servén Marín <lserven@gmail.com> * cmd,pkg: fix lint warnings Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
2022-05-19 19:45:43 +02:00
parent 93f46e03ea
commit 50fbc2eec2
227 changed files with 55458 additions and 2689 deletions
--- a/vendor/honnef.co/go/tools/quickfix/analysis.go
+++ b/vendor/honnef.co/go/tools/quickfix/analysis.go
@@ -0,0 +1,58 @@
+package quickfix
+
+import (
+	"honnef.co/go/tools/analysis/facts"
+	"honnef.co/go/tools/analysis/lint"
+	"honnef.co/go/tools/internal/sharedcheck"
+
+	"golang.org/x/tools/go/analysis"
+	"golang.org/x/tools/go/analysis/passes/inspect"
+)
+
+var Analyzers = lint.InitializeAnalyzers(Docs, map[string]*analysis.Analyzer{
+	"QF1001": {
+		Run:      CheckDeMorgan,
+		Requires: []*analysis.Analyzer{inspect.Analyzer},
+	},
+	"QF1002": {
+		Run:      CheckTaglessSwitch,
+		Requires: []*analysis.Analyzer{inspect.Analyzer},
+	},
+	"QF1003": {
+		Run:      CheckIfElseToSwitch,
+		Requires: []*analysis.Analyzer{inspect.Analyzer},
+	},
+	"QF1004": {
+		Run:      CheckStringsReplaceAll,
+		Requires: []*analysis.Analyzer{inspect.Analyzer},
+	},
+	"QF1005": {
+		Run:      CheckMathPow,
+		Requires: []*analysis.Analyzer{inspect.Analyzer},
+	},
+	"QF1006": {
+		Run:      CheckForLoopIfBreak,
+		Requires: []*analysis.Analyzer{inspect.Analyzer},
+	},
+	"QF1007": {
+		Run:      CheckConditionalAssignment,
+		Requires: []*analysis.Analyzer{inspect.Analyzer},
+	},
+	"QF1008": {
+		Run:      CheckExplicitEmbeddedSelector,
+		Requires: []*analysis.Analyzer{inspect.Analyzer, facts.TokenFile},
+	},
+	"QF1009": {
+		Run:      CheckTimeEquality,
+		Requires: []*analysis.Analyzer{inspect.Analyzer},
+	},
+	"QF1010": {
+		Run:      CheckByteSlicePrinting,
+		Requires: []*analysis.Analyzer{inspect.Analyzer},
+	},
+	"QF1011": sharedcheck.RedundantTypeInDeclarationChecker("could", true),
+	"QF1012": {
+		Run:      CheckWriteBytesSprintf,
+		Requires: []*analysis.Analyzer{inspect.Analyzer},
+	},
+})