Commit Graph

9 Commits

Author SHA1 Message Date
Chad Metcalf
d8a95fadd8
Don't parse empty strings.
Signed-off-by: Chad Metcalf <chad@docker.com>
2020-08-09 15:09:03 -07:00
Chad Metcalf
c600fc36ca
Use assert_success from the bats-assert library.
[ "$status" -eq 0 ] just bails out and its up to you to figure out why.
$output has the stdout/stderr so we could just print that. I think its
worth vendoring the libraries and just using those functions.

Signed-off-by: Chad Metcalf <chad@docker.com>
2020-08-08 14:27:20 -07:00
Chad Metcalf
5185cedf4e
Fixing Mac vs Linux bash shell'ism.
Signed-off-by: Chad Metcalf <chad@docker.com>
2020-08-08 14:27:04 -07:00
Chad Metcalf
702ec96821
Adding a Makefile and basic tests.
This approach uses bats to create a generic docker-compose test. It
checks that images are pullable, projects are buildable, up works, and
if ports are exposed that something is listening.

The tests can be tailored for each example. As long as they are the same
though, you can edit lib/test.bats.example and then `make update-tests`
and all the tests will be synced.

Signed-off-by: Chad Metcalf <chad@docker.com>
2020-08-08 14:26:52 -07:00
Jérémie Drouet
e5828ad1bf react-express-mongodb: clean frontend code
- apply prettier style on every js file
- remove mutation on immutable variables
- remove wrapper on top of axios
- fix form handling
- remove useless port definition in dockerfile

Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
2020-05-13 11:33:48 +02:00
Jérémie Drouet
be7f09b6ba react-express-mongodb: lint sources
to fix some syntax issues in the existing code, the commit
put in place prettier and format the code

Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
2020-05-13 11:33:48 +02:00
Jérémie Drouet
be8875c9b6 react-express-mongodb: rename server to backend
The goal here is to keep the same structure than the other examples.
Also, considering that it has a "frontend" folder, the equivalent for
the server should be "backend".

Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
2020-05-13 11:33:48 +02:00
Guillaume Lours
e29f0d1c54
[react-express-mongdb] use compose network to communicate between services (#62)
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
2020-05-12 11:18:38 +02:00
Syed Afzal
2f750eb4f7
Sample React-Express-MongoDB (#59)
Signed-off-by: Afzal <sah.afzal@gmail.com>
2020-05-11 21:40:39 +02:00